Ensure new files are formatted based on the right language version #57119
Conversation
ghost
added
the
davidwengier
force-pushed
the
FixNewProjectCreation
branch
from
ab291da to
49783af
Compare
|
Putting this up as draft while I wait for an answer from CPS. |
jasonmalinowski
left a comment
jasonmalinowski
left a comment
There was a problem hiding this comment.
Can we get an integration test added?
Also: target against the 17.0 branch?
src/VisualStudio/CSharp/Impl/LanguageService/CSharpEditorFactory.cs
Outdated
Show resolved
Hide resolved
src/VisualStudio/Core/Def/Implementation/AbstractEditorFactory.cs
Outdated
Show resolved
Hide resolved
The bug is currently targeting 17.1 P3, and has a score of 1. I'm assuming that when Dev17 GAs more people will find it and complain, so I like the simpler change for easier serviceability, but I'm happy not aggressively pushing it. |
|
Merged to try to get integration tests passing... and no, it wasn't my test that was failing 😛 |
| VisualStudio.SolutionExplorer.AddProject(project, WellKnownProjectTemplates.ConsoleApplication, LanguageNames.CSharp); | ||
|
|
||
| VisualStudio.ErrorList.ShowErrorList(); | ||
| VisualStudio.ErrorList.Verify.NoErrors(); |
There was a problem hiding this comment.
Should we also have a test for non-legacy project does work in this case?
There was a problem hiding this comment.
I guess it can't hurt to have a non legacy test to ensure it compiles, but I can't get a failing test in non legacy, because I couldn't see a way to specify target framework when creating a project.
src/VisualStudio/IntegrationTest/IntegrationTests/CSharp/CSharpNewDocumentFormatting.cs
Show resolved
Hide resolved
jasonmalinowski
left a comment
jasonmalinowski
left a comment
There was a problem hiding this comment.
Some small tweaks, but 
|
Thanks for the review, I've pushed the updates but I'm still trying to understand this integration test failure which makes no sense (and today, is passing on my machine ¯\_(ツ)_/¯) |
3 participants
Fixes AB#1411721
This fixes new project creation for legacy and CPS with respect to LangVersion issues.