Ensure low-pri fixes go in the right async lightbulb bucket. #57171
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
mavasani
approved these changes
Oct 15, 2021
CyrusNajmabadi
commented
Oct 15, 2021
| { | ||
| currentActionCount += set.Actions.Count(); | ||
| collector.Add(set); | ||
| } |
Member
Author
There was a problem hiding this comment.
@mavasani this will need to be updated when you add support for an actual 'low pri' bucket. actually, afaict, we should hav the following buckets:
- high. this is for Exact-AddUsing, and Rename.
- normal. almost everything else.
- low. Fuzzy-AddUsing, or any specific fixer that we put into the low group.
- lowest. suppress/configure
the general rule is that any fixer in one group can provide fixes for it's group and any group that follows.
CyrusNajmabadi
force-pushed
the
addUsingPriority17.0-b
branch
from
3f3d1eb to
afc6991
Compare
jinujoseph
added
Needs Shiproom Approval
Approved to merge
and removed
Needs Shiproom Approval
labels
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #57157
This is targetting 17.0 to address the async lightbulb regression there. The core issue here is that prior to 'async lightbulbs' 'add using' already had two priority classes. Normal 'exact match' fixes that would show up at the top of the lightbulb, and 'normal pri' 'fuzzy matching' fixes that would show up at the bottom.
When we switched to async lightbulbs this broke as we'd compute all add-using fixes and put them before everything else. The fix here is to not immediately add all lightbulb sets to the bucket we're in. If they're low pri items, we wait until later to add them.
High pri add using fixes
Normal pri other fixes
Normal pri add using fixes