Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Compute val escape for list patterns #57336

Merged
merged 2 commits into from
Oct 28, 2021
Merged

Compute val escape for list patterns #57336

merged 2 commits into from
Oct 28, 2021

Conversation

alrz
Copy link
Member

@alrz alrz commented Oct 22, 2021 •
edited
Loading

Test plan: #51289

@alrz alrz requested a review from a team as a code owner October 22, 2021 22:27
@ghost ghost added the Community The pull request was submitted by a contributor who is not a Microsoft employee. label Oct 22, 2021
@runfoapp runfoapp bot mentioned this pull request Oct 22, 2021
Open
@alrz alrz requested review from jcouv and 333fred October 24, 2021 18:28
@jcouv jcouv mentioned this pull request Oct 24, 2021
Closed
91 tasks
@jcouv jcouv self-assigned this Oct 25, 2021
jcouv
jcouv approved these changes Oct 26, 2021
View reviewed changes
Copy link
Member

@jcouv jcouv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM Thanks (iteration 2)

@alrz
Copy link
Member Author

alrz commented Oct 27, 2021

@333fred for review. thanks.

333fred
333fred approved these changes Oct 28, 2021
View reviewed changes
Copy link
Member

@333fred 333fred left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (commit 2)

@jcouv jcouv merged commit 06beb83 into dotnet:features/list-patterns Oct 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jcouv jcouv jcouv approved these changes

@333fred 333fred 333fred approved these changes

Assignees

@jcouv jcouv

Labels
Area-Compilers Community The pull request was submitted by a contributor who is not a Microsoft employee. Feature - List Patterns
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@alrz @333fred @jcouv