Format list patterns #57568
Merged
Format list patterns #57568
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidwengier
commented
Nov 4, 2021
|
|
||
| namespace Microsoft.CodeAnalysis.CSharp.BraceCompletion | ||
| { | ||
| internal abstract class AbstractCurlyBraceOrBracketCompletionService : AbstractBraceCompletionService |
There was a problem hiding this comment.
This whole class is just a move from CurlyBraceCompletionService except where noted.
davidwengier
commented
Nov 4, 2021
| var root = await document.GetRequiredSyntaxRootAsync(cancellationToken).ConfigureAwait(false); | ||
|
|
||
| var startPoint = openingPoint; | ||
| var endPoint = AdjustFormattingEndPoint(text, root, startPoint, closingPoint); |
There was a problem hiding this comment.
The code in CurlyBraceCompletionService.AdjustFormattingEndPoint was previously inline at this point
davidwengier
commented
Nov 4, 2021
| { | ||
| var originalRoot = await document.GetRequiredSyntaxRootAsync(cancellationToken).ConfigureAwait(false); | ||
| var closeBraceToken = originalRoot.FindToken(closingBraceEndPoint - 1); | ||
| Debug.Assert(IsValidClosingBraceToken(closeBraceToken)); |
There was a problem hiding this comment.
This used to directly check for SyntaxKind.CloseBrace
jcouv
reviewed
Feb 16, 2022
src/Features/CSharp/Portable/BraceCompletion/AbstractCurlyBraceOrBracketCompletionService.cs
Outdated
Show resolved
Hide resolved
jcouv
reviewed
Feb 16, 2022
src/Features/CSharp/Portable/BraceCompletion/AbstractCurlyBraceOrBracketCompletionService.cs
Outdated
Show resolved
Hide resolved
jcouv
reviewed
Feb 16, 2022
src/Features/CSharp/Portable/BraceCompletion/AbstractCurlyBraceOrBracketCompletionService.cs
Outdated
Show resolved
Hide resolved
jcouv
reviewed
Feb 16, 2022
src/Features/CSharp/Portable/BraceCompletion/BracketBraceCompletionService.cs
Outdated
Show resolved
Hide resolved
jcouv
reviewed
Feb 16, 2022
src/Workspaces/SharedUtilitiesAndExtensions/Compiler/CSharp/Formatting/FormattingHelpers.cs
Outdated
Show resolved
Hide resolved
jcouv
reviewed
Feb 16, 2022
...s/SharedUtilitiesAndExtensions/Compiler/CSharp/Formatting/Rules/IndentBlockFormattingRule.cs
Outdated
Show resolved
Hide resolved
jcouv
reviewed
Feb 16, 2022
ghost
added this to the 
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #57244
Extract out a common base class from the
CurlyBraceCompletionServiceso that parts can be shared withBracketBraceCompeltionServicefor list patterns, where we essentially want to format brackets as bracesRelates to test plan #51289