[LSP] Use test accessor task instead of async operation to wait for LSP server shutdown in tests #57824
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ver shutdown in tests. Using the async operation listener caused an issue in RPS when they wait for all async operations to be complete. Since this operation would not complete until VS shutsdown, RPS timed out
ghost
added
the
dibarbet
added
the
LSP
Contributor
|
cc @ryzngard |
allisonchou
approved these changes
Nov 17, 2021
ryzngard
approved these changes
Nov 17, 2021
sharwell
approved these changes
Nov 18, 2021
Member
|
Merging to unblock insertions. |
JoeRobich
pushed a commit
that referenced
this pull request
Nov 18, 2021
[LSP] Use test accessor task instead of async operation to wait for LSP server shutdown in tests Co-authored-by: David Barbet <dabarbet@microsoft.com>
This was referenced Nov 19, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using the async operation listener caused an issue in RPS when they wait for all async operations to be complete. Since this operation would not complete until VS shutsdown (and the LSP server is shutdown), RPS timed out.
Fixes rps issue in https://dev.azure.com/devdiv/DevDiv/_git/VS/pullrequest/364684#view=discussion
Val build in progress - https://devdiv.visualstudio.com/DevDiv/_build/results?buildId=5459216&view=results