Simplify sqlite authoring now that we're 64bit only #57836
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CyrusNajmabadi
requested review from
jasonmalinowski,
JoeRobich and
sharwell
jasonmalinowski
approved these changes
Nov 18, 2021
src/VisualStudio/CSharp/Test/Microsoft.VisualStudio.LanguageServices.CSharp.UnitTests.csproj
Show resolved
Hide resolved
…ing for some reasons
|
Also tagging @Therzok . Need to make sure this won't be an issue for VS4Mac. |
This change only impact our vsix, so VS4Mac should be fine (or rather, won't be broken because of this) |
genlu
approved these changes
Nov 18, 2021
genlu
reviewed
Nov 18, 2021
|
cc @davidwengier for the VSMac awareness |
Therzok
approved these changes
Nov 18, 2021
|
Thanks very much @Therzok . @davidwengier there should be no concerns here for you. Thanks all! |
|
if @Therzok is happy, i'm happy. |
sharwell
reviewed
Nov 18, 2021
| <Content Include="$(NuGetPackageRoot)\sqlitepclraw.lib.e_sqlite3\$(SQLitePCLRawbundle_greenVersion)\runtimes\win-x64\native\e_sqlite3.dll"> | ||
| <Link>runtimes\win-x64\native\e_sqlite3.dll</Link> | ||
| <Link>Core\e_sqlite3.dll</Link> |
There was a problem hiding this comment.
❔ Can we not place it in Core\runtimes\win-x64\native\e_sqlite3.dll?
ghost
added this to the 
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #57827
This also addresses the issue where on CoreCLR calling into sqlite woudl result in a dll-not-found exception happening. Effectively, we just place
e_sqlite.dllnext to all theSQLitePCLRaw.xxxdlls we include. Being right next to them seems to always work for dynamic loading for our two supported scenarios.I'm hoping this simple approach is acceptable.
I have manually validated this both for normal OOP and CoreCLR oop.
Note: i'm not sure if this impacts VS4Mac.