Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exclude unnecessary sqlite assemblies for .Net 6 host #57977

Merged
merged 1 commit into from
Dec 1, 2021

Conversation

genlu
Copy link
Member

@genlu genlu commented Nov 24, 2021

The required file is handled by the vsix project directly (see #57836)

@genlu genlu requested a review from a team as a code owner November 24, 2021 22:36
@genlu genlu changed the title Exclude unnecessary sqlite assemblies Exclude unnecessary sqlite assemblies for .Net 6 host Nov 24, 2021
@genlu genlu added the Area-IDE label Nov 24, 2021
Comment on lines +23 to +24
<!-- the only assembly we need under runtime folder (runtimes\win-x64\native\e_sqlite3.dll) is handled by the vsix project directly -->
<_ExcludedFiles Include="$(PublishDir)\runtimes\**\*.*" />
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this going to cause any surprises down the road if somebody is trying to add something else and this breaks it?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree this is fragile (so does the way we pick and drop the sqlite dll in the roslyn vsix project.) I'm hoping that our integration test would catch it with newly added debug.assert

@genlu genlu enabled auto-merge December 1, 2021 00:18
@JoeRobich
Copy link
Member

The failing unit test is a known flaky test - #34207

Since the Helix run of the Linux Debug tests passed, this is low risk to merge.

@JoeRobich JoeRobich disabled auto-merge December 1, 2021 23:10
@JoeRobich JoeRobich merged commit 7fbc3fc into dotnet:main Dec 1, 2021
@ghost ghost added this to the Next milestone Dec 1, 2021
@genlu genlu deleted the CoreLayout branch December 2, 2021 01:04
@Cosifne Cosifne modified the milestones: Next, 17.1.P3 Jan 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants