Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
364 commits
Select commit Hold shift + click to select a range
5dc6cf1
Remove processed typename check
JoeRobich Sep 29, 2021
1fd42d3
Cache stale results until we are fully synced
CyrusNajmabadi Nov 1, 2021
11ab6e2
Ensure only one storage service factory gets created per workspace.
CyrusNajmabadi Nov 1, 2021
590d7bc
Update cloud cache in the same way
CyrusNajmabadi Nov 1, 2021
6a553c2
Add comment
CyrusNajmabadi Nov 1, 2021
ec1b7c2
Add docs
CyrusNajmabadi Nov 2, 2021
30c493a
Merge pull request #57511 from CyrusNajmabadi/cachePersistenceLocatoin
CyrusNajmabadi Nov 2, 2021
d8264e3
Fix nullability warning
JoeRobich Nov 2, 2021
cef7563
Simplify captures
CyrusNajmabadi Nov 2, 2021
884e3c1
Rename files
CyrusNajmabadi Nov 2, 2021
c6d0a22
Merge remote-tracking branch 'upstream/main' into oneSqliteService
CyrusNajmabadi Nov 2, 2021
4b37d61
Merge remote-tracking branch 'upstream/main' into cacheStaleResults
CyrusNajmabadi Nov 2, 2021
4f4e483
Merge pull request #57496 from dotnet/merges/release/dev17.0-to-relea…
dotnet-bot Nov 2, 2021
7dd1c0d
Merge pull request #57499 from dotnet/merges/release/dev17.0-to-relea…
dotnet-bot Nov 2, 2021
68f3228
Allow the lambda to be cached
CyrusNajmabadi Nov 2, 2021
4751e71
proposed document pull diagnostics implementation
dibarbet Nov 2, 2021
c98b175
Update dependencies from https://github.com/dotnet/arcade build 20211…
dotnet-maestro[bot] Nov 2, 2021
0d04d32
Reduce indirections
CyrusNajmabadi Nov 2, 2021
06d0b64
Reduce indirections
CyrusNajmabadi Nov 2, 2021
ee07eae
Fix
CyrusNajmabadi Nov 2, 2021
482df08
Merge branch 'oneSqliteService' into cacheStaleResults
CyrusNajmabadi Nov 2, 2021
3d30eb0
Make the string table part of the key
CyrusNajmabadi Nov 2, 2021
f64ea36
Disable sql when built from source
CyrusNajmabadi Nov 2, 2021
fe1915e
Merge branch 'oneSqliteService' into cacheStaleResults
CyrusNajmabadi Nov 2, 2021
1d4756c
Merge pull request #57513 from CyrusNajmabadi/oneSqliteService
CyrusNajmabadi Nov 2, 2021
18075ed
Merge remote-tracking branch 'upstream/main' into cacheStaleResults
CyrusNajmabadi Nov 2, 2021
3af8286
Revert
CyrusNajmabadi Nov 2, 2021
2d1c76c
move files
CyrusNajmabadi Nov 2, 2021
1acfff7
wrap
CyrusNajmabadi Nov 2, 2021
ce7264e
Add helper
CyrusNajmabadi Nov 2, 2021
ed77c1b
Doc
CyrusNajmabadi Nov 2, 2021
6356ed0
Style
CyrusNajmabadi Nov 2, 2021
4c1519b
Merge pull request #56860 from JoeRobich/update-codeaction-hashtable
JoeRobich Nov 2, 2021
c428c96
Remove unneeded enum
CyrusNajmabadi Nov 2, 2021
acca669
Flow downwards
CyrusNajmabadi Nov 2, 2021
a18cb5d
Downstream
CyrusNajmabadi Nov 2, 2021
d0e5c59
Fix test
CyrusNajmabadi Nov 2, 2021
22af4f0
Merge pull request #57505 from dotnet/merges/release/dev17.1-to-main
dotnet-bot Nov 3, 2021
5cbfa2e
Update SymReader packages to the latest (#57458)
tmat Nov 3, 2021
bc24901
Add workspace pull diagnostics support
dibarbet Nov 3, 2021
812a5c0
Merge pull request #57514 from CyrusNajmabadi/cacheStaleResults
CyrusNajmabadi Nov 3, 2021
1861faf
Merge remote-tracking branch 'upstream/main' into removeEnum
CyrusNajmabadi Nov 3, 2021
e046cbb
Handle individual paths
CyrusNajmabadi Nov 3, 2021
e3e9bea
Extract code into helper types
CyrusNajmabadi Nov 3, 2021
29438b2
Merge pull request #57534 from CyrusNajmabadi/removeEnum
CyrusNajmabadi Nov 3, 2021
5197dc9
Merge remote-tracking branch 'upstream/main' into removeEnum2
CyrusNajmabadi Nov 3, 2021
83121ec
Update src/Features/Core/Portable/NavigateTo/AbstractNavigateToSearch…
CyrusNajmabadi Nov 3, 2021
22b9c0b
Simplify
CyrusNajmabadi Nov 3, 2021
9b11b72
Merge branch 'removeEnum2' of https://github.com/CyrusNajmabadi/rosly…
CyrusNajmabadi Nov 3, 2021
a1847b6
Inline
CyrusNajmabadi Nov 3, 2021
975084a
Complete the progress
CyrusNajmabadi Nov 3, 2021
3c1b68a
Cancel property
CyrusNajmabadi Nov 3, 2021
5778655
Simplify PDB reading code (#57537)
davidwengier Nov 3, 2021
08775ad
Merge pull request #57502 from panna-ahmed/main
jasonmalinowski Nov 3, 2021
e4334c1
Update the progress API shape to make it easier to mark a set of work…
CyrusNajmabadi Nov 3, 2021
101849e
Merge branch 'progressApi' into removeEnum2
CyrusNajmabadi Nov 3, 2021
51dc674
Simplify
CyrusNajmabadi Nov 3, 2021
4b5932a
Merge branch 'main' into 1esPoolsMain
jonfortescue Nov 3, 2021
00b28f8
Revert move to VS2022 for official build.
JoeRobich Nov 3, 2021
a98c2d6
Merge pull request #57557 from dotnet/dev/jorobich/revert-vs2022
JoeRobich Nov 3, 2021
a502c07
Processing order
CyrusNajmabadi Nov 3, 2021
867da8b
Merge pull request #57421 from jasonmalinowski/allow-async-batch-appl…
jasonmalinowski Nov 4, 2021
6cb64f1
ensure we handle no document correctly
dibarbet Nov 4, 2021
09d214c
Add measure
Cosifne Nov 4, 2021
d58346e
Add comment
Cosifne Nov 4, 2021
e07bfb1
Update dependencies from https://github.com/dotnet/arcade build 20211…
dotnet-maestro[bot] Nov 4, 2021
eec23f6
Merge pull request #57578 from dotnet/release/dev17.0-vs-deps
JoeRobich Nov 4, 2021
bc63c32
Merge pull request #57581 from dotnet/release/dev17.0-vs-deps
JoeRobich Nov 4, 2021
e54a81c
Run tests for both VS lsp diags and proposed diagnostics
dibarbet Nov 4, 2021
8052287
add comment to workspace diagnostics retrieval
dibarbet Nov 4, 2021
b0baf8e
change to protected recorrd struct
dibarbet Nov 4, 2021
77dbfa3
Merge remote-tracking branch 'upstream/main' into progressApi
CyrusNajmabadi Nov 4, 2021
ee5f748
Merge branch 'progressApi' into removeEnum2
CyrusNajmabadi Nov 4, 2021
fb7a860
Re-enable information level logging in loghub now that VS supports de…
dibarbet Nov 4, 2021
bbf6f4c
Verify Smart Break Line behavior with tabs
sharwell Nov 3, 2021
b5686a8
Use DocumentOptionSet instead of IEditorOptions for new line settings
sharwell Nov 4, 2021
3e2c459
Fix flaky issue in the SourceGeneratorItemTests
jasonmalinowski Nov 5, 2021
06bd4a0
Track AbstractFlowPass.PendingBranches by label (#57520)
cston Nov 5, 2021
308d631
Support IFunctionPointerInvocationOperation API
bernd5 Nov 5, 2021
25a71f7
Adjust the order of evaluation for implicit Index/Range support to fo…
AlekseyTs Nov 5, 2021
d3d009d
StackFrame Parser/Lexer as EmbeddedLanguage (#56957)
Nov 5, 2021
85522f1
Merge pull request #57538 from CyrusNajmabadi/removeEnum2
CyrusNajmabadi Nov 5, 2021
6ab724e
Merge pull request #57579 from sharwell/break-line
sharwell Nov 5, 2021
77b8c0e
Merge remote-tracking branch 'upstream/main' into dev/shech/Inheritan…
Cosifne Nov 5, 2021
eefa7fa
Update dependencies from https://github.com/dotnet/arcade build 20211…
dotnet-maestro[bot] Nov 5, 2021
d4fd404
Merge pull request #57004 from MaStr11/CodefixCS1591
sharwell Nov 5, 2021
f8f7ce7
Merge branch 'main' into 1esPoolsMain
jonfortescue Nov 5, 2021
8ccf8bd
Revert to VS2019 for official build
JoeRobich Nov 5, 2021
44f0576
Revert to VS2019 for official build
JoeRobich Nov 5, 2021
155f872
Update azure-pipelines-official.yml
jonfortescue Nov 5, 2021
a3db9a4
Merge branch 'main' into 1esPoolsMain
JoeRobich Nov 5, 2021
49d774e
Merge pull request #57563 from dotnet/merges/release/dev17.0-to-relea…
dotnet-bot Nov 5, 2021
7dc3af5
Merge pull request #57561 from dotnet/merges/release/dev17.0-to-relea…
dotnet-bot Nov 5, 2021
4dcbb7c
Merge pull request #57593 from jasonmalinowski/fix-flaky-tests
jasonmalinowski Nov 5, 2021
302aa3d
Update VS editor package version
genlu Nov 5, 2021
97993be
Clean up VsCodeWindowManager (#57582)
tmat Nov 5, 2021
d1b9b73
Validate the checksum of source on disk (#57541)
davidwengier Nov 5, 2021
fb78a0e
Update dependencies from https://github.com/dotnet/roslyn build 20211…
dotnet-maestro[bot] Nov 5, 2021
9a4ccdd
Revert to VS2019 for PR Validation
JoeRobich Nov 5, 2021
732a2ab
Merge pull request #57445 from Cosifne/dev/shech/InheritanceMarginBen…
Cosifne Nov 5, 2021
efb6343
Install .NET SDK in PR Validation pipeline
JoeRobich Nov 5, 2021
ae9dea8
WIP
CyrusNajmabadi Nov 5, 2021
67594ae
Simplify
CyrusNajmabadi Nov 5, 2021
df61bc6
Add test
CyrusNajmabadi Nov 5, 2021
aac6702
Update src/Features/VisualBasic/Portable/NavigationBar/VisualBasicNav…
CyrusNajmabadi Nov 5, 2021
2cc3af0
Revert
CyrusNajmabadi Nov 5, 2021
14056fd
small feedback
dibarbet Nov 5, 2021
bc3d977
Less linq
CyrusNajmabadi Nov 5, 2021
c175c34
change proposed to experimental
dibarbet Nov 5, 2021
9828d63
Don't crash Use ExpressionBody on local functions in top level statem…
davidwengier Nov 5, 2021
1096066
Merge remote-tracking branch 'upstream/main' into vbEvents
CyrusNajmabadi Nov 5, 2021
929e309
PR feedback
CyrusNajmabadi Nov 6, 2021
fde963d
Simplify
CyrusNajmabadi Nov 6, 2021
953451f
Move the task completion source for a queue item into the queue item …
dibarbet Nov 6, 2021
a2af95f
fix docs
dibarbet Nov 6, 2021
441b10f
Merge pull request #57606 from CyrusNajmabadi/vbEvents
CyrusNajmabadi Nov 6, 2021
934f508
Update dependencies from https://github.com/dotnet/arcade build 20211…
dotnet-maestro[bot] Nov 6, 2021
a7324b0
Merge pull request #55123 from Youssef1313/patch-9
jmarolf Nov 7, 2021
ae8beb0
Merge pull request #54601 from Youssef1313/editorconfig-format
jmarolf Nov 7, 2021
d954f01
Set up integration test project using microsoft/vs-extension-testing
sharwell Nov 5, 2021
e628e3b
Fix expected formatting in tests
sharwell Nov 8, 2021
f10a552
Merge remote-tracking branch 'origin/main' into merges/release/dev17.…
JoeRobich Nov 8, 2021
04e4e5e
Merge pull request #54559 from paul1956/IssueFormatter36891
sharwell Nov 8, 2021
78a8a4a
Merge pull request #56758 from dotnet/darc-main-8973f3e8-5f5c-4db2-93…
JoeRobich Nov 8, 2021
3ea4216
Simplify compilation tracker.
CyrusNajmabadi Nov 8, 2021
ec1997c
Merge pull request #57601 from genlu/bumpEditorVersion
genlu Nov 8, 2021
7696467
Re-enable BuildWithCommandLine test (#57584)
allisonchou Nov 8, 2021
e581c3c
Merge pull request #57602 from dotnet/merges/release/dev17.1-to-main
JoeRobich Nov 8, 2021
c323c6e
Delete unused functions
CyrusNajmabadi Nov 8, 2021
1f79b40
Merge pull request #57588 from dibarbet/reenable_loghub
dibarbet Nov 8, 2021
07a1df3
fix warning
dibarbet Nov 8, 2021
875605d
Merge pull request #57481 from jonfortescue/1esPoolsMain
JoeRobich Nov 8, 2021
f440479
Move hte depedent checksum computation directly into the CompilationT…
CyrusNajmabadi Nov 8, 2021
dd7861e
Don't throw when delay is expedited
genlu Nov 8, 2021
bc72245
Address comment
genlu Nov 8, 2021
cf14a20
AbstractFlowPass - VisitArrayCreation should use the regular way for …
AlekseyTs Nov 8, 2021
33bddf3
Target executable projects and remote workspaces to net6.0 (#57567)
tmat Nov 8, 2021
52e5570
Update tests to account for no longer manually cancelling all tasks i…
dibarbet Nov 8, 2021
2a3beeb
remove unneeded method
dibarbet Nov 8, 2021
fc4c1a6
return task exception directly
dibarbet Nov 8, 2021
bdd3d77
adjust
dibarbet Nov 8, 2021
5a16f23
Merge remote-tracking branch 'upstream/main' into simplify
CyrusNajmabadi Nov 9, 2021
6a2e7ea
Merge branch 'simplify' into depProjectChecksum
CyrusNajmabadi Nov 9, 2021
324fa0f
Fix comment
CyrusNajmabadi Nov 9, 2021
910f720
Fix comment
CyrusNajmabadi Nov 9, 2021
b2e1d2f
Port BasicAddMissingReference.InvokeSomeFixesInVisualBasicThenVerifyR…
sharwell Nov 8, 2021
a63f04d
Warning
CyrusNajmabadi Nov 9, 2021
9727863
Merge pull request #57628 from CyrusNajmabadi/simplify
CyrusNajmabadi Nov 9, 2021
573f06d
Interpolated string handlers in the CFG (#57483)
333fred Nov 9, 2021
b3e6910
Bump dependencies and version for GA (#57573)
davidwengier Nov 9, 2021
ff7dee1
Move cancellation token to tuple with queue item and make CallbackAsy…
dibarbet Nov 9, 2021
c50cf88
remove accessibility modifiers on interface
dibarbet Nov 9, 2021
32da120
small feedback
dibarbet Nov 9, 2021
8325a63
Telemetry improvements (#57406)
tmat Nov 9, 2021
973b3aa
Merge pull request #57632 from CyrusNajmabadi/depProjectChecksum
CyrusNajmabadi Nov 9, 2021
1e66c27
Fix race condition in computing _hostAnalyzerStateMap
mavasani Nov 8, 2021
9183b49
Fix line delta calculation for top-level code (#57556)
tmat Nov 9, 2021
c9aa8f0
Overload resolution was ignoring HasTypeArgumentInferredFromFunctionT…
cston Nov 9, 2021
57780c3
Merge pull request #57029 from dotnet/darc-main-5ffb028a-73fb-40d9-b5…
allisonchou Nov 9, 2021
14e88d2
Merge pull request #57518 from dibarbet/vscode_diags
dibarbet Nov 9, 2021
3a74762
Improve error reporting around conditional access. (#57640)
AlekseyTs Nov 9, 2021
196e953
[main] Update dependencies from dotnet/source-build (#56197)
dotnet-maestro[bot] Nov 9, 2021
a3e25fc
Properly dispose of server in lsp push diag tests
dibarbet Nov 9, 2021
905e634
Remove tracker functionality and move to solution-state
CyrusNajmabadi Nov 9, 2021
3f1ce10
Remove lock
CyrusNajmabadi Nov 9, 2021
5740c55
Add doc
CyrusNajmabadi Nov 9, 2021
8dae3c9
Rename type
CyrusNajmabadi Nov 9, 2021
b52d9a3
Fix issues reported in prior PR
CyrusNajmabadi Nov 9, 2021
d038877
Merge pull request #57641 from dotnet/merges/release/dev17.0-vs-deps-…
JoeRobich Nov 9, 2021
43c3160
Merge branch 'prFeedback2' into skeletonCleanup
CyrusNajmabadi Nov 9, 2021
a461171
Remove unused using
CyrusNajmabadi Nov 9, 2021
1d18383
Remove CWT from skeleton caching and simplify impl
CyrusNajmabadi Nov 9, 2021
c4719d9
Merge remote-tracking branch 'upstream/main' into skeletonCleanup
CyrusNajmabadi Nov 9, 2021
126a69d
Merge branch 'skeletonCleanup' into noCWT
CyrusNajmabadi Nov 9, 2021
8cfddbf
Compare arrow expression clauses when they are children of properties…
davidwengier Nov 9, 2021
32006f1
Merge pull request #57662 from dotnet/merges/release/dev17.1-to-main
dotnet-bot Nov 10, 2021
3705d93
Merge pull request #57656 from CyrusNajmabadi/prFeedback2
CyrusNajmabadi Nov 10, 2021
4be1d9f
Add editor features + rename tracking code action to telemetry table
dibarbet Nov 10, 2021
7b74393
Merge pull request #57669 from dibarbet/editorfeatures_codeactions
JoeRobich Nov 10, 2021
03074fa
Address feedback
mavasani Nov 10, 2021
e60b5fd
Update src/Features/Core/Portable/Diagnostics/EngineV2/DiagnosticIncr…
mavasani Nov 10, 2021
fd2d637
Fix build
mavasani Nov 10, 2021
8f573eb
Update dependencies from https://github.com/dotnet/arcade build 20211…
dotnet-maestro[bot] Nov 10, 2021
1bd3c56
Don't suggest simplification for positional patterns
svick Nov 10, 2021
864ec33
Merge branch 'release/dev17.1' into merges/release/dev17.0-vs-deps-to…
JoeRobich Nov 10, 2021
8bb0dcf
Set XUNIT_LOGS folder so CI artifacts are published
sharwell Nov 10, 2021
25e3fc3
Only offer nullable reference types for C# 8 and newer
sharwell Nov 10, 2021
1dadabf
Merge remote-tracking branch 'upstream/main' into skeletonCleanup
CyrusNajmabadi Nov 10, 2021
d5d921f
Merge pull request #57631 from genlu/NoThrowAwait
genlu Nov 10, 2021
ded01a1
Implement IEquatable<HostAnalyzerStateSetKey>
mavasani Nov 10, 2021
96aaaef
Merge pull request #57676 from svick/dont-simplify-positional-pattern
CyrusNajmabadi Nov 10, 2021
bc5cfc3
Merge pull request #57668 from sharwell/check-langversion
sharwell Nov 10, 2021
e2012f1
Merge pull request #57655 from CyrusNajmabadi/skeletonCleanup
CyrusNajmabadi Nov 10, 2021
95e3137
Merge remote-tracking branch 'upstream/main' into noCWT
CyrusNajmabadi Nov 10, 2021
d0237a3
Kill comment
CyrusNajmabadi Nov 10, 2021
3307e56
remove unnecessary comment
CyrusNajmabadi Nov 10, 2021
2fc5fdb
move comment
CyrusNajmabadi Nov 10, 2021
9aac29d
Merge pull request #57675 from dotnet/darc-main-1bbfbeb8-5fc5-4cbe-ae…
allisonchou Nov 10, 2021
cd23a07
Configure VS registry before launching tests
sharwell Nov 10, 2021
7ada47d
Remove unnecessary LSP workaround
sharwell Nov 10, 2021
85c74d3
Mitigate the GeneratorDriver missync issue while capturing dumps
jasonmalinowski Nov 10, 2021
9c84713
Address feedback
mavasani Nov 11, 2021
8f0fcb5
Hack around the inability to use a custom delegate type
jasonmalinowski Nov 11, 2021
ac39185
Merge pull request #57680 from jasonmalinowski/mitigate-generatordriv…
jasonmalinowski Nov 11, 2021
d242cd8
Ensure that GetAllHostStateSets do not return duplicates from prior s…
mavasani Nov 11, 2021
255f924
Update src/Features/Core/Portable/Diagnostics/EngineV2/DiagnosticIncr…
mavasani Nov 11, 2021
bbd0654
Fix race condition in computing _hostAnalyzerStateMap (#57648)
jinujoseph Nov 11, 2021
edbea66
Don't capture dumps for out-of-sync generator drivers
jasonmalinowski Nov 11, 2021
7e94b6b
Merge pull request #57661 from dotnet/merges/release/dev17.0-vs-deps-…
JoeRobich Nov 11, 2021
497a38c
Fix featureflag name for .net 6 host in UI
genlu Nov 11, 2021
76d4de8
Merge branch 'main' into merges/release/dev17.1-to-main
JoeRobich Nov 11, 2021
add472b
Merge pull request #57714 from jasonmalinowski/remove-dump-request
jasonmalinowski Nov 11, 2021
be71a83
Simplify code from review
sharwell Nov 12, 2021
02a39c0
Merge pull request #57717 from dotnet/merges/release/dev17.1-to-main
allisonchou Nov 12, 2021
c59a4f9
Error when ref is used on a parameter or return type of an UnmanagedC…
333fred Nov 12, 2021
f948cdc
Merge pull request #57626 from sharwell/vs-extension-testing
sharwell Nov 12, 2021
f425556
Merge remote-tracking branch 'upstream/main' into lsp_queue_task
dibarbet Nov 12, 2021
cabd5c5
Merge pull request #57658 from CyrusNajmabadi/noCWT
CyrusNajmabadi Nov 12, 2021
ae6b559
Merge pull request #57723 from genlu/fixOption
genlu Nov 12, 2021
144315a
update error code to fix main break (#57739)
dibarbet Nov 12, 2021
83cc5d4
Merge remote-tracking branch 'upstream/main' into lsp_queue_task
dibarbet Nov 12, 2021
3e792fc
Don't analyze local function bodies as though they are top level code…
davidwengier Nov 12, 2021
497df01
Don't show nullable annotation in completion items of static field/pr…
genlu Nov 12, 2021
a4d1d8f
Remove extra EnsureEditableDocuments calls (#57725)
Nov 12, 2021
e88df76
Load SVsShellDebugger before calling IVsSolution.CreateSolution
sharwell Nov 15, 2021
18cfb2c
Add comment
genlu Nov 15, 2021
08d56b1
Adjust tests for Windows 11 changes (#57678)
jaredpar Nov 15, 2021
6a0e4ec
Merge pull request #57744 from genlu/FixItem
genlu Nov 15, 2021
0634f69
Merge pull request #57716 from dotnet/merges/release/dev17.0-vs-deps-…
dotnet-bot Nov 15, 2021
2da789a
Check constraints on lifted operator types (#57050)
333fred Nov 15, 2021
9c4b3cc
Ensure that getting the checksum for a project cone is resilient to i…
CyrusNajmabadi Nov 15, 2021
0cfbe71
Fix null ref in navbars
CyrusNajmabadi Nov 15, 2021
ed170f4
Add test
CyrusNajmabadi Nov 15, 2021
114aba3
Merge pull request #57773 from dotnet/merges/release/dev17.0-vs-deps-…
dotnet-bot Nov 15, 2021
431f38b
Fix C# language name in spec (#57427)
tmat Nov 15, 2021
d0193d2
Check up front for being called to remove more than once
jasonmalinowski Nov 15, 2021
ad55523
Don't throw exceptions for file changes after a project is unloaded
jasonmalinowski Nov 15, 2021
ef81088
Merge pull request #57617 from dibarbet/lsp_queue_task
dibarbet Nov 16, 2021
fa2d275
Include a type for NoneOperations in VB, print the type in tests (#57…
333fred Nov 16, 2021
4f2e3db
Merge pull request #57776 from CyrusNajmabadi/syncProjectCone
CyrusNajmabadi Nov 16, 2021
67f2b14
Merge pull request #57778 from CyrusNajmabadi/nullRefNavBars
CyrusNajmabadi Nov 16, 2021
09e5511
Merge pull request #57774 from dotnet/merges/release/dev17.1-to-main
dotnet-bot Nov 16, 2021
d9c360e
Merge pull request #57765 from sharwell/load-debugger
sharwell Nov 16, 2021
eb45c4c
Avoid accessing current assembly identity while reporting an accessib…
AlekseyTs Nov 16, 2021
f685f4c
Merge pull request #57786 from dotnet/merges/release/dev17.1-to-main
dotnet-bot Nov 16, 2021
4d98fa2
Merge pull request #57782 from jasonmalinowski/avoid-throwing-excepti…
jasonmalinowski Nov 16, 2021
c7521c9
Fix ValueTracking for index parameters (#57727)
Nov 16, 2021
4db0c4a
Bypass IBCMerge for EditorFeatures.Wpf
genlu Nov 18, 2021
837e83d
Merge pull request #57864 from dotnet/dev/gel/BypassIbcmerge
JoeRobich Nov 18, 2021
4e7c469
Merge branch 'main' of github.com:dotnet/roslyn into merges/main-to-f…
RikkiGibson Nov 18, 2021
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
The table of contents is too big for display.
Diff view
Diff view
  •  
  •  
  •  
15 changes: 11 additions & 4 deletions Roslyn.sln
Original file line number Diff line number Diff line change
Expand Up @@ -500,6 +500,8 @@ Project("{9A19103F-16F7-4668-BE54-9A1E7A4F7556}") = "Microsoft.CodeAnalysis.CSha
EndProject
Project("{9A19103F-16F7-4668-BE54-9A1E7A4F7556}") = "Microsoft.CodeAnalysis.Remote.ServiceHub.UnitTests", "src\Workspaces\Remote\ServiceHubTest\Microsoft.CodeAnalysis.Remote.ServiceHub.UnitTests.csproj", "{8D830CBB-CA6E-47D8-9FB8-9230AAD272F3}"
EndProject
Project("{9A19103F-16F7-4668-BE54-9A1E7A4F7556}") = "Microsoft.VisualStudio.LanguageServices.New.IntegrationTests", "src\VisualStudio\IntegrationTest\New.IntegrationTests\Microsoft.VisualStudio.LanguageServices.New.IntegrationTests.csproj", "{6272739B-31E4-483E-A3A5-2ABB5040ABF0}"
EndProject
Global
GlobalSection(SharedMSBuildProjectFiles) = preSolution
src\Analyzers\VisualBasic\CodeFixes\VisualBasicCodeFixes.projitems*{0141285d-8f6c-42c7-baf3-3c0ccd61c716}*SharedItemsImports = 5
Expand Down Expand Up @@ -1235,10 +1237,10 @@ Global
{8D22FC91-BDFE-4342-999B-D695E1C57E85}.Debug|Any CPU.Build.0 = Debug|Any CPU
{8D22FC91-BDFE-4342-999B-D695E1C57E85}.Release|Any CPU.ActiveCfg = Release|Any CPU
{8D22FC91-BDFE-4342-999B-D695E1C57E85}.Release|Any CPU.Build.0 = Release|Any CPU
{2801F82B-78CE-4BAE-B06F-537574751E2E}.Debug|Any CPU.ActiveCfg = Debug|x86
{2801F82B-78CE-4BAE-B06F-537574751E2E}.Debug|Any CPU.Build.0 = Debug|x86
{2801F82B-78CE-4BAE-B06F-537574751E2E}.Release|Any CPU.ActiveCfg = Release|x86
{2801F82B-78CE-4BAE-B06F-537574751E2E}.Release|Any CPU.Build.0 = Release|x86
{2801F82B-78CE-4BAE-B06F-537574751E2E}.Debug|Any CPU.ActiveCfg = Debug|Any CPU
{2801F82B-78CE-4BAE-B06F-537574751E2E}.Debug|Any CPU.Build.0 = Debug|Any CPU
{2801F82B-78CE-4BAE-B06F-537574751E2E}.Release|Any CPU.ActiveCfg = Release|Any CPU
{2801F82B-78CE-4BAE-B06F-537574751E2E}.Release|Any CPU.Build.0 = Release|Any CPU
{9B25E472-DF94-4E24-9F5D-E487CE5A91FB}.Debug|Any CPU.ActiveCfg = Debug|Any CPU
{9B25E472-DF94-4E24-9F5D-E487CE5A91FB}.Debug|Any CPU.Build.0 = Debug|Any CPU
{9B25E472-DF94-4E24-9F5D-E487CE5A91FB}.Release|Any CPU.ActiveCfg = Release|Any CPU
Expand Down Expand Up @@ -1303,6 +1305,10 @@ Global
{8D830CBB-CA6E-47D8-9FB8-9230AAD272F3}.Debug|Any CPU.Build.0 = Debug|Any CPU
{8D830CBB-CA6E-47D8-9FB8-9230AAD272F3}.Release|Any CPU.ActiveCfg = Release|Any CPU
{8D830CBB-CA6E-47D8-9FB8-9230AAD272F3}.Release|Any CPU.Build.0 = Release|Any CPU
{6272739B-31E4-483E-A3A5-2ABB5040ABF0}.Debug|Any CPU.ActiveCfg = Debug|Any CPU
{6272739B-31E4-483E-A3A5-2ABB5040ABF0}.Debug|Any CPU.Build.0 = Debug|Any CPU
{6272739B-31E4-483E-A3A5-2ABB5040ABF0}.Release|Any CPU.ActiveCfg = Release|Any CPU
{6272739B-31E4-483E-A3A5-2ABB5040ABF0}.Release|Any CPU.Build.0 = Release|Any CPU
EndGlobalSection
GlobalSection(SolutionProperties) = preSolution
HideSolutionNode = FALSE
Expand Down Expand Up @@ -1531,6 +1537,7 @@ Global
{8FCD1B85-BE63-4A2F-8E19-37244F19BE0F} = {55A62CFA-1155-46F1-ADF3-BEEE51B58AB5}
{2B7DC612-1B37-41F7-BE31-4D600930EAC9} = {32A48625-F0AD-419D-828B-A50BDABA38EA}
{8D830CBB-CA6E-47D8-9FB8-9230AAD272F3} = {55A62CFA-1155-46F1-ADF3-BEEE51B58AB5}
{6272739B-31E4-483E-A3A5-2ABB5040ABF0} = {CC126D03-7EAC-493F-B187-DCDEE1EF6A70}
EndGlobalSection
GlobalSection(ExtensibilityGlobals) = postSolution
SolutionGuid = {604E6B91-7BC0-4126-AE07-D4D2FEFC3D29}
Expand Down
8 changes: 6 additions & 2 deletions azure-pipelines-integration-corehost.yml
Original file line number Diff line number Diff line change
Expand Up @@ -18,11 +18,15 @@ pr:
- features/*
- demos/*

variables:
- name: XUNIT_LOGS
value: $(Build.SourcesDirectory)\artifacts\log\$(_configuration)

jobs:
- job: VS_Integration_CoreHost
pool:
name: NetCorePublic-Pool
queue: $(queueName)
name: NetCore1ESPool-Public
demands: ImageOverride -equals $(queueName)
strategy:
maxParallel: 2
matrix:
Expand Down
8 changes: 6 additions & 2 deletions azure-pipelines-integration-lsp.yml
Original file line number Diff line number Diff line change
Expand Up @@ -18,11 +18,15 @@ pr:
- features/*
- demos/*

variables:
- name: XUNIT_LOGS
value: $(Build.SourcesDirectory)\artifacts\log\$(_configuration)

jobs:
- job: VS_Integration_LSP
pool:
name: NetCore1ESPool-Svc-Public
demands: ImageOverride -equals Build.Windows.Amd64.VS2022.Pre.Open
name: NetCore1ESPool-Public
demands: ImageOverride -equals $(queueName)
timeoutInMinutes: 135

steps:
Expand Down
8 changes: 6 additions & 2 deletions azure-pipelines-integration.yml
Original file line number Diff line number Diff line change
Expand Up @@ -14,11 +14,15 @@ pr:
- features/*
- demos/*

variables:
- name: XUNIT_LOGS
value: $(Build.SourcesDirectory)\artifacts\log\$(_configuration)

jobs:
- job: VS_Integration
pool:
name: NetCore1ESPool-Svc-Public
demands: ImageOverride -equals Build.Windows.Amd64.VS2022.Pre.Open
name: $(poolName)
demands: ImageOverride -equals $(queueName)
strategy:
maxParallel: 4
matrix:
Expand Down
2 changes: 1 addition & 1 deletion azure-pipelines-official.yml
Original file line number Diff line number Diff line change
Expand Up @@ -82,7 +82,7 @@ stages:
displayName: Official Build
timeoutInMinutes: 360
pool:
name: NetCore1ESPool-Svc-Internal
name: NetCore1ESPool-Internal
demands: ImageOverride -equals Build.Server.Amd64.VS2019

steps:
Expand Down
16 changes: 12 additions & 4 deletions azure-pipelines-pr-validation.yml
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,7 @@ stages:
timeoutInMinutes: 360
# Conditionally set build pool so we can share this YAML when building with different pipeline
pool:
name: VSEngSS-MicroBuild2017
name: VSEngSS-MicroBuild2019-1ES
demands:
- msbuild
- visualstudio
Expand Down Expand Up @@ -89,6 +89,14 @@ stages:
inputs:
nuGetServiceConnections: azure-public/vs-impl, azure-public/vssdk

# Needed because the build fails the NuGet Tools restore without it
- task: UseDotNet@2
displayName: 'Use .NET Core sdk'
inputs:
packageType: sdk
useGlobalJson: true
workingDirectory: '$(Build.SourcesDirectory)'

# Needed to restore the Microsoft.DevDiv.Optimization.Data.PowerShell package
- task: NuGetCommand@2
displayName: Restore internal tools
Expand Down Expand Up @@ -210,7 +218,7 @@ stages:
displayName: Create Insertion
dependsOn:
- build

jobs:
- job: insert
displayName: Insert to VS
Expand All @@ -220,7 +228,7 @@ stages:
- powershell: Write-Host "##vso[task.setvariable variable=SourceBranchName]$('$(Build.SourceBranch)'.Substring('refs/heads/'.Length))"
displayName: Setting SourceBranchName variable
condition: succeeded()

- template: eng/pipelines/insert.yml
parameters:
createDraftPR: true
Expand All @@ -232,4 +240,4 @@ stages:
titlePrefix: ${{ parameters.OptionalTitlePrefix }}
sourceBranch: $(SourceBranchName)
publishDataURI: "https://raw.githubusercontent.com/dotnet/roslyn/main/eng/config/PublishData.json"

4 changes: 2 additions & 2 deletions azure-pipelines-richnav.yml
Original file line number Diff line number Diff line change
Expand Up @@ -19,8 +19,8 @@ pr: none
jobs:
- job: RichCodeNav_Indexing
pool:
name: NetCore1ESPool-Svc-Public
demands: ImageOverride -equals Build.Windows.10.Amd64.Open
name: NetCore1ESPool-Public
demands: ImageOverride -equals Build.Windows.Amd64.VS2022.Pre.Open
variables:
EnableRichCodeNavigation: true
timeoutInMinutes: 200
Expand Down
12 changes: 6 additions & 6 deletions azure-pipelines.yml
Original file line number Diff line number Diff line change
Expand Up @@ -21,14 +21,14 @@ jobs:
jobName: Build_Windows_Debug
testArtifactName: Transport_Artifacts_Windows_Debug
configuration: Debug
queueName: Build.Windows.10.Amd64.Open
queueName: Build.Windows.Amd64.VS2022.Pre.Open

- template: eng/pipelines/build-windows-job.yml
parameters:
jobName: Build_Windows_Release
testArtifactName: Transport_Artifacts_Windows_Release
configuration: Release
queueName: Build.Windows.10.Amd64.Open
queueName: Build.Windows.Amd64.VS2022.Pre.Open

- template: eng/pipelines/test-windows-job.yml
parameters:
Expand Down Expand Up @@ -153,7 +153,7 @@ jobs:

- job: Correctness_Determinism
pool:
name: NetCore1ESPool-Svc-Public
name: NetCore1ESPool-Public
demands: ImageOverride -equals Build.Windows.Amd64.VS2022.Pre.Open
timeoutInMinutes: 90
steps:
Expand All @@ -169,7 +169,7 @@ jobs:

- job: Correctness_Build
pool:
name: NetCore1ESPool-Svc-Public
name: NetCore1ESPool-Public
demands: ImageOverride -equals Build.Windows.Amd64.VS2022.Pre.Open
timeoutInMinutes: 90
steps:
Expand Down Expand Up @@ -201,8 +201,8 @@ jobs:

- job: Correctness_Rebuild
pool:
name: NetCore1ESPool-Svc-Public
demands: ImageOverride -equals Build.Windows.10.Amd64.Open
name: NetCore1ESPool-Public
demands: ImageOverride -equals Build.Windows.Amd64.VS2022.Pre.Open
timeoutInMinutes: 90
steps:
- template: eng/pipelines/checkout-windows-task.yml
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -108,4 +108,3 @@ These are _function_type_conversions_.
}
}
```

22 changes: 22 additions & 0 deletions docs/compilers/CSharp/Compiler Breaking Changes - DotNet 7.md
Original file line number Diff line number Diff line change
Expand Up @@ -34,3 +34,25 @@
public CustomHandler(int literalLength, int formattedCount, C c) {}
}
```


3. In Visual Studio 17.1, `ref`/`ref readonly`/`in`/`out` are not allowed to be used on return/parameters of a method attributed with `UnmanagedCallersOnly`.
https://github.com/dotnet/roslyn/issues/57025

```cs
using System.Runtime.InteropServices;
[UnmanagedCallersOnly]
static ref int M1() => throw null; // error CS8977: Cannot use 'ref', 'in', or 'out' in a method attributed with 'UnmanagedCallersOnly'.

[UnmanagedCallersOnly]
static ref readonly int M2() => throw null; // error CS8977: Cannot use 'ref', 'in', or 'out' in a method attributed with 'UnmanagedCallersOnly'.

[UnmanagedCallersOnly]
static void M3(ref int o) => throw null; // error CS8977: Cannot use 'ref', 'in', or 'out' in a method attributed with 'UnmanagedCallersOnly'.

[UnmanagedCallersOnly]
static void M4(in int o) => throw null; // error CS8977: Cannot use 'ref', 'in', or 'out' in a method attributed with 'UnmanagedCallersOnly'.

[UnmanagedCallersOnly]
static void M5(out int o) => throw null; // error CS8977: Cannot use 'ref', 'in', or 'out' in a method attributed with 'UnmanagedCallersOnly'.
```
12 changes: 6 additions & 6 deletions docs/features/pdb-compilation-options.md
Original file line number Diff line number Diff line change
Expand Up @@ -133,15 +133,15 @@ foreach (var handle in metadataReader.GetCustomDebugInformation(EntityHandle.Mod

### Compiler Options custom debug information

The remaining values will be stored as key value pairs in the pdb. The storage format will be UTF8 encoded key value pairs that are null terminated. Order is not guaranteed. Any values left out can be assumed to be the default for the type. Keys may be different for Visual Basic and CSharp. They are serialized to reflect the command line arguments representing the same values
The remaining values will be stored as key value pairs in the pdb. The storage format will be UTF8 encoded key value pairs that are null terminated. Order is not guaranteed. Any values left out can be assumed to be the default for the type. Keys may be different for Visual Basic and C#. They are serialized to reflect the command line arguments representing the same values

Example:

`compilerversion\01.2.3-example-sha\0sourceencoding\0utf-8\0checked\01\0unsafe\01\0langversion\0latest\0nullable\0Enable`

## List of Compiler Flags

#### CSharp Flags That Can Be Derived From PDB or Assembly
#### C# Flags That Can Be Derived From PDB or Assembly

* baseaddress
* checksumalgorithm
Expand Down Expand Up @@ -171,7 +171,7 @@ Example:
* win32manifest
* win32res

#### CSharp Flags Not Included
#### C# Flags Not Included

* bugreport
* delaysign
Expand Down Expand Up @@ -255,11 +255,11 @@ Example:
* verbose
* warnaserror

#### Shared Options for CSharp and Visual Basic
#### Shared Options for C# and Visual Basic

| PDB Key | Format | Default | Description |
| ---------------------- | --------------------------------------- | --------- | ------------ |
| language | `CSharp\|Visual Basic` | required | Language name. |
| language | `C#\|Visual Basic` | required | Language name. |
| compiler-version | [SemVer2](https://semver.org/spec/v2.0.0.html) string | required | Full version with SHA |
| runtime-version | [SemVer2](https://semver.org/spec/v2.0.0.html) string | required | [runtime version](#runtime-version) |
| source-file-count | int32 | required | Count of files in the document table that are source files |
Expand All @@ -270,7 +270,7 @@ Example:
| output-kind | string | require | The value passed to `/target` |
| platform | string | require | The value passed to `/platform` |

#### Options For CSharp
#### Options For C\#

See [compiler options](https://docs.microsoft.com/en-us/dotnet/csharp/language-reference/compiler-options/listed-alphabetically) documentation

Expand Down
16 changes: 8 additions & 8 deletions eng/Version.Details.xml
Original file line number Diff line number Diff line change
Expand Up @@ -6,25 +6,25 @@
<Sha>7e80445ee82adbf9a8e6ae601ac5e239d982afaa</Sha>
<SourceBuild RepoName="xliff-tasks" ManagedOnly="true" />
</Dependency>
<Dependency Name="Microsoft.SourceBuild.Intermediate.source-build" Version="0.1.0-alpha.1.21452.1">
<Dependency Name="Microsoft.SourceBuild.Intermediate.source-build" Version="0.1.0-alpha.1.21558.1">
<Uri>https://github.com/dotnet/source-build</Uri>
<Sha>a9515db097e05728fcc2169d074eae3c6a4580d0</Sha>
<Sha>50f26e9983277650d82d193296b2ccc50683f6b6</Sha>
<SourceBuild RepoName="source-build" ManagedOnly="true" />
</Dependency>
</ProductDependencies>
<ToolsetDependencies>
<Dependency Name="Microsoft.DotNet.Arcade.Sdk" Version="7.0.0-beta.21474.2">
<Dependency Name="Microsoft.DotNet.Arcade.Sdk" Version="7.0.0-beta.21559.3">
<Uri>https://github.com/dotnet/arcade</Uri>
<Sha>3ea0d860c6973f2cbadc9e895c7ec2cbdaec4ad5</Sha>
<Sha>fecf65bedcee9036b8ba9d8d7feef5413f294914</Sha>
<SourceBuild RepoName="arcade" ManagedOnly="true" />
</Dependency>
<Dependency Name="Microsoft.Net.Compilers.Toolset" Version="4.0.0-5.21469.2">
<Dependency Name="Microsoft.Net.Compilers.Toolset" Version="4.1.0-1.21553.8">
<Uri>https://github.com/dotnet/roslyn</Uri>
<Sha>c1d8c6f043bc80425c6828455eb57f8a404759c6</Sha>
<Sha>4ba1d9d2984e212af9d6ebff95dedb8a3739c661</Sha>
</Dependency>
<Dependency Name="Microsoft.DotNet.Helix.Sdk" Version="7.0.0-beta.21474.2">
<Dependency Name="Microsoft.DotNet.Helix.Sdk" Version="7.0.0-beta.21559.3">
<Uri>https://github.com/dotnet/arcade</Uri>
<Sha>3ea0d860c6973f2cbadc9e895c7ec2cbdaec4ad5</Sha>
<Sha>fecf65bedcee9036b8ba9d8d7feef5413f294914</Sha>
</Dependency>
</ToolsetDependencies>
</Dependencies>
Loading