Skip to content

Conversation

@RikkiGibson
Copy link
Member

@RikkiGibson RikkiGibson commented Nov 18, 2021

Resolving some trivial merge conflicts.

JoeRobich and others added 30 commits November 1, 2021 16:04
…ocatoin

Avoid recomputing expensive persistence location data that does not change.
…-release/dev17.1

Merge release/dev17.0 to release/dev17.1
…-release/dev17.0-vs-deps

Merge release/dev17.0 to release/dev17.0-vs-deps
…102.1

Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.Helix.Sdk
 From Version 7.0.0-beta.21474.2 -> To Version 7.0.0-beta.21552.1
Ensure only one storage service factory gets created per workspace.
dotnet-bot and others added 17 commits November 15, 2021 14:52
…-deps-to-release/dev17.1

Merge release/dev17.0-vs-deps to release/dev17.1
* Fix C# language name in spec

* Update docs/features/pdb-compilation-options.md

Co-authored-by: Youssef Victor <youssefvictor00@gmail.com>

Co-authored-by: Youssef Victor <youssefvictor00@gmail.com>
Move the task completion source for a queue item into the queue item itself.
Ensure that getting the checksum for a project cone is resilient to its project references being missing
Load SVsShellDebugger before calling IVsSolution.CreateSolution
…ility diagnostics for an inaccessible internal symbol. (dotnet#57783)

This avoids an infinite cycle during attribute binding. Fixes dotnet#57742.
…xceptions-during-unload

Don't throw exceptions for file changes after a project is unloaded
Index values weren't properly handled previously, and it was assumed all parameters existed in a method. In reality some exist in properties. Who knew!??!

No need to worry about the cast, symbol finder will do the right thing. Code does need to be updated to handle the fact that we want to track potentially two things with index: the argument passed in as the index in callsites, and potentially the item being indexed to. Update the FindReferencesProgress to handle references for index specifically.

Fixes dotnet#57100
Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Auto-approval

@ghost ghost merged commit 7854604 into dotnet:features/param-nullchecking Nov 19, 2021
@RikkiGibson RikkiGibson deleted the merges/main-to-features/param-nullchecking branch November 19, 2021 01:35
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.