-
Notifications
You must be signed in to change notification settings - Fork 4.2k
Merges/main to features/param nullchecking #57866
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
364 commits merged into
dotnet:features/param-nullchecking
from
RikkiGibson:merges/main-to-features/param-nullchecking
Nov 19, 2021
Merged
Merges/main to features/param nullchecking #57866
364 commits merged into
dotnet:features/param-nullchecking
from
RikkiGibson:merges/main-to-features/param-nullchecking
Nov 19, 2021
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ocatoin Avoid recomputing expensive persistence location data that does not change.
…-release/dev17.1 Merge release/dev17.0 to release/dev17.1
…-release/dev17.0-vs-deps Merge release/dev17.0 to release/dev17.0-vs-deps
…102.1 Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.Helix.Sdk From Version 7.0.0-beta.21474.2 -> To Version 7.0.0-beta.21552.1
Ensure only one storage service factory gets created per workspace.
…-deps-to-release/dev17.1 Merge release/dev17.0-vs-deps to release/dev17.1
* Fix C# language name in spec * Update docs/features/pdb-compilation-options.md Co-authored-by: Youssef Victor <youssefvictor00@gmail.com> Co-authored-by: Youssef Victor <youssefvictor00@gmail.com>
This just ensures some sanity.
Move the task completion source for a queue item into the queue item itself.
Ensure that getting the checksum for a project cone is resilient to its project references being missing
Fix null ref in navbars
…-main Merge release/dev17.1 to main
Load SVsShellDebugger before calling IVsSolution.CreateSolution
…ility diagnostics for an inaccessible internal symbol. (dotnet#57783) This avoids an infinite cycle during attribute binding. Fixes dotnet#57742.
…-main Merge release/dev17.1 to main
…xceptions-during-unload Don't throw exceptions for file changes after a project is unloaded
Index values weren't properly handled previously, and it was assumed all parameters existed in a method. In reality some exist in properties. Who knew!??! No need to worry about the cast, symbol finder will do the right thing. Code does need to be updated to handle the fact that we want to track potentially two things with index: the argument passed in as the index in callsites, and potentially the item being indexed to. Update the FindReferencesProgress to handle references for index specifically. Fixes dotnet#57100
Bypass IBCMerge for EditorFeatures.Wpf
…eatures/param-nullchecking
ghost
approved these changes
Nov 18, 2021
ghost
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Auto-approval
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolving some trivial merge conflicts.