Unify representation of an implicit Index indexer over an array and non-array types.
#57918
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… non-array types.
|
@jcouv, @dotnet/roslyn-compiler Please review. |
jcouv
reviewed
Nov 22, 2021
| case BoundArrayAccess arrayAccess: | ||
| return arrayAccess.Expression.Type; | ||
|
|
||
| case BoundImplicitIndexerAccess { IndexerOrSliceAccess: BoundArrayAccess arrayAccess }: |
There was a problem hiding this comment.
nit: Consider commenting: this case is array[int] and the one above is array[Index/Range] #Pending
jcouv
reviewed
Nov 22, 2021
| if (makeOffsetInput.ConstantValue is null) | ||
| BoundExpression lengthAccess = RewriteLengthAccess(node, receiver); | ||
|
|
||
| // ensure we evaluate the input before accessing length, unless it is an array length |
There was a problem hiding this comment.
why is array length different in terms of ordering? #Resolved
There was a problem hiding this comment.
why is array length different in terms of ordering?
Because it is an IL instruction, not a property access. I.e. not observable. There is no change in behavior here, we are doing what we used to do.
|
@dotnet/roslyn-compiler For the second review. |
1 similar comment
|
@dotnet/roslyn-compiler For the second review. |
1 task
|
@dotnet/roslyn-compiler For the second review. |
chsienki
approved these changes
Nov 23, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.