Implement GetTypesByMetadataName #58366
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closes dotnet#57802. Implements the GetTypesByMetadataName API, which returns all named types in the current compilation and referenced assemblies that match the given CLR metatdata name. Also updates the IDE's GetBestTypeByMetadataName to use this API under the hood, rather than the existing manual walk they were doing, simplyfing that codepath and proving out the API itself.
Youssef1313
reviewed
Dec 16, 2021
Co-authored-by: Youssef Victor <youssefvictor00@gmail.com>
This was referenced Dec 16, 2021
…ing for GetTypesByMetadataName to match.
CyrusNajmabadi
approved these changes
Jan 6, 2022
AlekseyTs
reviewed
Jan 6, 2022
AlekseyTs
reviewed
Jan 6, 2022
AlekseyTs
reviewed
Jan 6, 2022
AlekseyTs
reviewed
Jan 6, 2022
AlekseyTs
reviewed
Jan 6, 2022
AlekseyTs
reviewed
Jan 6, 2022
AlekseyTs
reviewed
Jan 6, 2022
AlekseyTs
reviewed
Jan 6, 2022
AlekseyTs
reviewed
Jan 7, 2022
src/Compilers/CSharp/Test/Symbol/Compilation/CompilationAPITests.cs
Outdated
Show resolved
Hide resolved
AlekseyTs
reviewed
Jan 7, 2022
AlekseyTs
reviewed
Jan 7, 2022
|
Done with review pass (commit 5). |
|
@AlekseyTs addressed your feedback. In reply to: 1007034424 |
RikkiGibson
reviewed
Jan 7, 2022
RikkiGibson
approved these changes
Jan 7, 2022
333fred
added a commit
that referenced
this pull request
Jan 11, 2022
333fred
added a commit
to 333fred/roslyn
that referenced
this pull request
Jan 12, 2022
…pped * upstream/release/dev17.1: Revert "Implement GetTypesByMetadataName (dotnet#58366)" (dotnet#58784)
333fred
added a commit
that referenced
this pull request
Jan 12, 2022
333fred
added a commit
that referenced
this pull request
Jan 13, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #57802. Implements the GetTypesByMetadataName API, which returns all named types in the current compilation and referenced assemblies that match the given CLR metatdata name. Also updates the IDE's GetBestTypeByMetadataName to use this API under the hood, rather than the existing manual walk they were doing, simplyfing that codepath and proving out the API itself.