Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement GetTypesByMetadataName #58366

Merged
merged 8 commits into from
Jan 7, 2022
Merged

Implement GetTypesByMetadataName #58366

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
6116f32
Implement GetTypesByMetadataName
333fred Dec 16, 2021
e8ca868
Fix spelling
333fred Dec 16, 2021
24025f9
Add additional documentation for GetTypeByMetadataName, update filter…
333fred Jan 6, 2022
905ad80
Remove duplicate list tag.
333fred Jan 6, 2022
295d86c
Couple more doc clarity updates
333fred Jan 6, 2022
baa38e2
Wording clarifications and test updates.
333fred Jan 7, 2022
8d79a2b
Call the correct GetTypeByMetadataName
333fred Jan 7, 2022
5aba763
Fix spelling
333fred Jan 7, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
277 changes: 277 additions & 0 deletions src/Compilers/CSharp/Test/Symbol/Compilation/CompilationAPITests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3036,5 +3036,282 @@ void M1()
}

#endregion

#region GetTypesByMetadataName Tests

[Fact]
public void GetTypesByMetadataName_NotInSourceNotInReferences()
{
var comp = CreateCompilation("");
comp.VerifyDiagnostics();

var types = comp.GetTypesByMetadataName("N.C`1");
Assert.Empty(types);
}

[Theory]
[CombinatorialData]
public void GetTypesByMetadataName_SingleInSourceNotInReferences(
bool useMetadataReference,
[CombinatorialValues("public", "internal")] string accessibility)
{
var referenceComp = CreateCompilation("");

var comp = CreateCompilation(
$@"namespace N;
{accessibility} class C<T> {{}}", new[] { useMetadataReference ? referenceComp.ToMetadataReference() : referenceComp.EmitToImageReference() });

comp.VerifyDiagnostics();

var types = comp.GetTypesByMetadataName("N.C`1");

Assert.Single(types);
AssertEx.Equal("N.C<T>", types[0].ToTestDisplayString());
}

[Theory]
[CombinatorialData]
public void GetTypesByMetadataName_MultipleInSourceNotInReferences(
bool useMetadataReference,
[CombinatorialValues("public", "internal")] string accessibility)
{
var referenceComp = CreateCompilation("");

var comp = CreateCompilation(
$@"namespace N;
{accessibility} class C<T> {{}}
{accessibility} class C<T> {{}}", new[] { useMetadataReference ? referenceComp.ToMetadataReference() : referenceComp.EmitToImageReference() });

comp.VerifyDiagnostics(
// (3,16): error CS0101: The namespace 'N' already contains a definition for 'C'
// internal class C<T> {}
Diagnostic(ErrorCode.ERR_DuplicateNameInNS, "C").WithArguments("C", "N").WithLocation(3, 8 + accessibility.Length)
);

var types = comp.GetTypesByMetadataName("N.C`1");

Assert.Single(types);
AssertEx.Equal("N.C<T>", types[0].ToTestDisplayString());
Assert.Equal(2, types[0].Locations.Length);
}

[Theory]
[CombinatorialData]
public void GetTypesByMetadataName_SingleInSourceSingleInReferences(
bool useMetadataReference,
[CombinatorialValues("public", "internal")] string accessibility)
{
string source = $@"namespace N;
{accessibility} class C<T> {{}}";

var referenceComp = CreateCompilation(source);

referenceComp.VerifyDiagnostics();

MetadataReference reference = useMetadataReference ? referenceComp.ToMetadataReference() : referenceComp.EmitToImageReference();
var comp = CreateCompilation(source, new[] { reference });
comp.VerifyDiagnostics();

var types = comp.GetTypesByMetadataName("N.C`1");

Assert.Equal(2, types.Length);
AssertEx.Equal("N.C<T>", types[0].ToTestDisplayString());
Assert.Same(comp.Assembly.GetPublicSymbol(), types[0].ContainingAssembly);
AssertEx.Equal("N.C<T>", types[1].ToTestDisplayString());

var assembly1 = comp.GetAssemblyOrModuleSymbol(reference).GetPublicSymbol();
Assert.Same(types[1].ContainingAssembly, assembly1);
}

[Theory]
[CombinatorialData]
public void GetTypesByMetadataName_NotInSourceSingleInReferences(
bool useMetadataReference,
[CombinatorialValues("public", "internal")] string accessibility)
{
string source = @$"namespace N;
{accessibility} class C<T> {{}}";

var referenceComp = CreateCompilation(source);

referenceComp.VerifyDiagnostics();

MetadataReference reference = useMetadataReference ? referenceComp.ToMetadataReference() : referenceComp.EmitToImageReference();
var comp = CreateCompilation("", new[] { reference });
comp.VerifyDiagnostics();

var types = comp.GetTypesByMetadataName("N.C`1");


Assert.Single(types);
AssertEx.Equal("N.C<T>", types[0].ToTestDisplayString());

var assembly1 = comp.GetAssemblyOrModuleSymbol(reference).GetPublicSymbol();
Assert.Same(types[0].ContainingAssembly, assembly1);
}

[Theory]
[CombinatorialData]
public void GetTypesByMetadataName_NotInSourceMultipleInReferences(
bool useMetadataReference,
[CombinatorialValues("public", "internal")] string accessibility)
{
string source = @$"namespace N;
{accessibility} class C<T> {{}}";

var referenceComp1 = CreateCompilation(source);
referenceComp1.VerifyDiagnostics();

var referenceComp2 = CreateCompilation(source);
referenceComp2.VerifyDiagnostics();

MetadataReference reference1 = getReference(referenceComp1);
MetadataReference reference2 = getReference(referenceComp2);
var comp = CreateCompilation("", new[] { reference1, reference2 });
comp.VerifyDiagnostics();

var types = comp.GetTypesByMetadataName("N.C`1");

Assert.Equal(2, types.Length);
AssertEx.Equal("N.C<T>", types[0].ToTestDisplayString());
AssertEx.Equal("N.C<T>", types[1].ToTestDisplayString());

var assembly1 = comp.GetAssemblyOrModuleSymbol(reference1).GetPublicSymbol();
Assert.Same(types[0].ContainingAssembly, assembly1);

var assembly2 = comp.GetAssemblyOrModuleSymbol(reference2).GetPublicSymbol();
Assert.Same(types[1].ContainingAssembly, assembly2);

MetadataReference getReference(CSharpCompilation referenceComp1)
{
return useMetadataReference ? referenceComp1.ToMetadataReference() : referenceComp1.EmitToImageReference();
}
}

[Theory]
[CombinatorialData]
public void GetTypesByMetadataName_SingleInSourceMultipleInReferences(
bool useMetadataReference,
[CombinatorialValues("public", "internal")] string accessibility)
{
string source = @$"namespace N;
{accessibility} class C<T> {{}}";

var referenceComp1 = CreateCompilation(source);
referenceComp1.VerifyDiagnostics();

var referenceComp2 = CreateCompilation(source);
referenceComp2.VerifyDiagnostics();

MetadataReference reference1 = getReference(referenceComp1);
MetadataReference reference2 = getReference(referenceComp2);
var comp = CreateCompilation(source, new[] { reference1, reference2 });
comp.VerifyDiagnostics();

var types = comp.GetTypesByMetadataName("N.C`1");

Assert.Equal(3, types.Length);
AssertEx.Equal("N.C<T>", types[0].ToTestDisplayString());
Assert.Same(comp.Assembly.GetPublicSymbol(), types[0].ContainingAssembly);
AssertEx.Equal("N.C<T>", types[1].ToTestDisplayString());
AssertEx.Equal("N.C<T>", types[2].ToTestDisplayString());

var assembly1 = comp.GetAssemblyOrModuleSymbol(reference1).GetPublicSymbol();
Assert.Same(types[1].ContainingAssembly, assembly1);

var assembly2 = comp.GetAssemblyOrModuleSymbol(reference2).GetPublicSymbol();
Assert.Same(types[2].ContainingAssembly, assembly2);

MetadataReference getReference(CSharpCompilation referenceComp1)
{
return useMetadataReference ? referenceComp1.ToMetadataReference() : referenceComp1.EmitToImageReference();
}
}

[Fact]
public void GetTypesByMetadataName_Ordering()
{
var corlibSource = @"
namespace System
{
public class Object {}
public class Void {}
}

public class C {}
";

var corlib = CreateEmptyCompilation(corlibSource);
var corlibReference = corlib.EmitToImageReference();

var other = CreateEmptyCompilation(@"public class C {}", new[] { corlibReference });
var otherReference = other.EmitToImageReference();

var current = CreateEmptyCompilation(@"public class C {}", new[] { otherReference, corlibReference });
current.VerifyDiagnostics();

var types = current.GetTypesByMetadataName("C");

AssertEx.Equal(types.Select(t => t.ToTestDisplayString()), new[] { "C", "C", "C" });
Assert.Same(types[0].ContainingAssembly, current.Assembly.GetPublicSymbol());

var corlibAssembly = current.GetAssemblyOrModuleSymbol(corlibReference).GetPublicSymbol();
Assert.Same(types[1].ContainingAssembly, corlibAssembly);

var otherAssembly = current.GetAssemblyOrModuleSymbol(otherReference).GetPublicSymbol();
Assert.Same(types[2].ContainingAssembly, otherAssembly);
}

[Fact]
public void GetTypeByMetadataName_CorLibViaExtern()
{
var corlibSource = @"
namespace System
{
public class Object {}
public class Void {}
}

public class C {}
";

var corlib = CreateEmptyCompilation(corlibSource);
var corlibReference = corlib.EmitToImageReference(aliases: ImmutableArray.Create("corlib"));

var current = CreateEmptyCompilation(@"", new[] { corlibReference });
current.VerifyDiagnostics();

var type = ((Compilation)current).GetTypeByMetadataName("C");
Assert.NotNull(type);

var corlibAssembly = current.GetAssemblyOrModuleSymbol(corlibReference).GetPublicSymbol();
Assert.Same(type.ContainingAssembly, corlibAssembly);
}

[Fact]
public void GetTypeByMetadataName_OtherViaExtern()
{
var corlibSource = @"
namespace System
{
public class Object {}
public class Void {}
}
";

var corlib = CreateEmptyCompilation(corlibSource);
var corlibReference = corlib.EmitToImageReference();

var other = CreateEmptyCompilation(@"public class C {}", new[] { corlibReference });
var otherReference = other.EmitToImageReference(aliases: ImmutableArray.Create("other"));

var current = CreateEmptyCompilation(@"", new[] { otherReference, corlibReference });
current.VerifyDiagnostics();

var type = ((Compilation)current).GetTypeByMetadataName("C");
Assert.Null(type);
}

#endregion
333fred marked this conversation as resolved.
Show resolved Hide resolved
}
}
Loading