Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Localized file check-in by OneLocBuild Task: Build definition ID 327: Build ID 1566533 #58926

Merged

Conversation

dotnet-bot
Copy link
Collaborator

This is the pull request automatically created by the OneLocBuild task in the build process to check-in localized files generated based upon translation source files (.lcl files) handed-back from the downstream localization pipeline. If there are issues in translations, visit https://aka.ms/ceLocBug and log bugs for fixes. The OneLocBuild wiki is https://aka.ms/onelocbuild and the localization process in general is documented at https://aka.ms/AllAboutLoc.

@dotnet-bot dotnet-bot requested a review from a team as a code owner January 18, 2022 20:49
Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Auto-approval

@JoeRobich JoeRobich mentioned this pull request Jan 18, 2022
Copy link
Member

@JoeRobich JoeRobich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reverting LOC change in #58930

@dotnet-bot dotnet-bot changed the title Localized file check-in by OneLocBuild Task: Build definition ID 327: Build ID 1559172 Localized file check-in by OneLocBuild Task: Build definition ID 327: Build ID 1559547 Jan 18, 2022
@dotnet-bot dotnet-bot changed the title Localized file check-in by OneLocBuild Task: Build definition ID 327: Build ID 1559547 Localized file check-in by OneLocBuild Task: Build definition ID 327: Build ID 1562141 Jan 20, 2022
@dotnet-bot dotnet-bot changed the title Localized file check-in by OneLocBuild Task: Build definition ID 327: Build ID 1562141 Localized file check-in by OneLocBuild Task: Build definition ID 327: Build ID 1562269 Jan 20, 2022
@dotnet-bot dotnet-bot changed the title Localized file check-in by OneLocBuild Task: Build definition ID 327: Build ID 1562269 Localized file check-in by OneLocBuild Task: Build definition ID 327: Build ID 1563412 Jan 20, 2022
@dotnet-bot dotnet-bot changed the title Localized file check-in by OneLocBuild Task: Build definition ID 327: Build ID 1563412 Localized file check-in by OneLocBuild Task: Build definition ID 327: Build ID 1566284 Jan 22, 2022
@dotnet-bot dotnet-bot changed the title Localized file check-in by OneLocBuild Task: Build definition ID 327: Build ID 1566284 Localized file check-in by OneLocBuild Task: Build definition ID 327: Build ID 1566397 Jan 22, 2022
@dotnet-bot dotnet-bot changed the title Localized file check-in by OneLocBuild Task: Build definition ID 327: Build ID 1566397 Localized file check-in by OneLocBuild Task: Build definition ID 327: Build ID 1566533 Jan 22, 2022
@Cosifne
Copy link
Member

Cosifne commented Jan 24, 2022

@JoeRobich should we close this and let the LOC bot create another LOC PR so that we can make it to P5?

@JoeRobich
Copy link
Member

@JoeRobich should we close this and let the LOC bot create another LOC PR so that we can make it to P5?

Looks like after the revert went in this PR was updated with the appropriate changes. Is good to merge.

@Cosifne Cosifne merged commit 592501c into release/dev17.1-vs-deps Jan 25, 2022
@JoeRobich JoeRobich deleted the locfiles/44e8e150-55eb-4565-a013-05261c605796 branch May 9, 2022 21:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants