Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert 58892 #58930

Merged
merged 1 commit into from
Jan 19, 2022
Merged

Revert 58892 #58930

merged 1 commit into from
Jan 19, 2022

Conversation

ryzngard
Copy link
Contributor

We'll just take this in 17.2

@ryzngard ryzngard requested a review from a team as a code owner January 18, 2022 22:05
@ryzngard ryzngard enabled auto-merge (squash) January 18, 2022 22:05
@JoeRobich
Copy link
Member

And we were already getting LOC back for it #58926.

@ryzngard
Copy link
Contributor Author

And we were already getting LOC back for it #58926.

Does this apply to 17.2 as well?

@JoeRobich
Copy link
Member

Does this apply to 17.2 as well?

It will get LOC'd when we make 17.2 the LOC branch.

@ryzngard ryzngard merged commit cca621e into dotnet:release/dev17.1 Jan 19, 2022
333fred added a commit that referenced this pull request Jan 24, 2022
@333fred
Merge remote-tracking branch 'upstream/release/dev17.1-vs-deps' into …
6d1d331 
…merges/release/dev17.1-vs-deps-to-main

* upstream/release/dev17.1-vs-deps:
  Cleanup missed suggestion
  Update src/Workspaces/Core/Portable/Classification/ClassifierHelper.cs
  SpillSequenceSpiller.Spill - ensure sequences under ref assignments are spilled. (#58657) (#58788)
  Correctly update the list of generators for a call to WithAnalyzerReferences
  Rename parameter for what it's actually doing
  Handle AdditiveSpans in either order
  Reduce Stack Trace Explorer automatic open behavior scope (#58819)
  Revert 58892 (#58930)
  Mark APIs as shipped (#58776)
  Revert "Merge pull request #57132 from CyrusNajmabadi/branchId3"
  Fix race in WorkCoordinator when handling document reanalysis
  Remove unnecessary lock access setting UIContexts in the workspace
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Cosifne Cosifne Cosifne approved these changes

Assignees
No one assigned
Labels
Area-IDE
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ryzngard @JoeRobich @Cosifne