Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mark APIs as shipped #58776

Merged
merged 4 commits into from
Jan 18, 2022
Merged

Mark APIs as shipped #58776

merged 4 commits into from
Jan 18, 2022

Conversation

333fred
Copy link
Member

@333fred 333fred commented Jan 11, 2022

Ran the mark APIs shipped script. Infra-only change.

Ran the mark APIs shipped script. Infra-only change.
@333fred
Copy link
Member Author

333fred commented Jan 11, 2022

@dotnet/roslyn-infrastructure for review. @Cosifne FYI, this is likely to cause some merge conflicts as it gets flowed through to main.

@RikkiGibson
Copy link
Contributor

Looks like we have Correctness failures related to public API analyzer.

@333fred
Copy link
Member Author

333fred commented Jan 12, 2022

@RikkiGibson please take another look.

Copy link
Member

@jcouv jcouv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM Thanks (iteration 3)

@333fred 333fred enabled auto-merge (squash) January 18, 2022 19:25
@333fred 333fred merged commit 9781fc8 into dotnet:release/dev17.1 Jan 18, 2022
@333fred 333fred deleted the mark-shipped branch January 18, 2022 21:27
333fred added a commit that referenced this pull request Jan 24, 2022
…merges/release/dev17.1-vs-deps-to-main

* upstream/release/dev17.1-vs-deps:
  Cleanup missed suggestion
  Update src/Workspaces/Core/Portable/Classification/ClassifierHelper.cs
  SpillSequenceSpiller.Spill - ensure sequences under ref assignments are spilled. (#58657) (#58788)
  Correctly update the list of generators for a call to WithAnalyzerReferences
  Rename parameter for what it's actually doing
  Handle AdditiveSpans in either order
  Reduce Stack Trace Explorer automatic open behavior scope (#58819)
  Revert 58892 (#58930)
  Mark APIs as shipped (#58776)
  Revert "Merge pull request #57132 from CyrusNajmabadi/branchId3"
  Fix race in WorkCoordinator when handling document reanalysis
  Remove unnecessary lock access setting UIContexts in the workspace
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants