Correctly update the list of generators for a call to WithAnalyzerReferences #58990
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is ran before we add the document, the generator had already been added.
…erences When we add or remove generator references, we take the previous GeneratorDriver and incrementally update it, adding or removing the new generators. If you called WithAnalyzerReferences, however, we completely failed to do this, so you'd be running with the incorrect list of generators.
jasonmalinowski
force-pushed
the
update-generators-during-withanalyzerreferences
branch
from
d6e34d4
to
f1bc37e
Compare
davidwengier
approved these changes
Jan 21, 2022
|
Does this fix #58916? |
jmarolf
approved these changes
Jan 21, 2022
CyrusNajmabadi
approved these changes
Jan 22, 2022
This was referenced Jan 22, 2022
jasonmalinowski
deleted the
update-generators-during-withanalyzerreferences
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When we add or remove generator references, we take the previous GeneratorDriver and incrementally update it, adding or removing the new generators. If you called WithAnalyzerReferences, however, we completely failed to do this, so you'd be running with the incorrect list of generators.
Fixes AB#1459138
Fixes AB#1427738
Probably also fixes a bunch of other stuff too! Exact list TBD, but now that we know what we're looking for I'll update tomorrow.