Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Correctly update the list of generators for a call to WithAnalyzerReferences #58990

Merged
merged 2 commits into from
Jan 22, 2022
Merged

Correctly update the list of generators for a call to WithAnalyzerReferences #58990

merged 2 commits into from
Jan 22, 2022

Commits on Jan 21, 2022

  1. Rename parameter for what it's actually doing 

    This is ran before we add the document, the generator had already been
added.
    @jasonmalinowski
    jasonmalinowski committed Jan 21, 2022
    Configuration menu
    Copy the full SHA
    d103db5 View commit details
    Browse the repository at this point in the history

  2. Correctly update the list of generators for a call to WithAnalyzerRef… 

    …erences

When we add or remove generator references, we take the previous
GeneratorDriver and incrementally update it, adding or removing the
new generators. If you called WithAnalyzerReferences, however, we
completely failed to do this, so you'd be running with the incorrect
list of generators.
    @jasonmalinowski
    jasonmalinowski committed Jan 21, 2022
    Configuration menu
    Copy the full SHA
    f1bc37e View commit details
    Browse the repository at this point in the history