Do not use SyntaxWalker to visit an arbitrary syntax tree in order to avoid a stack overflow. #59203
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… avoid a stack overflow. Fixes 59190.
cston
reviewed
Feb 1, 2022
| public static readonly string F = ""a"" | ||
| "; | ||
|
|
||
| for (int i = 0; i < 3500 + 3500; i++) |
There was a problem hiding this comment.
Suggested change
| for (int i = 0; i < 3500 + 3500; i++) | |
| for (int i = 0; i < 7000; i++) |
cston
approved these changes
Feb 1, 2022
RikkiGibson
approved these changes
Feb 1, 2022
|
@AlekseyTs probably need to skip the new test in the IOperation leg. |
|
@chsienki Please review. |
This was referenced Feb 2, 2022
333fred
approved these changes
Feb 2, 2022
ghost
added this to the 
sharwell
reviewed
Feb 2, 2022
|
|
||
| var generator = new PipelineCallbackGenerator(ctx => | ||
| { | ||
| ctx.RegisterSourceOutput(ctx.SyntaxProvider.CreateSyntaxProvider((node, ct) => node is ClassDeclarationSyntax c, (context, ct) => context.Node).WithTrackingName("Syntax"), (context, ct) => { }); |
There was a problem hiding this comment.
💡 It may help to also have a test that registers for LiteralExpressionSyntax
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #59190.