-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add FindUsagesOptions and thread option getter through FAR services #59306
Conversation
src/EditorFeatures/Core/FindUsages/AbstractFindUsagesService.ProgressAdapter.cs
Show resolved
Hide resolved
not sure how i feel about thsi change. it doesn't feel intuitive to me (yet) that options are part of a context object (which is intended to push results into as the find progresses). |
We need to be able to call back to the in-proc impl to fetch the options lazily because we do not know upfront what languages are we gonna find the references in and we do not want to pre-fetch the options for all languages. Context is created at the entry point of the feature on the client and thus has access to the client options. |
I want to be on the same page here. What option does findrefs need? I'm surprised you hear that it would depend on anything lang specific. |
Classification options. The |
Interesting: |
Bleagh... there are times when i wish things were not lang-specific options. |
Depends on https://devdiv.visualstudio.com/DevDiv/DevDiv%20Team/_git/TypeScript-VS/pullrequest/376624
Follow up: #59168