Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make solution options global #59168

Merged
merged 11 commits into from
Feb 14, 2022
Merged

Make solution options global #59168

merged 11 commits into from
Feb 14, 2022

Conversation

tmat
Copy link
Member

@tmat tmat commented Jan 30, 2022

Reads the following options from global options instead of solution snapshot:

  • QuickInfoOptions
  • InlineHintsOptions
  • ClassificationOptions
  • SymbolDescriptionOptions

Contributes to #58717.

TODO:

@tmat tmat force-pushed the MakeSolutionOptionsGlobal branch from c58fa1e to 0387a9f Compare February 4, 2022 00:44
@tmat tmat force-pushed the MakeSolutionOptionsGlobal branch 2 times, most recently from 4213f88 to 7d26ec9 Compare February 9, 2022 18:34
@tmat tmat changed the title WIP: Make solution options global Make solution options global Feb 9, 2022
@tmat tmat force-pushed the MakeSolutionOptionsGlobal branch 2 times, most recently from e749414 to d963f6b Compare February 9, 2022 20:38
@tmat tmat force-pushed the MakeSolutionOptionsGlobal branch from 788c5ac to e7f950f Compare February 13, 2022 17:39
@tmat tmat enabled auto-merge (squash) February 13, 2022 17:45
@tmat tmat merged commit f52633c into dotnet:main Feb 14, 2022
@ghost ghost added this to the Next milestone Feb 14, 2022
@tmat tmat deleted the MakeSolutionOptionsGlobal branch February 14, 2022 06:14
RikkiGibson added a commit that referenced this pull request Feb 14, 2022
RikkiGibson added a commit that referenced this pull request Feb 15, 2022
333fred added a commit that referenced this pull request Feb 15, 2022
…ures/required-members

* upstream/main: (1291 commits)
  Revert "Make solution options global (#59168)" (#59537)
  Update src/VisualStudio/CSharp/Test/F1Help/F1HelpTests.cs
  Update src/VisualStudio/CSharp/Impl/LanguageService/CSharpHelpContextService.cs
  Update Language Feature Status.md (#59546)
  Catch more exceptions (#59526)
  Fix Peek Definition for Razor files (#59528)
  Update OneOffInsertion.ps1 path in 17.0 branch (#59541)
  Use GetBestTypeByMetadataName in 'use System.HashCode' fixer
  Pass exception into internal error diagnostic (#59443)
  Provide f1 help for discards
  Update src/VisualStudio/Core/Def/SymbolSearch/AbstractDelayStartedService.cs
  Fix formatting
  move line
  Simplify
  Simplify
  Fixup
  Explicitly perform some mef loads in teh background
  Bump Microsoft.DiaSymReader version for release
  Remove IBoundSwitchStatement (#59516)
  Make solution options global (#59168)
  ...
tmat added a commit that referenced this pull request Feb 15, 2022
tmat added a commit that referenced this pull request Feb 15, 2022
@RikkiGibson RikkiGibson modified the milestones: Next, 17.2.P2 Mar 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants