Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "Revert "Make solution options global"" #59567

Merged
merged 1 commit into from
Feb 15, 2022
Merged

Revert "Revert "Make solution options global"" #59567

merged 1 commit into from
Feb 15, 2022

Conversation

tmat
Copy link
Member

@tmat tmat commented Feb 15, 2022

Reverts #59537

@tmat tmat requested review from a team as code owners February 15, 2022 21:31
@RikkiGibson RikkiGibson self-requested a review February 15, 2022 21:32
@RikkiGibson RikkiGibson self-assigned this Feb 15, 2022
RikkiGibson
RikkiGibson approved these changes Feb 15, 2022
View reviewed changes
Copy link
Contributor

@RikkiGibson RikkiGibson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we want to take this as soon as it's ready--no need for a separate validation run this time. It appears that Razor is broken until we get this into VS main.

@tmat
Copy link
Member Author

tmat commented Feb 15, 2022

razor is broken? :-o

@tmat tmat merged commit 0098764 into main Feb 15, 2022
@ghost ghost added this to the Next milestone Feb 15, 2022
@tmat tmat deleted the revert-59537-revert-59168-MakeSolutionOptionsGlobal branch February 15, 2022 23:06
@RikkiGibson RikkiGibson modified the milestones: Next, 17.2.P2 Mar 1, 2022
333fred added a commit to 333fred/roslyn that referenced this pull request Mar 4, 2022
@333fred
Add back OmniSharpInlineHints
cf97011 
This was removed in dotnet#59567, just before the vscode API went stable and O# could finally take advantage of it. This adds the EA back.

I also added Joey and I to the codeowners file so we can be aware of any future changes.
@333fred 333fred mentioned this pull request Mar 4, 2022
Merged
333fred added a commit to 333fred/roslyn that referenced this pull request Mar 4, 2022
@333fred
Add back OmniSharpInlineHints
bc9c7a6 
This was removed in dotnet#59567, just before the vscode API went stable and O# could finally take advantage of it. This adds the EA back.

I also added Joey and I to the codeowners file so we can be aware of any future changes.
333fred added a commit that referenced this pull request Mar 4, 2022
@333fred @JoeRobich
Add back OmniSharpInlineHints (#59941)
5f538b5 
This was removed in #59567, just before the vscode API went stable and O# could finally take advantage of it. This adds the EA back.

I also added Joey and I to the codeowners file so we can be aware of any future changes.

Co-authored-by: Joey Robichaud <joseph.robichaud@microsoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RikkiGibson RikkiGibson RikkiGibson approved these changes

Assignees

@RikkiGibson RikkiGibson

Labels
Area-IDE
Projects
None yet
Milestone
17.2.P2
Development

Successfully merging this pull request may close these issues.
2 participants
@tmat @RikkiGibson