Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Catch more exceptions #59526

Merged
merged 1 commit into from
Feb 14, 2022
Merged

Catch more exceptions #59526

merged 1 commit into from
Feb 14, 2022

Conversation

davidwengier
Copy link
Member

Trust Tomas to find the one spot I forgot to use IOUtilities

>System.UnauthorizedAccessException: Access to the path 'C:\Users\tomat\AppData\Local\Temp\MetadataAsSource\299ccf8761144445b4e0c0e582509103\PdbSourceDocumentMetadataAsSourceFileProvider\d12bdc6b-e248-49bc-a21d-d774c9351c8a\CodeFixTest`1.cs' is denied.\r
   at System.IO.__Error.WinIOError(Int32 errorCode, String maybeFullPath)\r
   at System.IO.FileStream.Init(String path, FileMode mode, FileAccess access, Int32 rights, Boolean useRights, FileShare share, Int32 bufferSize, FileOptions options, SECURITY_ATTRIBUTES secAttrs, String msgPath, Boolean bFromProxy, Boolean useLongPath, Boolean checkHost)\r
   at System.IO.FileStream..ctor(String path, FileMode mode, FileAccess access, FileShare share)\r
   at Microsoft.CodeAnalysis.PdbSourceDocument.PdbSourceDocumentLoaderService.TryGetEmbeddedSourceFile(String tempFilePath, SourceDocument sourceDocument, Encoding encoding, TelemetryMessage telemetry)\r
   at Microsoft.CodeAnalysis.PdbSourceDocument.PdbSourceDocumentLoaderService.<LoadSourceDocumentAsync>d__4.MoveNext()\r

@davidwengier davidwengier requested a review from a team as a code owner February 13, 2022 20:54
@davidwengier
Copy link
Member Author

@tmat PTAL

@davidwengier davidwengier merged commit bd15f43 into dotnet:main Feb 14, 2022
@davidwengier davidwengier deleted the GottaCatchThemAll branch February 14, 2022 22:12
@ghost ghost added this to the Next milestone Feb 14, 2022
333fred added a commit that referenced this pull request Feb 15, 2022
@333fred
Merge remote-tracking branch 'upstream/main' into merges/main-to-feat…
a487604 
…ures/required-members

* upstream/main: (1291 commits)
  Revert "Make solution options global (#59168)" (#59537)
  Update src/VisualStudio/CSharp/Test/F1Help/F1HelpTests.cs
  Update src/VisualStudio/CSharp/Impl/LanguageService/CSharpHelpContextService.cs
  Update Language Feature Status.md (#59546)
  Catch more exceptions (#59526)
  Fix Peek Definition for Razor files (#59528)
  Update OneOffInsertion.ps1 path in 17.0 branch (#59541)
  Use GetBestTypeByMetadataName in 'use System.HashCode' fixer
  Pass exception into internal error diagnostic (#59443)
  Provide f1 help for discards
  Update src/VisualStudio/Core/Def/SymbolSearch/AbstractDelayStartedService.cs
  Fix formatting
  move line
  Simplify
  Simplify
  Fixup
  Explicitly perform some mef loads in teh background
  Bump Microsoft.DiaSymReader version for release
  Remove IBoundSwitchStatement (#59516)
  Make solution options global (#59168)
  ...
@RikkiGibson RikkiGibson modified the milestones: Next, 17.2.P2 Mar 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tmat tmat tmat approved these changes

Assignees
No one assigned
Labels
Area-IDE
Projects
None yet
Milestone
17.2.P2
Development

Successfully merging this pull request may close these issues.
3 participants
@davidwengier @tmat @RikkiGibson