Support extended property patterns in 'use recursive' refactoring #59490
+50
−26
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
Community
...ortable/CodeRefactorings/UseRecursivePatterns/UseRecursivePatternsCodeRefactoringProvider.cs
Show resolved
Hide resolved
| subpattern = Subpattern(names[i], RecursivePattern(subpattern)); | ||
| return subpattern; | ||
|
|
||
| if (names.Length > 1 && ((CSharpParseOptions)names[0].SyntaxTree.Options).LanguageVersion >= LanguageVersion.CSharp10) |
Member
There was a problem hiding this comment.
kinda ugly. i wish thtere was a clean way for you to get this info.
| subpattern = Subpattern(names[i], RecursivePattern(subpattern)); | ||
| return subpattern; | ||
|
|
||
| if (names.Length > 1 && ((CSharpParseOptions)names[0].SyntaxTree.Options).LanguageVersion >= LanguageVersion.CSharp10) |
Member
There was a problem hiding this comment.
Suggested change
| if (names.Length > 1 && ((CSharpParseOptions)names[0].SyntaxTree.Options).LanguageVersion >= LanguageVersion.CSharp10) | |
| if (names.Length > 1 && names[0].SyntaxTree.Options.LanguageVersion() >= LanguageVersion.CSharp10) |
CyrusNajmabadi
approved these changes
Feb 11, 2022
auto-merge was automatically disabled
February 11, 2022 13:33
Head branch was pushed to by a user without write access
jinujoseph
added
the
Community
CyrusNajmabadi
approved these changes
Feb 14, 2022
Member
|
thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
.. and minor cleanup.