Adjust timeout on helix runs to 15 minutes to ensure dumps are captur… #61001
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ed within the 30minute timeout of a helix run
JoeRobich
approved these changes
Apr 27, 2022
jaredpar
approved these changes
Apr 27, 2022
jasonmalinowski
approved these changes
Apr 27, 2022
Comment on lines
+90
to
91
| // The 25 minute timeout in integration tests accounts for the fact that VSIX deployment and/or experimental hive reset and | ||
| // configuration can take significant time (seems to vary from ~10 seconds to ~15 minutes), and the blame |
There was a problem hiding this comment.
When we originally made this change we later discovered we were having other issues that was causing VSIX deployment to hang -- it'd be interesting to actually see if we actually can move it back to 15 minutes for everything.
ghost
added this to the 
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ed within the 30minute timeout of a helix run
See - #57549 (comment)
Was changed in #59783 to fix integration tests, but we should keep the old timeout for helix jobs.