Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement Required Members for VB #66084

Merged
merged 22 commits into from
May 10, 2023
Merged

Implement Required Members for VB #66084

Show file tree
Hide file tree
Changes from 19 commits
Commits
Show all changes
22 commits
Select commit Hold shift + click to select a range
6615a4e
Add and implement IPropertySymbol.IsRequired and IFieldSymbol.IsRequi…
333fred Dec 19, 2022
2c254bc
Add and implement NamedTypeSymbol.AllRequiredMembers.
333fred Dec 19, 2022
de998f8
Implement MethodSymbol.HasSetsRequiredMembers
333fred Dec 20, 2022
9b6b8af
Implement checking required members in constructors, sketch out test …
333fred Dec 20, 2022
98167b1
Implement remaining errors:
333fred Dec 21, 2022
7890731
Fill out all tests
333fred Dec 21, 2022
7b744a5
PR feedback
333fred Jan 5, 2023
9ae7f8d
PR feedback#
333fred Jan 20, 2023
30ea028
PR Feedback
333fred Jan 27, 2023
b00b758
Compile errors, missed feedback item.
333fred Jan 27, 2023
7ec94f5
Fix compile errors, add a few more tests.
333fred Jan 27, 2023
624934a
Merge remote-tracking branch 'upstream/main' into vb-required
333fred Feb 6, 2023
73d1d26
Addressed a number of PR feedback comments. Lots of new tests, fixed …
333fred Mar 11, 2023
8c9cff4
PR feedback
333fred Mar 22, 2023
58072b4
Pass correct containing type in local rewriting of tuples.
333fred Mar 23, 2023
610d5f4
Merge remote-tracking branch 'upstream/main' into vb-required
333fred May 2, 2023
e1e3866
Fix test baseline
333fred May 2, 2023
7b2052e
Simplify EnsureRequiredMembersCalcuated.
333fred May 5, 2023
ebb5f25
Add additional test verification.
333fred May 5, 2023
e9e4ba6
Remove unnecessary imports
333fred May 10, 2023
748793f
Tighten retargeting asserts and add a test
333fred May 10, 2023
5575087
Fix C# equivalent code.
333fred May 10, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions docs/compilers/Visual Basic/Compiler Breaking Changes - DotNet 7.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,8 @@
# This document lists known breaking changes in Roslyn after .NET 6 all the way to .NET 7.

## `RequiredMembersAttribute` cannot be manually applied
333fred marked this conversation as resolved.
Show resolved Hide resolved

**Introduced in VS 17.6**

As part of implementing VB support for consuming `required` APIs, it is now an error to manually apply `RequiredMembersAttribute` in
source. VB will now correctly interpret these attributes in metadata and allow instanciating types with required members.
Loading