Remove mocks of setting services for unit tests #69160
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
Area-IDE
untriaged
Rather than mocking a bunch of VS services that are involved in reading services to be no-ops, we can just exclude the option persister to start with. This just ensures they're better isolated no matter what.
jasonmalinowski
force-pushed
the
remove-settings-service-mocks
branch
from
22ed3f4 to
ffb870c
Compare
sharwell
suggested changes
Jul 25, 2023
Member
Author
|
Superseded by #78821. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rather than mocking a bunch of VS services that are involved in reading services to be no-ops, we can just exclude the option persister to start with. This just ensures they're better isolated no matter what.