Check both csc.exe and vbc.exe as filename to exclude #69221
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dotnet-issue-labeler
bot
added
Area-Infrastructure
untriaged
ghost
added
the
Community
| @@ -107,7 +107,6 @@ private bool CheckPackages(TextWriter textWriter) | |||
| PathComparer.Equals(relativeFileName, "Icon.png") || | |||
| PathComparer.Equals(relativeFileName, "Init.cmd") || | |||
| PathComparer.Equals(relativeFileName, "VS.Tools.Roslyn.nuspec") || | |||
| PathComparer.Equals(relativeFileName, "csc.exe") || | |||
There was a problem hiding this comment.
@jaredpar should this actually have been vbc?
There was a problem hiding this comment.
I've updated the PR to exclude vbc.exe also instead of getting csc.exe excluded twice
There was a problem hiding this comment.
I'll wait for @jaredpar to take a look before merging, but otherwise LGTM
There was a problem hiding this comment.
It's definitely a typo: whether the intent was csi or vbc I cannot decide though.
gero3
changed the title
333fred
approved these changes
Jul 27, 2023
| @@ -107,7 +107,6 @@ private bool CheckPackages(TextWriter textWriter) | |||
| PathComparer.Equals(relativeFileName, "Icon.png") || | |||
| PathComparer.Equals(relativeFileName, "Init.cmd") || | |||
| PathComparer.Equals(relativeFileName, "VS.Tools.Roslyn.nuspec") || | |||
| PathComparer.Equals(relativeFileName, "csc.exe") || | |||
There was a problem hiding this comment.
I'll wait for @jaredpar to take a look before merging, but otherwise LGTM
jaredpar
approved these changes
Jul 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I used my identical subexpression analyzer to see if I missed certain exceptions.
This was one diagnostic found that wasn't wrong.
was checked twice.