Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check both csc.exe and vbc.exe as filename to exclude #69221

Merged
merged 2 commits into from
Jul 31, 2023
Merged

Check both csc.exe and vbc.exe as filename to exclude #69221

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c53b806
Check only once if csc.exe as filename
gero3 Jul 25, 2023
1dd278c
Exclude vbc.exe also instead of csc.exe twice
gero3 Jul 26, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/Tools/BuildBoss/CompilerNuGetCheckerUtil.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -107,7 +107,7 @@ private bool CheckPackages(TextWriter textWriter)
PathComparer.Equals(relativeFileName, "Icon.png") ||
PathComparer.Equals(relativeFileName, "Init.cmd") ||
PathComparer.Equals(relativeFileName, "VS.Tools.Roslyn.nuspec") ||
PathComparer.Equals(relativeFileName, "csc.exe") ||
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jaredpar should this actually have been vbc?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure looks like it.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've updated the PR to exclude vbc.exe also instead of getting csc.exe excluded twice

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll wait for @jaredpar to take a look before merging, but otherwise LGTM

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's definitely a typo: whether the intent was csi or vbc I cannot decide though.

PathComparer.Equals(relativeFileName, "vbc.exe") ||
relativeFileName.EndsWith(".resources.dll", PathComparison) ||
relativeFileName.EndsWith(".rels", PathComparison) ||
relativeFileName.EndsWith(".psmdcp", PathComparison),
Expand Down