Merge 'main' into RefStructInterfaces #72416
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…vider.GetSymbolsAsync (dotnet#72157) This method was individually adding items to an ArrayBuilder without it's size configured. Potential issues with the current approach: 1) There could be multiple resizes during the Add calls to get the array to it's final size 2) Very likely the final capacity will exceed the array size, causing an allocation in generating the immutablearray. 3) I was seeing a large number of items in these arrays, causing the array that does get created not to get freed back into the pool. Instead, if we use the SelectAsArray method, we shouldn't have any extra allocations other than the resultant ImmutableArray.
* Fix rethrowing in nested async catch * Test await using and foreach
Razor is doing work to consolidate assemblies, and it's necessary to add a couple more IVTs from the Razor EA assembly. In addition, I'm removing an IVT for an assembly that no longer exists.
…ice` in `OnInitializedAsync()`. - Add EA.Xaml reference to MS.CA.LanguageServer
This reverts commit c3b4361.
…o-main Merge release/dev17.10 to main
…t#72313) Ensure ProjectState modification operations would actually create a modified ProjectState before creating the new ProjectState When opening Roslyn.sln, I see 32800 ProjectState.AddDocument calls, of which 6700 are sending in an empty array to add. Similarly, I see 6700 ProjectState.RemoveAllDocuments calls, of which 4700 are called on ProjectState instances where the DocumentStates/AdditionalDocumentStates/AnalyzerConfigDocumentStates are all empty.
Boxing of the EntryState enum shows up in the RichCopyTest.CopyPlain test numbers as almost 1% of allocations. This code just needs to map EntryState values to a character for packing.
Lexer.LexDirectiveTrailingTrivia was calling into AddTrivia with a null SyntaxListBuilder, causing allocations. Instead, use a new member for use in that context.
UsingToolNetFrameworkReferenceAssemblies got removed from Arcade a while ago as the SDK supports that natively.
dotnet-issue-labeler
bot
added
the
untriaged
cston
approved these changes
Mar 6, 2024
AlekseyTs
merged commit 779fded
into
dotnet:features/RefStructInterfaces
30 checks passed
This was referenced May 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.