Reduce allocations in AbstractSymbolCompletionProvider.CreateItems #74670
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The linq expression shows up as about 0.3% of allocations in the profile I'm looking for in the typing section of the scrolling speedometer test. MultiDictionary has a struct-based value that is great for the case where the valueset typically is only a single object (which is the case for this code).
dotnet-issue-labeler
bot
added
Area-IDE
untriaged
|
test failing because of SymbolAndSelectionInfo's Equals comparison not matching what was previously used in this context. Need to ponder. |
OK, hopefully fixed by adding a separate comparer. |
Open
3 tasks
|
@genlu -- ptal |
CyrusNajmabadi
approved these changes
Aug 8, 2024
| /// <summary> | ||
| /// Alternative comparer to SymbolAndSelectionInfo's default which considers both the full symbol and preselect. | ||
| /// </summary> | ||
| protected sealed class SymbolReferenceEquivalenceComparer : IEqualityComparer<SymbolAndSelectionInfo> |
There was a problem hiding this comment.
Why protected? #Resolved
This was referenced Aug 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The linq expression shows up as about 0.3% of allocations in the profile I'm looking for in the typing section of the scrolling speedometer test.
MultiDictionary has a struct-based value that is great for the case where the valueset typically is only a single object (which is the case for this code).
*** Relevant allocations from the profile I'm looking at ***
