Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reduce allocations in AbstractSymbolCompletionProvider.CreateItems #74670

Merged
merged 3 commits into from
Aug 8, 2024
Merged

Reduce allocations in AbstractSymbolCompletionProvider.CreateItems #74670

merged 3 commits into from
Aug 8, 2024

Commits on Aug 6, 2024

  1. Reduce allocations in AbstractSymbolCompletionProvider.CreateItems 

    The linq expression shows up as about 0.3% of allocations in the profile I'm looking for in the typing section of the scrolling speedometer test.

MultiDictionary has a struct-based value that is great for the case where the valueset typically is only a single object (which is the case for this code).
    @ToddGrun
    ToddGrun committed Aug 6, 2024
    Configuration menu
    Copy the full SHA
    e589085 View commit details
    Browse the repository at this point in the history

Commits on Aug 7, 2024

  1. Add comparer to override SymbolAndSelectionInfo's default comparison

    @ToddGrun
    ToddGrun committed Aug 7, 2024
    Configuration menu
    Copy the full SHA
    6590745 View commit details
    Browse the repository at this point in the history

Commits on Aug 8, 2024

  1. change class visibility

    @ToddGrun
    ToddGrun committed Aug 8, 2024
    Configuration menu
    Copy the full SHA
    2ed2b87 View commit details
    Browse the repository at this point in the history