Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
345 commits
Select commit Hold shift + click to select a range
71f3218
Fix duplicate references for runtime assemblies
genlu Feb 27, 2025
1172ece
Merge remote-tracking branch 'genlu/UpgradeBcl' into UpgradeBcl
genlu Feb 27, 2025
1a641a9
Crossgen a few more framework assemblies
genlu Feb 28, 2025
fab5597
Merge remote-tracking branch 'dotnet/main' into UpgradeBcl
genlu Feb 28, 2025
a879f4a
Fix correctness rebuild by adding an additional Semantic Search refer…
JoeRobich Feb 28, 2025
688b3ea
Merge DualChangeAction into DocumentChangeAction
sharwell Feb 28, 2025
42b8763
Make IDE3000 not configurable
sharwell Feb 28, 2025
998a3d8
Simplify analyzer code and improve robustness
sharwell Feb 28, 2025
0aa9356
Simplifies fixer and applies most remaining feedback
maryamariyan Mar 1, 2025
f5116f2
Merge remote-tracking branch 'maryam/dev/maryamariyan/replicate-for-f…
maryamariyan Mar 1, 2025
1c9ba44
Fix compile related to DocumentChangeAction
maryamariyan Mar 1, 2025
2ed4649
Cleanup messaging
maryamariyan Mar 1, 2025
24f76b2
Add resources for messaging
maryamariyan Mar 1, 2025
744eb42
Adds a few basic tests
maryamariyan Mar 1, 2025
b077c3f
Merge remote-tracking branch 'origin/main' into dev/maryamariyan/repl…
maryamariyan Mar 2, 2025
70209d7
Undo most recent analyzer changes,
maryamariyan Mar 2, 2025
ffd9bce
Apply PR feedback
maryamariyan Mar 2, 2025
e8596bc
Tests renamed
maryamariyan Mar 2, 2025
1923930
Correct test setup
maryamariyan Mar 2, 2025
0cc13f3
Improves readability and removes unreachable code
maryamariyan Mar 3, 2025
fbcd111
Correct mistakes in tests
maryamariyan Mar 3, 2025
41a421f
Adds more unit tests
maryamariyan Mar 3, 2025
9222c16
Fix formatting (https://learn.microsoft.com/dotnet/fundamentals/code-…
maryamariyan Mar 3, 2025
1452aa0
Fixes Analyzer tests
maryamariyan Mar 3, 2025
6fb4938
Makes sure original and replacement text are properly aligned
maryamariyan Mar 3, 2025
1b6daf2
Merge remote-tracking branch 'origin/UpgradeBcl' into UpgradeBcl
genlu Mar 3, 2025
c270a76
Apply partial PR feedback
maryamariyan Mar 3, 2025
061d448
cleanup
maryamariyan Mar 3, 2025
2d56e5f
Add more dependencies to deployment project
genlu Mar 3, 2025
faa4722
Applies feedback to change API surface
maryamariyan Mar 4, 2025
f48bf92
All tests pass
maryamariyan Mar 4, 2025
af8ca36
tests are actually failing
maryamariyan Mar 4, 2025
770fc86
Fix Quota bug and show failing tests
maryamariyan Mar 4, 2025
6d20484
Update tests for error conditions where diagnostics are not corrected
sharwell Mar 4, 2025
2b7487a
undo IsImplementNotImplementedExceptionEnabledAsync change
maryamariyan Mar 5, 2025
8b53fe0
Fixes remaining tests
maryamariyan Mar 5, 2025
dbc3919
cleanup
maryamariyan Mar 5, 2025
3e3bd88
Add back referencedSymbols to API call to help with perf
maryamariyan Mar 5, 2025
16d2481
Gracefully comment when result is unexpected
maryamariyan Mar 5, 2025
3b0ba9a
Remove unused resource
maryamariyan Mar 5, 2025
e5c231f
[automated] Merge branch 'main' => 'main-vs-deps' (#77429)
jjonescz Mar 5, 2025
010573f
[automated] Merge branch 'main' => 'main-vs-deps' (#77430)
jjonescz Mar 5, 2025
b20b2cb
Simplify error messages
maryamariyan Mar 5, 2025
384ce72
Cleanup tests
maryamariyan Mar 5, 2025
470c3de
[automated] Merge branch 'main' => 'main-vs-deps' (#77440)
jjonescz Mar 5, 2025
38e153c
Bump BCL references to 9.0 (#76890)
arunchndr Mar 5, 2025
79bebb1
Add missing entry for IDE3000
maryamariyan Mar 5, 2025
517d977
Add Missing Help Link
maryamariyan Mar 5, 2025
68501c0
[automated] Merge branch 'main' => 'main-vs-deps' (#77446)
dotnet-policy-service[bot] Mar 5, 2025
45c5c6a
Include the contents of System.Composition in Setup.Dependencies
jasonmalinowski Mar 6, 2025
47f9554
Sort the references
jasonmalinowski Mar 6, 2025
8aaa595
mid stage
maryamariyan Mar 6, 2025
9eb2e7c
Removes QuotaExceeds property, received as message
maryamariyan Mar 6, 2025
d088c36
Update signature
maryamariyan Mar 6, 2025
7127ff7
Merge remote-tracking branch 'origin/main' into dev/maryamariyan/repl…
maryamariyan Mar 6, 2025
2f934a6
Fix missed out warning
maryamariyan Mar 6, 2025
4eecdc6
Fix test correctness issue picked up by CI
maryamariyan Mar 6, 2025
44a65e1
Add logging
maryamariyan Mar 6, 2025
960a9cd
Apply PR feedback
maryamariyan Mar 7, 2025
2fdeaa1
Remove workaround of WPF bug
jasonmalinowski Mar 7, 2025
2cf1b5d
[Rename flyout] Fixed cropping issue on small screens
Mar 7, 2025
0e72446
Addressed feedback
Mar 7, 2025
2f8e4d0
Include the contents of System.Composition in Setup.Dependencies (#77…
jasonmalinowski Mar 7, 2025
4622320
[automated] Merge branch 'main' => 'main-vs-deps' (#77467)
dotnet-policy-service[bot] Mar 8, 2025
58c992f
Remove unnecessary imports
CyrusNajmabadi Mar 10, 2025
554a1dd
Remove unnecessary imports (#77481)
CyrusNajmabadi Mar 10, 2025
42dd426
[Rename flyout] Fixed cropping issue on small screens (#77466)
CyrusNajmabadi Mar 10, 2025
d244b6e
[automated] Merge branch 'main' => 'main-vs-deps' (#77486)
dotnet-policy-service[bot] Mar 10, 2025
8458e61
Remove workaround of WPF bug (#77462)
jasonmalinowski Mar 10, 2025
f86f371
Fix run code analysis on solution not reporting results
sharwell Mar 10, 2025
0544987
[automated] Merge branch 'main' => 'main-vs-deps' (#77493)
dotnet-policy-service[bot] Mar 10, 2025
80a6f1d
Update dependencies from https://github.com/dotnet/source-build-refer…
dotnet-maestro[bot] Mar 11, 2025
fea077a
[main] Update dependencies from dotnet/source-build-reference-package…
jjonescz Mar 11, 2025
a3d6b18
Disable integration tests on main-vs-deps
jjonescz Mar 11, 2025
72ff2f9
[automated] Merge branch 'main' => 'main-vs-deps' (#77508)
dotnet-policy-service[bot] Mar 11, 2025
fb0debe
Use HangMitigatingTimeout for cases where operations do not complete …
sharwell Mar 11, 2025
c553123
[automated] Merge branch 'main' => 'main-vs-deps' (#77520)
dotnet-policy-service[bot] Mar 11, 2025
ee16ab3
Mark partial events and ctors as complete (#77525)
jjonescz Mar 11, 2025
e809937
some PR feedback
maryamariyan Mar 11, 2025
03c8917
spacing
maryamariyan Mar 11, 2025
5f9729d
[automated] Merge branch 'main' => 'main-vs-deps' (#77530)
dotnet-policy-service[bot] Mar 11, 2025
cab1e65
Move test
maryamariyan Mar 11, 2025
3af16d7
Apply most remaining feedback
maryamariyan Mar 11, 2025
141c83d
Applies feedback
maryamariyan Mar 11, 2025
6f0dc5e
Add runtime async to official build (#77537)
333fred Mar 11, 2025
8012d9c
Signature now strictly uses MemberDeclarationSyntax
maryamariyan Mar 11, 2025
b9b4dd4
[automated] Merge branch 'main' => 'main-vs-deps' (#77539)
dotnet-policy-service[bot] Mar 11, 2025
6a6e924
Update message for analyzer referencing newer compiler than host (#77…
RikkiGibson Mar 12, 2025
27405d2
Updates tests
maryamariyan Mar 12, 2025
37efb07
field implementation is not supported as method or property
maryamariyan Mar 12, 2025
336b591
Fix NFW due to invoking Workspace.RaiseEventForHandlers in the CA pro…
ToddGrun Mar 12, 2025
0c41f80
Implement field null resilience analysis (#77127)
RikkiGibson Mar 12, 2025
d3f7d51
[automated] Merge branch 'main' => 'main-vs-deps' (#77552)
dotnet-policy-service[bot] Mar 12, 2025
af0bddc
[automated] Merge branch 'main' => 'main-vs-deps' (#77554)
dotnet-policy-service[bot] Mar 12, 2025
6acccaf
Fix incremental generator in deterministic key file (#77553)
jaredpar Mar 12, 2025
4e68dca
Apply PR feedback
maryamariyan Mar 12, 2025
1a2fa42
Disable downloading the runtime packages during restore and instead e…
ToddGrun Mar 12, 2025
e65c6c8
Fix run code analysis on solution not reporting results (#77501)
sharwell Mar 12, 2025
20ed35d
[automated] Merge branch 'main' => 'main-vs-deps' (#77564)
dotnet-policy-service[bot] Mar 12, 2025
276ad7f
Simplifies assumptions - Only trigger fixer when service available
maryamariyan Mar 12, 2025
b59cffa
nit spacing
maryamariyan Mar 12, 2025
9d3c56e
Fix preview window for 'implement NotImplementedException'
CyrusNajmabadi Mar 13, 2025
6dd05a7
Simmplify
CyrusNajmabadi Mar 13, 2025
15d1c1c
Remove uneeded helper
CyrusNajmabadi Mar 13, 2025
5b20ad7
Fix Stack Trace Explorer for additional documents (#77517)
Mar 13, 2025
196b818
[automated] Merge branch 'main' => 'main-vs-deps' (#77575)
dotnet-policy-service[bot] Mar 13, 2025
2c39ea7
Adds :bulb: `Implement Using Copilot` for `NotImplementedException` (…
CyrusNajmabadi Mar 13, 2025
557fa80
Merge branch 'main' into implementPreview
CyrusNajmabadi Mar 13, 2025
e7c08f6
[automated] Merge branch 'main' => 'main-vs-deps' (#77585)
dotnet-policy-service[bot] Mar 13, 2025
adc21be
Update dependencies from https://github.com/dotnet/arcade build 20250…
dotnet-maestro[bot] Mar 13, 2025
9ad37db
Update PublishData.json (#77589)
jjonescz Mar 13, 2025
d0ecb50
Fix preview window for 'implement NotImplementedException' (#77579)
CyrusNajmabadi Mar 13, 2025
1e80300
[automated] Merge branch 'main' => 'main-vs-deps' (#77591)
dotnet-policy-service[bot] Mar 13, 2025
07d5af7
Update main-merge.yml to not run on forks
arunchndr Mar 13, 2025
debe306
Fix typo (#77595)
kauwai Mar 13, 2025
bc377e0
Update main-merge.yml to not run on forks (#77594)
arunchndr Mar 13, 2025
35e2429
[automated] Merge branch 'main' => 'main-vs-deps' (#77599)
dotnet-policy-service[bot] Mar 14, 2025
c02ed62
Update dependencies from https://github.com/dotnet/source-build-refer…
dotnet-maestro[bot] Mar 14, 2025
3ed7fbf
Filter down the list of files we need to examing when looking for a :…
CyrusNajmabadi Mar 14, 2025
a0ff8bd
Move feature-oriented helpers to appropriate location
CyrusNajmabadi Mar 14, 2025
9a120ba
Filter down the list of files we need to examing when looking for a `…
CyrusNajmabadi Mar 14, 2025
23d9d23
[automated] Merge branch 'main' => 'main-vs-deps' (#77613)
dotnet-policy-service[bot] Mar 14, 2025
3e2d972
Move feature-oriented helpers to appropriate location (#77611)
CyrusNajmabadi Mar 14, 2025
be7fcea
Ensure we don't touch Solution.Workspace if we don't have to
jasonmalinowski Mar 13, 2025
20dfaa2
[automated] Merge branch 'main' => 'main-vs-deps' (#77616)
dotnet-policy-service[bot] Mar 15, 2025
64137a0
Ensure we don't touch Solution.Workspace if we don't have to (#77581)
jasonmalinowski Mar 15, 2025
517e95f
[automated] Merge branch 'main' => 'main-vs-deps' (#77622)
dotnet-policy-service[bot] Mar 15, 2025
2e44cf2
Update dependencies from https://github.com/dotnet/source-build-refer…
dotnet-maestro[bot] Mar 17, 2025
878db64
Update dependencies from https://github.com/dotnet/arcade build 20250…
dotnet-maestro[bot] Mar 17, 2025
3e4345f
Correct how we pick up options for `ICopilotOptionsService` (#77620)
maryamariyan Mar 17, 2025
4fb855f
Update BuildActionTelemetryTable tool
maryamariyan Mar 17, 2025
85d110d
Add feature flag controlling Copilot prompt in Semantic Search (#77562)
tmat Mar 17, 2025
806cb27
Fix BuildActionTelemetryTable project
JoeRobich Mar 17, 2025
dfa1641
[automated] Merge branch 'main' => 'main-vs-deps' (#77645)
dotnet-policy-service[bot] Mar 17, 2025
3eceae1
Update CodeActionDescriptionsMap.
JoeRobich Mar 17, 2025
ee84187
Fix typo
JoeRobich Mar 17, 2025
1529f23
Remove dead code, use generated regex, use filescoped namespace.
JoeRobich Mar 17, 2025
f296737
Update dependencies from https://github.com/dotnet/source-build-refer…
dotnet-maestro[bot] Mar 18, 2025
8d9e041
On-the-fly-docs Pass along additional context (#77510)
akhera99 Mar 18, 2025
a969b14
Change vs deps flow (#77651)
jjonescz Mar 18, 2025
e64e81c
[automated] Merge branch 'main' => 'main-vs-deps' (#77658)
dotnet-policy-service[bot] Mar 18, 2025
d5fe6f0
Fix generation of attribute with array constant
dibarbet Jan 22, 2025
6f384ca
Make ISemanticSearchCopilotUIProvider import lazy to avoid loading VS…
tmat Mar 18, 2025
2de5624
Fix watch window completion window upon manual completion invocation …
ToddGrun Mar 18, 2025
423e3da
Fix generation of attribute with array constant (#77661)
dibarbet Mar 18, 2025
76de433
Generate Documentation - Bug Fixes (#77641)
akhera99 Mar 18, 2025
06a1104
Ensure we get telemetry signal for `Implement with Copilot` Code Fix …
JoeRobich Mar 18, 2025
4aaf160
[automated] Merge branch 'main' => 'main-vs-deps' (#77662)
dotnet-policy-service[bot] Mar 18, 2025
a1a134e
Update maintenance-packages versions conditioned to sourcebuild only
carlossanlop Mar 19, 2025
41ad9f9
[automated] Merge branch 'main' => 'main-vs-deps' (#77666)
dotnet-policy-service[bot] Mar 19, 2025
29d0a35
Fix reflection
davidwengier Mar 19, 2025
121ba61
Fix reflection use in integration tests (#77669)
davidwengier Mar 19, 2025
ac77788
[automated] Merge branch 'main' => 'main-vs-deps' (#77673)
dotnet-policy-service[bot] Mar 19, 2025
8f92e67
Update dependencies from https://github.com/dotnet/source-build-refer…
dotnet-maestro[bot] Mar 19, 2025
447d6d1
Fix typo (#77678)
BillWagner Mar 19, 2025
a0a84e3
Avoid adding duplicate suppressors to the host analyzer arrays
sharwell Mar 19, 2025
27429a7
[automated] Merge branch 'main' => 'main-vs-deps' (#77679)
dotnet-policy-service[bot] Mar 19, 2025
b19eb22
Fix SkipApplyOptimizationData parameter (#77677)
jjonescz Mar 19, 2025
86cdbf5
[automated] Merge branch 'main' => 'main-vs-deps' (#77681)
dotnet-policy-service[bot] Mar 19, 2025
b07f304
Support textDocument/semanticTokens/full
PaddiM8 Mar 18, 2025
b634d09
Upgrade from VSTelemetryApi 17.14.2 to 17.14.8
arunchndr Mar 19, 2025
259b4d0
Support textDocument/semanticTokens/full (#77665)
dibarbet Mar 19, 2025
b1c7ddd
Cleanup and make semantic token processing and testing code more cons…
CyrusNajmabadi Mar 19, 2025
0d48864
Fix test
CyrusNajmabadi Mar 19, 2025
a4179e0
Add CI validation of Semantic Search API lists (#77535)
tmat Mar 19, 2025
77a9c20
raw strings
CyrusNajmabadi Mar 19, 2025
17368bc
Cleanup and make semantic token processing and testing code more cons…
CyrusNajmabadi Mar 19, 2025
38cced1
Fix bug where exact path match would throw for additional files (#77583)
Mar 19, 2025
8520d62
Update to latest in nuget.org
carlossanlop Mar 20, 2025
e07d8db
[automated] Merge branch 'main' => 'main-vs-deps' (#77688)
dotnet-policy-service[bot] Mar 20, 2025
6a92c2e
Update CSharpCopilotCodeAnalysisService.cs (#77691)
akhera99 Mar 20, 2025
57b748d
Update dependencies from https://github.com/dotnet/source-build-refer…
dotnet-maestro[bot] Mar 20, 2025
2d03d9f
Disable integration tests on PRs to main-vs-deps and above
jjonescz Mar 11, 2025
1edc92a
Make the ci build happy
ToddGrun Mar 19, 2025
f7f6957
[automated] Merge branch 'main' => 'main-vs-deps' (#77695)
dotnet-policy-service[bot] Mar 20, 2025
e9088c9
Remove old vs4mac code
CyrusNajmabadi Mar 20, 2025
b500362
Files
CyrusNajmabadi Mar 20, 2025
935c5fd
Remove old vs4mac code (#77705)
CyrusNajmabadi Mar 20, 2025
df5a657
Fix copilot layering
CyrusNajmabadi Mar 20, 2025
4bc17ee
Fix tests
CyrusNajmabadi Mar 20, 2025
6fbef16
Fix tests
CyrusNajmabadi Mar 20, 2025
577f0ea
Fix
CyrusNajmabadi Mar 20, 2025
7190843
[automated] Merge branch 'main' => 'main-vs-deps' (#77714)
dotnet-policy-service[bot] Mar 20, 2025
f6b5e28
Fix copilot layering (#77713)
CyrusNajmabadi Mar 20, 2025
9d9a3bf
[automated] Merge branch 'main' => 'main-vs-deps' (#77721)
dotnet-policy-service[bot] Mar 21, 2025
37f187d
Upgrade from VSTelemetryApi 17.14.2 to 17.14.8 (#77683)
arunchndr Mar 21, 2025
91c3b65
[automated] Merge branch 'main' => 'main-vs-deps' (#77723)
dotnet-policy-service[bot] Mar 21, 2025
f0a39d6
Update dependencies from https://github.com/dotnet/source-build-refer…
dotnet-maestro[bot] Mar 21, 2025
2cad920
Do not consider `ref` argument to `in`/`ref readonly` parameter as be…
jjonescz Mar 21, 2025
90954e6
Update dotnet format instructions (#77699)
jjonescz Mar 21, 2025
baed380
Add -solution option to build.ps1 (#77698)
jjonescz Mar 21, 2025
9254b4e
Update infra
jjonescz Mar 21, 2025
0e06d64
Update infra (#77728)
jjonescz Mar 21, 2025
c98aef0
Avoid adding duplicate suppressors to the host analyzer arrays (#77062)
sharwell Mar 21, 2025
a4a0af9
Merge branch 'main' into main-vs-deps
jjonescz Mar 21, 2025
38f239f
Fix updating committed solution with insignificant changes (#77648)
tmat Mar 21, 2025
d3c61cc
[automated] Merge branch 'main' => 'main-vs-deps' (#77729)
jjonescz Mar 21, 2025
40225ec
[automated] Merge branch 'main' => 'main-vs-deps' (#77734)
dotnet-policy-service[bot] Mar 21, 2025
81a989e
Improve raw string completion
CyrusNajmabadi Mar 21, 2025
b89ade7
Fix
CyrusNajmabadi Mar 21, 2025
53105cf
Fix speeling
CyrusNajmabadi Mar 21, 2025
2a61b54
Improve raw string completion (#77742)
CyrusNajmabadi Mar 21, 2025
809404c
Make things more strongly typed in compilation tracker
CyrusNajmabadi Mar 21, 2025
e590995
[automated] Merge branch 'main' => 'main-vs-deps' (#77753)
dotnet-policy-service[bot] Mar 22, 2025
d8ea7a2
Make things more strongly typed in compilation tracker (#77749)
CyrusNajmabadi Mar 22, 2025
1def752
[automated] Merge branch 'main' => 'main-vs-deps' (#77760)
dotnet-policy-service[bot] Mar 22, 2025
28b8657
Rework analyzer assembly loading (#77004)
jaredpar Mar 24, 2025
41cd893
Remove all the existing workaround checks
jasonmalinowski Mar 21, 2025
39817cb
Ensure we also package Microsoft.Extensions.DependencyInjection.Abstr…
jasonmalinowski Mar 22, 2025
e3fb7e4
Add new skips for Codelens
jasonmalinowski Mar 22, 2025
bb0521e
[automated] Merge branch 'main' => 'main-vs-deps' (#77776)
dotnet-policy-service[bot] Mar 24, 2025
8c4f371
Remove exclusion of main-vs-deps for running integration tests
jasonmalinowski Mar 24, 2025
427f3d3
Fix handling of partial definition deletes (#77735)
tmat Mar 24, 2025
12c2a51
Merge remote-tracking branch 'dotnet/main' into UpdateMP
carlossanlop Mar 24, 2025
a7fcc1f
Fix integration tests by adding skip for Codelens issue (#77758)
jasonmalinowski Mar 24, 2025
f8df511
Do not allow System.CommandLine to swallow all exceptions
dibarbet Mar 24, 2025
3a1d473
Set the default namespace for the project and proper folders for docu…
JoeRobich Mar 24, 2025
3918a22
Fix move to namespace offering for primary constructor (#77751)
Mar 24, 2025
320ea54
add comment
dibarbet Mar 25, 2025
993c769
Update src/LanguageServer/Microsoft.CodeAnalysis.LanguageServer/Progr…
dibarbet Mar 25, 2025
51187d4
Update tests to verify Folders change.
JoeRobich Mar 25, 2025
932542a
[automated] Merge branch 'main' => 'main-vs-deps' (#77790)
dotnet-policy-service[bot] Mar 25, 2025
aba6f81
Do not allow System.CommandLine to swallow all unhandled exceptions i…
dibarbet Mar 25, 2025
b7f166d
Set the default namespace for the project and proper folders for docu…
JoeRobich Mar 25, 2025
4140091
[automated] Merge branch 'main' => 'main-vs-deps' (#77797)
dotnet-policy-service[bot] Mar 25, 2025
50a87f3
Update dependencies from https://github.com/dotnet/source-build-refer…
dotnet-maestro[bot] Mar 25, 2025
3382aa6
Update maintenance-packages dependencies (#77267)
carlossanlop Mar 25, 2025
062fd4e
[automated] Merge branch 'main' => 'main-vs-deps' (#77801)
dotnet-policy-service[bot] Mar 25, 2025
0830bbe
Update infra
jjonescz Mar 25, 2025
f2b48f1
Merge branch 'main-vs-deps' into darc-main-c3e7ced2-17c5-41a3-ba92-b3…
jjonescz Mar 25, 2025
c9d14da
Fix issue with disappearing newlines after multiline documentation co…
dgounaris Mar 25, 2025
caafce2
Update infra (#77800)
jjonescz Mar 25, 2025
2d44e97
Simplify tests
CyrusNajmabadi Mar 25, 2025
6b203f2
Simplify tests
CyrusNajmabadi Mar 25, 2025
38b70fc
Simplify tests
CyrusNajmabadi Mar 25, 2025
cfbbc0f
Simplify tests
CyrusNajmabadi Mar 25, 2025
1ef60fe
Simplify tests (#77807)
CyrusNajmabadi Mar 25, 2025
ed98e42
Remove unnecessary nullable directives
CyrusNajmabadi Mar 25, 2025
834ce57
Remove unnecessary nullable directives
CyrusNajmabadi Mar 25, 2025
7560a5a
Remove unnecessary nullable directives
CyrusNajmabadi Mar 25, 2025
bf280aa
Remove unnecessary nullable directives
CyrusNajmabadi Mar 25, 2025
a5a201e
Remove unnecessary nullable directives
CyrusNajmabadi Mar 25, 2025
1636dd8
Remove unnecessary nullable directives
CyrusNajmabadi Mar 25, 2025
7067ae2
Remove unnecessary nullable directives
CyrusNajmabadi Mar 25, 2025
1a268a4
Remove unnecessary nullable directives
CyrusNajmabadi Mar 25, 2025
2a3f854
Remove unnecessary nullable directives
CyrusNajmabadi Mar 25, 2025
cec6e09
Remove unnecessary nullable directives (#77814)
CyrusNajmabadi Mar 25, 2025
de363a1
Generate Documentation - Add remarks if available (#77783)
akhera99 Mar 25, 2025
f5d37bf
Reduce likelihood of needing a dual insertion in VS Code (#77715)
Mar 25, 2025
472f123
Merge remote-tracking branch 'dotnet/main' into merge-main
jcouv Mar 25, 2025
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
The table of contents is too big for display.
Diff view
Diff view
  •  
  •  
  •  
8 changes: 1 addition & 7 deletions .github/workflows/main-merge.yml
Original file line number Diff line number Diff line change
Expand Up @@ -17,15 +17,9 @@ permissions:
pull-requests: write

jobs:
# The config does not support multiple flows from the same source branch,
# so we need to run separately for each duplicate source branch (https://github.com/dotnet/arcade/issues/15586).
merge:
if: github.repository == 'dotnet/roslyn'
uses: dotnet/arcade/.github/workflows/inter-branch-merge-base.yml@main
with:
configuration_file_path: 'eng/config/branch-merge.jsonc'
configuration_file_branch: ${{ inputs.configuration_file_branch || 'main' }}
merge-2:
uses: dotnet/arcade/.github/workflows/inter-branch-merge-base.yml@main
with:
configuration_file_path: 'eng/config/branch-merge-2.jsonc'
configuration_file_branch: ${{ inputs.configuration_file_branch || 'main' }}
27 changes: 20 additions & 7 deletions Roslyn.sln
Original file line number Diff line number Diff line change
Expand Up @@ -352,8 +352,6 @@ Project("{2150E333-8FDC-42A3-9474-1A3956D46DE8}") = "ExternalAccess", "ExternalA
EndProject
Project("{9A19103F-16F7-4668-BE54-9A1E7A4F7556}") = "Microsoft.CodeAnalysis.ExternalAccess.FSharp", "src\VisualStudio\ExternalAccess\FSharp\Microsoft.CodeAnalysis.ExternalAccess.FSharp.csproj", "{BD8CE303-5F04-45EC-8DCF-73C9164CD614}"
EndProject
Project("{9A19103F-16F7-4668-BE54-9A1E7A4F7556}") = "Microsoft.CodeAnalysis.ExternalAccess.Razor", "src\Tools\ExternalAccess\Razor\Microsoft.CodeAnalysis.ExternalAccess.Razor.csproj", "{2FB6C157-DF91-4B1C-9827-A4D1C08C73EC}"
EndProject
Project("{9A19103F-16F7-4668-BE54-9A1E7A4F7556}") = "Microsoft.VisualStudio.LanguageServices.CodeLens", "src\VisualStudio\CodeLens\Microsoft.VisualStudio.LanguageServices.CodeLens.csproj", "{5E6E9184-DEC5-4EC5-B0A4-77CFDC8CDEBE}"
EndProject
Project("{9A19103F-16F7-4668-BE54-9A1E7A4F7556}") = "Microsoft.CodeAnalysis.LanguageServer.Protocol", "src\LanguageServer\Protocol\Microsoft.CodeAnalysis.LanguageServer.Protocol.csproj", "{686BF57E-A6FF-467B-AAB3-44DE916A9772}"
Expand Down Expand Up @@ -579,6 +577,12 @@ Project("{D954291E-2A0B-460D-934E-DC6B0785DB48}") = "Microsoft.CodeAnalysis.Cont
EndProject
Project("{9A19103F-16F7-4668-BE54-9A1E7A4F7556}") = "Microsoft.CodeAnalysis.Contracts.Package", "src\Dependencies\Contracts\Microsoft.CodeAnalysis.Contracts.Package.csproj", "{A8D5CFFA-7F9E-C35B-4F19-D63F6EC1D5CA}"
EndProject
Project("{9a19103f-16f7-4668-be54-9a1e7a4f7556}") = "Microsoft.CodeAnalysis.ExternalAccess.Razor", "src\Tools\ExternalAccess\Razor\EditorFeatures\Microsoft.CodeAnalysis.ExternalAccess.Razor.csproj", "{068CD9AA-CEC3-CA68-1BAB-2B1B9FD711D3}"
EndProject
Project("{D954291E-2A0B-460D-934E-DC6B0785DB48}") = "Microsoft.CodeAnalysis.ExternalAccess.Razor.Shared", "src\Tools\ExternalAccess\Razor\Shared\Microsoft.CodeAnalysis.ExternalAccess.Razor.Shared.shproj", "{4853A78A-4EC4-4D86-9F02-D0DDEAE85520}"
EndProject
Project("{9a19103f-16f7-4668-be54-9a1e7a4f7556}") = "Microsoft.CodeAnalysis.ExternalAccess.Razor.Features", "src\Tools\ExternalAccess\Razor\Features\Microsoft.CodeAnalysis.ExternalAccess.Razor.Features.csproj", "{D5A8E20C-E8D2-4A57-906A-263994D8731D}"
EndProject
Project("{9A19103F-16F7-4668-BE54-9A1E7A4F7556}") = "Microsoft.VisualStudio.LanguageServices.ExternalAccess.Copilot", "src\VisualStudio\ExternalAccess\Copilot\Microsoft.VisualStudio.LanguageServices.ExternalAccess.Copilot.csproj", "{9EB058F3-10C9-8F3F-AD9E-72CB362A0928}"
EndProject
Global
Expand Down Expand Up @@ -1111,10 +1115,6 @@ Global
{BD8CE303-5F04-45EC-8DCF-73C9164CD614}.Debug|Any CPU.Build.0 = Debug|Any CPU
{BD8CE303-5F04-45EC-8DCF-73C9164CD614}.Release|Any CPU.ActiveCfg = Release|Any CPU
{BD8CE303-5F04-45EC-8DCF-73C9164CD614}.Release|Any CPU.Build.0 = Release|Any CPU
{2FB6C157-DF91-4B1C-9827-A4D1C08C73EC}.Debug|Any CPU.ActiveCfg = Debug|Any CPU
{2FB6C157-DF91-4B1C-9827-A4D1C08C73EC}.Debug|Any CPU.Build.0 = Debug|Any CPU
{2FB6C157-DF91-4B1C-9827-A4D1C08C73EC}.Release|Any CPU.ActiveCfg = Release|Any CPU
{2FB6C157-DF91-4B1C-9827-A4D1C08C73EC}.Release|Any CPU.Build.0 = Release|Any CPU
{5E6E9184-DEC5-4EC5-B0A4-77CFDC8CDEBE}.Debug|Any CPU.ActiveCfg = Debug|Any CPU
{5E6E9184-DEC5-4EC5-B0A4-77CFDC8CDEBE}.Debug|Any CPU.Build.0 = Debug|Any CPU
{5E6E9184-DEC5-4EC5-B0A4-77CFDC8CDEBE}.Release|Any CPU.ActiveCfg = Release|Any CPU
Expand Down Expand Up @@ -1427,6 +1427,14 @@ Global
{9EB058F3-10C9-8F3F-AD9E-72CB362A0928}.Debug|Any CPU.Build.0 = Debug|Any CPU
{9EB058F3-10C9-8F3F-AD9E-72CB362A0928}.Release|Any CPU.ActiveCfg = Release|Any CPU
{9EB058F3-10C9-8F3F-AD9E-72CB362A0928}.Release|Any CPU.Build.0 = Release|Any CPU
{068CD9AA-CEC3-CA68-1BAB-2B1B9FD711D3}.Debug|Any CPU.ActiveCfg = Debug|Any CPU
{068CD9AA-CEC3-CA68-1BAB-2B1B9FD711D3}.Debug|Any CPU.Build.0 = Debug|Any CPU
{068CD9AA-CEC3-CA68-1BAB-2B1B9FD711D3}.Release|Any CPU.ActiveCfg = Release|Any CPU
{068CD9AA-CEC3-CA68-1BAB-2B1B9FD711D3}.Release|Any CPU.Build.0 = Release|Any CPU
{D5A8E20C-E8D2-4A57-906A-263994D8731D}.Debug|Any CPU.ActiveCfg = Debug|Any CPU
{D5A8E20C-E8D2-4A57-906A-263994D8731D}.Debug|Any CPU.Build.0 = Debug|Any CPU
{D5A8E20C-E8D2-4A57-906A-263994D8731D}.Release|Any CPU.ActiveCfg = Release|Any CPU
{D5A8E20C-E8D2-4A57-906A-263994D8731D}.Release|Any CPU.Build.0 = Release|Any CPU
EndGlobalSection
GlobalSection(SolutionProperties) = preSolution
HideSolutionNode = FALSE
Expand Down Expand Up @@ -1586,7 +1594,6 @@ Global
{6362616E-6A47-48F0-9EE0-27800B306ACB} = {AFA5F921-0650-45E8-B293-51A0BB89DEA0}
{8977A560-45C2-4EC2-A849-97335B382C74} = {FD0FAF5F-1DED-485C-99FA-84B97F3A8EEC}
{BD8CE303-5F04-45EC-8DCF-73C9164CD614} = {5880FECB-91F1-4AB8-8726-75EAFA8A918E}
{2FB6C157-DF91-4B1C-9827-A4D1C08C73EC} = {8977A560-45C2-4EC2-A849-97335B382C74}
{5E6E9184-DEC5-4EC5-B0A4-77CFDC8CDEBE} = {8DBA5174-B0AA-4561-82B1-A46607697753}
{686BF57E-A6FF-467B-AAB3-44DE916A9772} = {D449D505-CC6A-4E0B-AF1B-976E2D0AE67A}
{1DDE89EE-5819-441F-A060-2FF4A986F372} = {D449D505-CC6A-4E0B-AF1B-976E2D0AE67A}
Expand Down Expand Up @@ -1695,6 +1702,9 @@ Global
{BD974609-C68B-4BE6-9682-EB132462B50D} = {C2D1346B-9665-4150-B644-075CF1636BAA}
{A8D5CFFA-7F9E-C35B-4F19-D63F6EC1D5CA} = {C2D1346B-9665-4150-B644-075CF1636BAA}
{9EB058F3-10C9-8F3F-AD9E-72CB362A0928} = {5880FECB-91F1-4AB8-8726-75EAFA8A918E}
{068CD9AA-CEC3-CA68-1BAB-2B1B9FD711D3} = {8977A560-45C2-4EC2-A849-97335B382C74}
{4853A78A-4EC4-4D86-9F02-D0DDEAE85520} = {8977A560-45C2-4EC2-A849-97335B382C74}
{D5A8E20C-E8D2-4A57-906A-263994D8731D} = {8977A560-45C2-4EC2-A849-97335B382C74}
EndGlobalSection
GlobalSection(ExtensibilityGlobals) = postSolution
SolutionGuid = {604E6B91-7BC0-4126-AE07-D4D2FEFC3D29}
Expand All @@ -1703,6 +1713,7 @@ Global
src\Analyzers\VisualBasic\CodeFixes\VisualBasicCodeFixes.projitems*{0141285d-8f6c-42c7-baf3-3c0ccd61c716}*SharedItemsImports = 5
src\Workspaces\SharedUtilitiesAndExtensions\Workspace\VisualBasic\VisualBasicWorkspaceExtensions.projitems*{0141285d-8f6c-42c7-baf3-3c0ccd61c716}*SharedItemsImports = 5
src\Compilers\CSharp\csc\CscCommandLine.projitems*{0161e25c-918a-4dc8-9648-30fdcc8e31e9}*SharedItemsImports = 5
src\Tools\ExternalAccess\Razor\Shared\Microsoft.CodeAnalysis.ExternalAccess.Razor.Shared.projitems*{068cd9aa-cec3-ca68-1bab-2b1b9fd711d3}*SharedItemsImports = 5
src\Dependencies\Contracts\Microsoft.CodeAnalysis.Contracts.projitems*{0c2e1633-1462-4712-88f4-a0c945bad3a8}*SharedItemsImports = 5
src\Analyzers\Core\CodeFixes\CodeFixes.projitems*{1b6c4a1a-413b-41fb-9f85-5c09118e541b}*SharedItemsImports = 13
src\Compilers\Core\AnalyzerDriver\AnalyzerDriver.projitems*{1ee8cad3-55f9-4d91-96b2-084641da9a6c}*SharedItemsImports = 5
Expand Down Expand Up @@ -1732,6 +1743,7 @@ Global
src\Compilers\CSharp\CSharpAnalyzerDriver\CSharpAnalyzerDriver.projitems*{3973b09a-4fbf-44a5-8359-3d22ceb71f71}*SharedItemsImports = 5
src\Dependencies\Contracts\Microsoft.CodeAnalysis.Contracts.projitems*{41ed1bfa-fdad-4fe4-8118-db23fb49b0b0}*SharedItemsImports = 5
src\Workspaces\SharedUtilitiesAndExtensions\Workspace\CSharp\CSharpWorkspaceExtensions.projitems*{438db8af-f3f0-4ed9-80b5-13fddd5b8787}*SharedItemsImports = 13
src\Tools\ExternalAccess\Razor\Shared\Microsoft.CodeAnalysis.ExternalAccess.Razor.Shared.projitems*{4853a78a-4ec4-4d86-9f02-d0ddeae85520}*SharedItemsImports = 13
src\Compilers\CSharp\csc\CscCommandLine.projitems*{4b45ca0c-03a0-400f-b454-3d4bcb16af38}*SharedItemsImports = 5
src\Analyzers\CSharp\Tests\CSharpAnalyzers.UnitTests.projitems*{5018d049-5870-465a-889b-c742ce1e31cb}*SharedItemsImports = 5
src\Compilers\CSharp\CSharpAnalyzerDriver\CSharpAnalyzerDriver.projitems*{54e08bf5-f819-404f-a18d-0ab9ea81ea04}*SharedItemsImports = 13
Expand Down Expand Up @@ -1788,6 +1800,7 @@ Global
src\Workspaces\SharedUtilitiesAndExtensions\Compiler\VisualBasic\VisualBasicCompilerExtensions.projitems*{cec0dce7-8d52-45c3-9295-fc7b16bd2451}*SharedItemsImports = 13
src\Compilers\Core\AnalyzerDriver\AnalyzerDriver.projitems*{d0bc9be7-24f6-40ca-8dc6-fcb93bd44b34}*SharedItemsImports = 13
src\Dependencies\Contracts\Microsoft.CodeAnalysis.Contracts.projitems*{d2589bce-4f2e-4113-b7e7-37392c0c5492}*SharedItemsImports = 5
src\Tools\ExternalAccess\Razor\Shared\Microsoft.CodeAnalysis.ExternalAccess.Razor.Shared.projitems*{d5a8e20c-e8d2-4a57-906a-263994d8731d}*SharedItemsImports = 5
src\Dependencies\CodeAnalysis.Debugging\Microsoft.CodeAnalysis.Debugging.projitems*{d73adf7d-2c1c-42ae-b2ab-edc9497e4b71}*SharedItemsImports = 13
src\Compilers\Server\VBCSCompiler\VBCSCompilerCommandLine.projitems*{d8ef0777-9d65-4849-a7d6-ac81e58e2317}*SharedItemsImports = 13
src\Analyzers\CSharp\CodeFixes\CSharpCodeFixes.projitems*{da973826-c985-4128-9948-0b445e638bdb}*SharedItemsImports = 13
Expand Down
5 changes: 3 additions & 2 deletions azure-pipelines-official.yml
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@ trigger:
- release/dev17.*
- release/dev18.*
- features/lsp_tools_host
- features/runtime-async
exclude:
- release/dev17.0
pr: none
Expand Down Expand Up @@ -163,7 +164,7 @@ extends:

- output: pipelineArtifact
displayName: 'Publish Ngen Logs'
condition: succeeded()
condition: and(succeeded(), ${{ not(parameters.SkipApplyOptimizationData) }})
targetPath: '$(Build.SourcesDirectory)\artifacts\log\$(BuildConfiguration)\ngen'
artifactName: 'NGen Logs'
publishLocation: Container
Expand Down Expand Up @@ -304,7 +305,7 @@ extends:
-configuration $(BuildConfiguration)
-officialBuildId $(Build.BuildNumber)
-officialSkipTests $(SkipTests)
-officialSkipApplyOptimizationData $(SkipApplyOptimizationData)
-officialSkipApplyOptimizationData ${{ parameters.SkipApplyOptimizationData }}
-officialSourceBranchName $(SourceBranchName)
-officialIbcDrop $(IbcDrop)
-officialVisualStudioDropAccessToken $(_DevDivDropAccessToken)
Expand Down
4 changes: 2 additions & 2 deletions azure-pipelines-pr-validation.yml
Original file line number Diff line number Diff line change
Expand Up @@ -98,7 +98,7 @@ extends:

- output: pipelineArtifact
displayName: 'Publish Ngen Logs'
condition: succeeded()
condition: and(succeeded(), ${{ not(parameters.SkipApplyOptimizationData) }})
targetPath: '$(Build.SourcesDirectory)\artifacts\log\$(BuildConfiguration)\ngen'
artifactName: 'NGen Logs'
publishLocation: Container
Expand Down Expand Up @@ -242,7 +242,7 @@ extends:
-configuration $(BuildConfiguration)
-officialBuildId $(OriginalBuildNumber)
-officialSkipTests $(SkipTests)
-officialSkipApplyOptimizationData $(SkipApplyOptimizationData)
-officialSkipApplyOptimizationData ${{ parameters.SkipApplyOptimizationData }}
-officialSourceBranchName $(SourceBranchName)
-officialIbcDrop $(IbcDrop)
-officialVisualStudioDropAccessToken $(_DevDivDropAccessToken)
Expand Down
2 changes: 1 addition & 1 deletion azure-pipelines.yml
Original file line number Diff line number Diff line change
Expand Up @@ -406,7 +406,7 @@ stages:
- powershell: eng/build.ps1 -configuration Release -prepareMachine -ci -restore -binaryLogName Restore.binlog
displayName: Restore

- powershell: eng/build.ps1 -configuration Release -prepareMachine -ci -build -pack -publish -sign -binaryLogName Build.binlog /p:DotnetPublishUsingPipelines=true
- powershell: eng/build.ps1 -configuration Release -prepareMachine -ci -build -pack -publish -sign -binaryLogName Build.binlog /p:DotnetPublishUsingPipelines=true /p:ContinuousIntegrationBuildCorrectness=true
displayName: Build

# While this task is not executed in the official build, this serves as a PR check for whether symbol exclusions
Expand Down
2 changes: 1 addition & 1 deletion docs/Language Feature Status.md
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,6 @@ efforts behind them.
| Feature | Branch | State | Developer | Reviewer | IDE Buddy | LDM Champ |
| ------- | ------ | ----- | --------- | -------- | --------- | --------- |
| [User Defined Compound Assignment Operators](https://github.com/dotnet/csharplang/issues/9101) | [UserDefinedCompoundAssignment](https://github.com/dotnet/roslyn/tree/features/UserDefinedCompoundAssignment) | [In Progress](https://github.com/dotnet/roslyn/issues/76934) | [AlekseyTs](https://github.com/AlekseyTs) | [333fred](https://github.com/333fred), [cston](https://github.com/cston) | TBD | [AlekseyTs](https://github.com/AlekseyTs) |
| [Partial Events and Constructors](https://github.com/dotnet/csharplang/issues/9058) | [PartialEventsCtors](https://github.com/dotnet/roslyn/tree/features/PartialEventsCtors) | [In Progress](https://github.com/dotnet/roslyn/issues/76859) | [jjonescz](https://github.com/jjonescz) | [cston](https://github.com/cston), [RikkiGibson](https://github.com/RikkiGibson) | | |
| Runtime Async | [runtime-async](https://github.com/dotnet/roslyn/tree/features/runtime-async) | [In Progress](https://github.com/dotnet/roslyn/issues/75960) | [333fred](https://github.com/333fred) | [jcouv](https://github.com/jcouv), [RikkiGibson](https://github.com/RikkiGibson) | | |
| [Null-conditional assignment](https://github.com/dotnet/csharplang/issues/6045) | [null-conditional-assignment](https://github.com/dotnet/roslyn/tree/features/null-conditional-assignment) | [In Progress](https://github.com/dotnet/roslyn/issues/75554) | [RikkiGibson](https://github.com/RikkiGibson) | [cston](https://github.com/cston), [jjonescz](https://github.com/jjonescz) | TBD | [RikkiGibson](https://github.com/RikkiGibson) |
| [Extensions](https://github.com/dotnet/csharplang/issues/8697) | [extensions](https://github.com/dotnet/roslyn/tree/features/extensions) | [In Progress](https://github.com/dotnet/roslyn/issues/76130) | [jcouv](https://github.com/jcouv), [AlekseyTs](https://github.com/AlekseyTs) | [jjonescz](https://github.com/jjonescz), TBD | [CyrusNajmabadi](https://github.com/CyrusNajmabadi) | [MadsTorgersen](https://github.com/MadsTorgersen) |
Expand All @@ -21,6 +20,7 @@ efforts behind them.
| [Unbound generic types in `nameof`](https://github.com/dotnet/csharplang/issues/8480) | [PR](https://github.com/dotnet/roslyn/pull/75368) | [Merged into 17.13p2](https://github.com/dotnet/roslyn/pull/75368) | [CyrusNajmabadi](https://github.com/CyrusNajmabadi) | [jcouv](https://github.com/jcouv), [AlekseyTs](https://github.com/AlekseyTs) | [CyrusNajmabadi](https://github.com/CyrusNajmabadi) | [CyrusNajmabadi](https://github.com/CyrusNajmabadi) |
| [String literals in data section as UTF8](https://github.com/dotnet/roslyn/blob/main/docs/features/string-literals-data-section.md) | [PR](https://github.com/dotnet/roslyn/pull/76036) | [Merged into 17.13p4](https://github.com/dotnet/roslyn/issues/76234) | [jjonescz](https://github.com/jjonescz) | [AlekseyTs](https://github.com/AlekseyTs), [cston](https://github.com/cston) | N/A | N/A |
| [Simple lambda parameters with modifiers](https://github.com/dotnet/csharplang/blob/main/proposals/simple-lambda-parameters-with-modifiers.md) | [PR](https://github.com/dotnet/roslyn/pull/75400) | [Merged into 17.14p1](https://github.com/dotnet/roslyn/pull/75400) | [CyrusNajmabadi](https://github.com/CyrusNajmabadi) | [jjonescz](https://github.com/jjonescz), [cston](https://github.com/cston) | [CyrusNajmabadi](https://github.com/CyrusNajmabadi) | [CyrusNajmabadi](https://github.com/CyrusNajmabadi) |
| [Partial Events and Constructors](https://github.com/dotnet/csharplang/issues/9058) | [PartialEventsCtors](https://github.com/dotnet/roslyn/tree/features/PartialEventsCtors) | [Merged into 17.14p3](https://github.com/dotnet/roslyn/issues/76859) | [jjonescz](https://github.com/jjonescz) | [cston](https://github.com/cston), [RikkiGibson](https://github.com/RikkiGibson) | [CyrusNajmabadi](https://github.com/CyrusNajmabadi) | [jaredpar](https://github.com/jaredpar) |

# Working Set VB

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -183,4 +183,4 @@ of the value is as follows:
5. `omit_if_default`. Redundant modifiers are disallowed. For example a private class member will be disallowed from
using `private`, and a public interface member will be disallowed from using `public`. This is the option to use
if you feel that restating the accessibility when it matches what the language chooses by default is redundant and
should be disalloed.
should be disallowed.
19 changes: 10 additions & 9 deletions docs/contributing/Building, Debugging, and Testing on Windows.md
Original file line number Diff line number Diff line change
Expand Up @@ -223,15 +223,16 @@ Before pushing a relevant fix to CI, you can validate locally using the `-testUs

### Running the PublicAPI fixer

1. Install `dotnet-format` as a global tool. It does ship as part of the SDK, but a separate version can be installed as a global tool and invoked with `dotnet-format {options}`.
`C:\Source\roslyn> dotnet tool install -g dotnet-format --version "6.*" --add-source https://pkgs.dev.azure.com/dnceng/public/_packaging/dotnet6/nuget/v3/index.json`
2. Restore and build `Compilers.slnf`. This is necessary to ensure the source generator project is built and we can load the generator assembly when running `dotnet-format`.
`C:\Source\roslyn> .\restore.cmd`
`C:\Source\roslyn> .\build.cmd`
3. Invoke the `dotnet-format` global tool. Running only the analyzers subcommand and fixing only the "missing Public API signature" diagnostic. We must also pass the `--include-generated` flag to include source generated documents in the analysis.
`C:\Source\roslyn> cd ..`
`C:\Source> dotnet-format analyzers .\roslyn\Compilers.slnf --diagnostics=RS0016 --no-restore --include-generated -v diag`

1. Restore and build `Compilers.slnf`. This is necessary to ensure the source generator project is built and we can load the generator assembly when running `dotnet format`.
```ps1
C:\Source\roslyn> .\restore.cmd
C:\Source\roslyn> .\build.cmd
```
2. Invoke `dotnet format` (the one included in .NET SDK, not the global tool `dotnet-format` which is deprecated). Running only the analyzers subcommand and fixing only the "missing Public API signature" diagnostic. We must also pass the `--include-generated` flag to include source generated documents in the analysis.
```ps1
C:\Source\roslyn> cd ..
C:\Source> dotnet format analyzers .\roslyn\Compilers.slnf --diagnostics=RS0016 --no-restore --include-generated -v diag
```

## Contributing

Expand Down
Loading