Merge latest bits from main branch to features/extensions
#77826
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ence assemblies to the exclusion list.
This diagnostic is always hidden (no UI) for the sole support of the associated code fix provider.
…eatures' into dev/maryamariyan/fixer-simplified Conflicts: src/Features/CSharp/Portable/Copilot/CSharpCopilotNotImplementedMethodFixProvider.cs
…icate-for-features
to keep the throw statement/expression check - Adds more test - Removes dead code - [ ] Cleanup more code - [ ] Fix failing tests - [ ] Rename API make consistent - [ ] Revisist triple slash docs - [ ] Change SyntaxNode to MemberDeclaration - [ ] Remove unexpected null checks
- [x] Adds more test
- [x] Removes dead code
- [x] Cleans up more code
- [ ] Fix failing tests
- [x] Renames API to make consistent
- [x] Revisits triple slash docs
- [x] API Accepts SyntaxNode
- [x] Removes unreachable code
- and do minor Cleanup
- [ ] Fixer seems not activates in tests
- Test correction on placement of diagnostic span
We've nullable disabled a bunch of files in the IDE, for reasons i don't understand. Our code should be nullable safe. And if not, we should fix it. I'm enabling nullability on roslyn ide.
* add remarks to documentation if available * add named parameter for nulls
* Create new folder structure for Razor EA. /Shared : will eventually be the area for all source items shared between the current EA and the new EA.Razor.Features /Features : will have an EA that is restricted to depending only on the features layer. This will help provide a way to ship a more sane EA structure for VS Code as well as reduce the likelyhood and work required for a dual insertion /EditorFeatures : contains the current EA. The project name is kept the same for now but the folder is moved. This denotes that the binary does depend on the EditorFeatures layer in Roslyn
ghost
added
the
untriaged
dotnet-policy-service
bot
added
VSCode
Needs API Review
Contributor
|
This PR modifies public API files. Please follow the instructions at https://github.com/dotnet/roslyn/blob/main/docs/contributing/API%20Review%20Process.md for ensuring all public APIs are reviewed before merging. |
jjonescz
approved these changes
Mar 26, 2025
This was referenced Apr 1, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
22 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No notable conflicts