Add dump reporting for https://github.com/dotnet/roslyn/issues/76225 #78354
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is very likely somehow related to dotnet#74728 but is proving very difficult to track down without a repro or a dump.
ghost
added
Area-IDE
untriaged
Contributor
Author
|
@CyrusNajmabadi -- thoughts on taking this for 17.14? |
| { | ||
| originalLineInfo = location.GetLineSpan(); | ||
| } | ||
| catch (Exception e) when (FatalError.ReportWithDumpAndCatch(e, ErrorSeverity.Critical)) |
Member
There was a problem hiding this comment.
is tehre no REportWithDumpAndPropagate?
Member
There was a problem hiding this comment.
i would explicitly add a comment stating this is for #74728
CyrusNajmabadi
approved these changes
Apr 28, 2025
Member
|
Yes. I think we shoudl backport this. @arunchndr . |
jasonmalinowski
approved these changes
Apr 28, 2025
ToddGrun
added a commit
to ToddGrun/roslyn
that referenced
this pull request
Apr 29, 2025
* Add dump reporting for dotnet#76225 This is very likely somehow related to dotnet#74728 but is proving very difficult to track down without a repro or a dump.
This was referenced May 1, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is very likely somehow related to #74728 but is proving very difficult to track down without a repro or a dump.