Skip to content

Ensure hover markdown for supported platforms uses non-breaking spaces for indentation #78405

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 3, 2025
Merged

Ensure hover markdown for supported platforms uses non-breaking spaces for indentation #78405

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
911ee13
Ensure hover markdown for supported platforms uses non-breaking space…
dibarbet May 1, 2025
355ee34
update tests to account for resource change
dibarbet May 2, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 12 additions & 12 deletions ...EditorFeatures/CSharpTest/Completion/CompletionProviders/SymbolCompletionProviderTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8785,8 +8785,8 @@ void goo()
var expectedDescription = $"""
({FeaturesResources.field}) int C.x

{string.Format(FeaturesResources._0_1, "Proj1", FeaturesResources.Available)}
{string.Format(FeaturesResources._0_1, "Proj2", FeaturesResources.Not_Available)}
{string.Format(FeaturesResources._0_1, "Proj1", FeaturesResources.Available)}
{string.Format(FeaturesResources._0_1, "Proj2", FeaturesResources.Not_Available)}

{FeaturesResources.You_can_use_the_navigation_bar_to_switch_contexts}
""";
Expand Down Expand Up @@ -8825,9 +8825,9 @@ void goo()
var expectedDescription = $"""
({FeaturesResources.field}) int C.x

{string.Format(FeaturesResources._0_1, "Proj1", FeaturesResources.Available)}
{string.Format(FeaturesResources._0_1, "Proj2", FeaturesResources.Not_Available)}
{string.Format(FeaturesResources._0_1, "Proj3", FeaturesResources.Not_Available)}
{string.Format(FeaturesResources._0_1, "Proj1", FeaturesResources.Available)}
{string.Format(FeaturesResources._0_1, "Proj2", FeaturesResources.Not_Available)}
{string.Format(FeaturesResources._0_1, "Proj3", FeaturesResources.Not_Available)}

{FeaturesResources.You_can_use_the_navigation_bar_to_switch_contexts}
""";
Expand Down Expand Up @@ -8869,8 +8869,8 @@ void goo()
var expectedDescription = $"""
({FeaturesResources.field}) int C.x

{string.Format(FeaturesResources._0_1, "Proj1", FeaturesResources.Available)}
{string.Format(FeaturesResources._0_1, "Proj3", FeaturesResources.Not_Available)}
{string.Format(FeaturesResources._0_1, "Proj1", FeaturesResources.Available)}
{string.Format(FeaturesResources._0_1, "Proj3", FeaturesResources.Not_Available)}

{FeaturesResources.You_can_use_the_navigation_bar_to_switch_contexts}
""";
Expand Down Expand Up @@ -8916,9 +8916,9 @@ void goo()
var expectedDescription = $"""
void G.DoGStuff()

{string.Format(FeaturesResources._0_1, "Proj1", FeaturesResources.Not_Available)}
{string.Format(FeaturesResources._0_1, "Proj2", FeaturesResources.Available)}
{string.Format(FeaturesResources._0_1, "Proj3", FeaturesResources.Not_Available)}
{string.Format(FeaturesResources._0_1, "Proj1", FeaturesResources.Not_Available)}
{string.Format(FeaturesResources._0_1, "Proj2", FeaturesResources.Available)}
{string.Format(FeaturesResources._0_1, "Proj3", FeaturesResources.Not_Available)}

{FeaturesResources.You_can_use_the_navigation_bar_to_switch_contexts}
""";
Expand Down Expand Up @@ -8981,8 +8981,8 @@ void M()
var expectedDescription = $"""
({FeaturesResources.local_variable}) int xyz

{string.Format(FeaturesResources._0_1, "Proj1", FeaturesResources.Available)}
{string.Format(FeaturesResources._0_1, "Proj2", FeaturesResources.Not_Available)}
{string.Format(FeaturesResources._0_1, "Proj1", FeaturesResources.Available)}
{string.Format(FeaturesResources._0_1, "Proj2", FeaturesResources.Not_Available)}

{FeaturesResources.You_can_use_the_navigation_bar_to_switch_contexts}
""";
Expand Down
22 changes: 11 additions & 11 deletions src/EditorFeatures/CSharpTest/QuickInfo/SemanticQuickInfoSourceTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6295,8 +6295,8 @@ void goo()
""";
var expectedDescription = Usage($"""

{string.Format(FeaturesResources._0_1, "Proj1", FeaturesResources.Available)}
{string.Format(FeaturesResources._0_1, "Proj2", FeaturesResources.Not_Available)}
{string.Format(FeaturesResources._0_1, "Proj1", FeaturesResources.Available)}
{string.Format(FeaturesResources._0_1, "Proj2", FeaturesResources.Not_Available)}

{FeaturesResources.You_can_use_the_navigation_bar_to_switch_contexts}
""", expectsWarningGlyph: true);
Expand Down Expand Up @@ -6331,8 +6331,8 @@ void goo()
""";
var expectedDescription = Usage($"""

{string.Format(FeaturesResources._0_1, "Proj1", FeaturesResources.Not_Available)}
{string.Format(FeaturesResources._0_1, "Proj2", FeaturesResources.Available)}
{string.Format(FeaturesResources._0_1, "Proj1", FeaturesResources.Not_Available)}
{string.Format(FeaturesResources._0_1, "Proj2", FeaturesResources.Available)}

{FeaturesResources.You_can_use_the_navigation_bar_to_switch_contexts}
""", expectsWarningGlyph: true);
Expand Down Expand Up @@ -6371,9 +6371,9 @@ void goo()
var expectedDescription = Usage(
$"""

{string.Format(FeaturesResources._0_1, "Proj1", FeaturesResources.Available)}
{string.Format(FeaturesResources._0_1, "Proj2", FeaturesResources.Not_Available)}
{string.Format(FeaturesResources._0_1, "Proj3", FeaturesResources.Not_Available)}
{string.Format(FeaturesResources._0_1, "Proj1", FeaturesResources.Available)}
{string.Format(FeaturesResources._0_1, "Proj2", FeaturesResources.Not_Available)}
{string.Format(FeaturesResources._0_1, "Proj3", FeaturesResources.Not_Available)}

{FeaturesResources.You_can_use_the_navigation_bar_to_switch_contexts}
""",
Expand Down Expand Up @@ -6415,8 +6415,8 @@ void goo()
""";
var expectedDescription = Usage($"""

{string.Format(FeaturesResources._0_1, "Proj1", FeaturesResources.Available)}
{string.Format(FeaturesResources._0_1, "Proj3", FeaturesResources.Not_Available)}
{string.Format(FeaturesResources._0_1, "Proj1", FeaturesResources.Available)}
{string.Format(FeaturesResources._0_1, "Proj3", FeaturesResources.Not_Available)}

{FeaturesResources.You_can_use_the_navigation_bar_to_switch_contexts}
""", expectsWarningGlyph: true);
Expand Down Expand Up @@ -6507,8 +6507,8 @@ void M()

await VerifyWithReferenceWorkerAsync(markup, [MainDescription($"({FeaturesResources.local_variable}) int x"), Usage($"""

{string.Format(FeaturesResources._0_1, "Proj1", FeaturesResources.Available)}
{string.Format(FeaturesResources._0_1, "Proj2", FeaturesResources.Not_Available)}
{string.Format(FeaturesResources._0_1, "Proj1", FeaturesResources.Available)}
{string.Format(FeaturesResources._0_1, "Proj2", FeaturesResources.Not_Available)}

{FeaturesResources.You_can_use_the_navigation_bar_to_switch_contexts}
""", expectsWarningGlyph: true)]);
Expand Down
18 changes: 16 additions & 2 deletions src/EditorFeatures/CSharpTest/SignatureHelp/AttributeSignatureHelpProviderTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -998,7 +998,14 @@ void Goo()
</Project>
</Workspace>
""";
var expectedDescription = new SignatureHelpTestItem($"Secret()\r\n\r\n{string.Format(FeaturesResources._0_1, "Proj1", FeaturesResources.Available)}\r\n{string.Format(FeaturesResources._0_1, "Proj2", FeaturesResources.Not_Available)}\r\n\r\n{FeaturesResources.You_can_use_the_navigation_bar_to_switch_contexts}", currentParameterIndex: 0);
var expectedDescription = new SignatureHelpTestItem($"""
Secret()

{string.Format(FeaturesResources._0_1, "Proj1", FeaturesResources.Available)}
{string.Format(FeaturesResources._0_1, "Proj2", FeaturesResources.Not_Available)}

{FeaturesResources.You_can_use_the_navigation_bar_to_switch_contexts}
""", currentParameterIndex: 0);
await VerifyItemWithReferenceWorkerAsync(markup, [expectedDescription], false);
}

Expand Down Expand Up @@ -1036,7 +1043,14 @@ void Goo()
</Workspace>
""";

var expectedDescription = new SignatureHelpTestItem($"Secret()\r\n\r\n{string.Format(FeaturesResources._0_1, "Proj1", FeaturesResources.Available)}\r\n{string.Format(FeaturesResources._0_1, "Proj3", FeaturesResources.Not_Available)}\r\n\r\n{FeaturesResources.You_can_use_the_navigation_bar_to_switch_contexts}", currentParameterIndex: 0);
var expectedDescription = new SignatureHelpTestItem($"""
Secret()

{string.Format(FeaturesResources._0_1, "Proj1", FeaturesResources.Available)}
{string.Format(FeaturesResources._0_1, "Proj3", FeaturesResources.Not_Available)}

{FeaturesResources.You_can_use_the_navigation_bar_to_switch_contexts}
""", currentParameterIndex: 0);
await VerifyItemWithReferenceWorkerAsync(markup, [expectedDescription], false);
}

Expand Down
18 changes: 16 additions & 2 deletions ...itorFeatures/CSharpTest/SignatureHelp/ConstructorInitializerSignatureHelpProviderTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -597,7 +597,14 @@ public SuperSecret(int secret) : base($$
</Project>
</Workspace>
""";
var expectedDescription = new SignatureHelpTestItem($"Secret(int secret)\r\n\r\n{string.Format(FeaturesResources._0_1, "Proj1", FeaturesResources.Available)}\r\n{string.Format(FeaturesResources._0_1, "Proj2", FeaturesResources.Not_Available)}\r\n\r\n{FeaturesResources.You_can_use_the_navigation_bar_to_switch_contexts}", currentParameterIndex: 0);
var expectedDescription = new SignatureHelpTestItem($"""
Secret(int secret)

{string.Format(FeaturesResources._0_1, "Proj1", FeaturesResources.Available)}
{string.Format(FeaturesResources._0_1, "Proj2", FeaturesResources.Not_Available)}

{FeaturesResources.You_can_use_the_navigation_bar_to_switch_contexts}
""", currentParameterIndex: 0);
await VerifyItemWithReferenceWorkerAsync(markup, [expectedDescription], false);
}

Expand Down Expand Up @@ -638,7 +645,14 @@ public SuperSecret(int secret) : base($$
</Workspace>
""";

var expectedDescription = new SignatureHelpTestItem($"Secret(int secret)\r\n\r\n{string.Format(FeaturesResources._0_1, "Proj1", FeaturesResources.Available)}\r\n{string.Format(FeaturesResources._0_1, "Proj3", FeaturesResources.Not_Available)}\r\n\r\n{FeaturesResources.You_can_use_the_navigation_bar_to_switch_contexts}", currentParameterIndex: 0);
var expectedDescription = new SignatureHelpTestItem($"""
Secret(int secret)

{string.Format(FeaturesResources._0_1, "Proj1", FeaturesResources.Available)}
{string.Format(FeaturesResources._0_1, "Proj3", FeaturesResources.Not_Available)}

{FeaturesResources.You_can_use_the_navigation_bar_to_switch_contexts}
""", currentParameterIndex: 0);
await VerifyItemWithReferenceWorkerAsync(markup, [expectedDescription], false);
}

Expand Down
18 changes: 16 additions & 2 deletions ...torFeatures/CSharpTest/SignatureHelp/ElementAccessExpressionSignatureHelpProviderTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -816,7 +816,14 @@ void goo()
</Project>
</Workspace>
""";
var expectedDescription = new SignatureHelpTestItem($"int C[int z]\r\n\r\n{string.Format(FeaturesResources._0_1, "Proj1", FeaturesResources.Available)}\r\n{string.Format(FeaturesResources._0_1, "Proj2", FeaturesResources.Not_Available)}\r\n\r\n{FeaturesResources.You_can_use_the_navigation_bar_to_switch_contexts}", currentParameterIndex: 0);
var expectedDescription = new SignatureHelpTestItem($"""
int C[int z]

{string.Format(FeaturesResources._0_1, "Proj1", FeaturesResources.Available)}
{string.Format(FeaturesResources._0_1, "Proj2", FeaturesResources.Not_Available)}

{FeaturesResources.You_can_use_the_navigation_bar_to_switch_contexts}
""", currentParameterIndex: 0);
await VerifyItemWithReferenceWorkerAsync(markup, [expectedDescription], false);
}

Expand Down Expand Up @@ -858,7 +865,14 @@ void goo()
</Workspace>
""";

var expectedDescription = new SignatureHelpTestItem($"int C[int z]\r\n\r\n{string.Format(FeaturesResources._0_1, "Proj1", FeaturesResources.Available)}\r\n{string.Format(FeaturesResources._0_1, "Proj3", FeaturesResources.Not_Available)}\r\n\r\n{FeaturesResources.You_can_use_the_navigation_bar_to_switch_contexts}", currentParameterIndex: 0);
var expectedDescription = new SignatureHelpTestItem($"""
int C[int z]

{string.Format(FeaturesResources._0_1, "Proj1", FeaturesResources.Available)}
{string.Format(FeaturesResources._0_1, "Proj3", FeaturesResources.Not_Available)}

{FeaturesResources.You_can_use_the_navigation_bar_to_switch_contexts}
""", currentParameterIndex: 0);
await VerifyItemWithReferenceWorkerAsync(markup, [expectedDescription], false);
}

Expand Down
18 changes: 16 additions & 2 deletions src/EditorFeatures/CSharpTest/SignatureHelp/GenericNameSignatureHelpProviderTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -782,7 +782,14 @@ void goo()
</Project>
</Workspace>
""";
var expectedDescription = new SignatureHelpTestItem($"D<T>\r\n\r\n{string.Format(FeaturesResources._0_1, "Proj1", FeaturesResources.Available)}\r\n{string.Format(FeaturesResources._0_1, "Proj2", FeaturesResources.Not_Available)}\r\n\r\n{FeaturesResources.You_can_use_the_navigation_bar_to_switch_contexts}", currentParameterIndex: 0);
var expectedDescription = new SignatureHelpTestItem($"""
D<T>

{string.Format(FeaturesResources._0_1, "Proj1", FeaturesResources.Available)}
{string.Format(FeaturesResources._0_1, "Proj2", FeaturesResources.Not_Available)}

{FeaturesResources.You_can_use_the_navigation_bar_to_switch_contexts}
""", currentParameterIndex: 0);
await VerifyItemWithReferenceWorkerAsync(markup, [expectedDescription], false);
}

Expand Down Expand Up @@ -820,7 +827,14 @@ void goo()
</Workspace>
""";

var expectedDescription = new SignatureHelpTestItem($"D<T>\r\n\r\n{string.Format(FeaturesResources._0_1, "Proj1", FeaturesResources.Available)}\r\n{string.Format(FeaturesResources._0_1, "Proj3", FeaturesResources.Not_Available)}\r\n\r\n{FeaturesResources.You_can_use_the_navigation_bar_to_switch_contexts}", currentParameterIndex: 0);
var expectedDescription = new SignatureHelpTestItem($"""
D<T>

{string.Format(FeaturesResources._0_1, "Proj1", FeaturesResources.Available)}
{string.Format(FeaturesResources._0_1, "Proj3", FeaturesResources.Not_Available)}

{FeaturesResources.You_can_use_the_navigation_bar_to_switch_contexts}
""", currentParameterIndex: 0);
await VerifyItemWithReferenceWorkerAsync(markup, [expectedDescription], false);
}

Expand Down
20 changes: 10 additions & 10 deletions ...EditorFeatures/CSharpTest/SignatureHelp/InvocationExpressionSignatureHelpProviderTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2082,8 +2082,8 @@ void goo()
await VerifyItemWithReferenceWorkerAsync(markup, [new SignatureHelpTestItem($"""
void C.bar()

{string.Format(FeaturesResources._0_1, "Proj1", FeaturesResources.Available)}
{string.Format(FeaturesResources._0_1, "Proj2", FeaturesResources.Not_Available)}
{string.Format(FeaturesResources._0_1, "Proj1", FeaturesResources.Available)}
{string.Format(FeaturesResources._0_1, "Proj2", FeaturesResources.Not_Available)}

{FeaturesResources.You_can_use_the_navigation_bar_to_switch_contexts}
""", currentParameterIndex: 0)], hideAdvancedMembers: false);
Expand Down Expand Up @@ -2126,8 +2126,8 @@ void goo()
await VerifyItemWithReferenceWorkerAsync(markup, [new SignatureHelpTestItem($"""
void C.bar()

{string.Format(FeaturesResources._0_1, "Proj1", FeaturesResources.Available)}
{string.Format(FeaturesResources._0_1, "Proj3", FeaturesResources.Not_Available)}
{string.Format(FeaturesResources._0_1, "Proj1", FeaturesResources.Available)}
{string.Format(FeaturesResources._0_1, "Proj3", FeaturesResources.Not_Available)}

{FeaturesResources.You_can_use_the_navigation_bar_to_switch_contexts}
""", currentParameterIndex: 0)], hideAdvancedMembers: false);
Expand Down Expand Up @@ -2341,8 +2341,8 @@ void Shared()
await VerifyItemWithReferenceWorkerAsync(markup, [new SignatureHelpTestItem($"""
void C.Do(int x)

{string.Format(FeaturesResources._0_1, "Proj1", FeaturesResources.Available)}
{string.Format(FeaturesResources._0_1, "Proj2", FeaturesResources.Not_Available)}
{string.Format(FeaturesResources._0_1, "Proj1", FeaturesResources.Available)}
{string.Format(FeaturesResources._0_1, "Proj2", FeaturesResources.Not_Available)}

{FeaturesResources.You_can_use_the_navigation_bar_to_switch_contexts}
""", currentParameterIndex: 0)], hideAdvancedMembers: false);
Expand Down Expand Up @@ -2613,8 +2613,8 @@ void goo()
expectedItems.Add(new SignatureHelpTestItem($"""
void C.M<object>(Action<object> arg1, object arg2, bool flag)

{string.Format(FeaturesResources._0_1, "Proj1", FeaturesResources.Available)}
{string.Format(FeaturesResources._0_1, "Proj2", FeaturesResources.Not_Available)}
{string.Format(FeaturesResources._0_1, "Proj1", FeaturesResources.Available)}
{string.Format(FeaturesResources._0_1, "Proj2", FeaturesResources.Not_Available)}

{FeaturesResources.You_can_use_the_navigation_bar_to_switch_contexts}
""", currentParameterIndex: 0));
Expand All @@ -2625,8 +2625,8 @@ void C.M<object>(Action<object> arg1, object arg2, bool flag)
expectedItems.Add(new SignatureHelpTestItem($"""
void C.M<T>(Action<T> arg1, T arg2, bool flag)

{string.Format(FeaturesResources._0_1, "Proj1", FeaturesResources.Available)}
{string.Format(FeaturesResources._0_1, "Proj2", FeaturesResources.Not_Available)}
{string.Format(FeaturesResources._0_1, "Proj1", FeaturesResources.Available)}
{string.Format(FeaturesResources._0_1, "Proj2", FeaturesResources.Not_Available)}

{FeaturesResources.You_can_use_the_navigation_bar_to_switch_contexts}
""", currentParameterIndex: 0));
Expand Down
18 changes: 16 additions & 2 deletions ...orFeatures/CSharpTest/SignatureHelp/ObjectCreationExpressionSignatureHelpProviderTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -615,7 +615,14 @@ void goo()
""";

await VerifyItemWithReferenceWorkerAsync(
markup, [new($"D()\r\n\r\n{string.Format(FeaturesResources._0_1, "Proj1", FeaturesResources.Available)}\r\n{string.Format(FeaturesResources._0_1, "Proj2", FeaturesResources.Not_Available)}\r\n\r\n{FeaturesResources.You_can_use_the_navigation_bar_to_switch_contexts}", currentParameterIndex: 0)], false);
markup, [new($"""
D()

{string.Format(FeaturesResources._0_1, "Proj1", FeaturesResources.Available)}
{string.Format(FeaturesResources._0_1, "Proj2", FeaturesResources.Not_Available)}

{FeaturesResources.You_can_use_the_navigation_bar_to_switch_contexts}
""", currentParameterIndex: 0)], false);
}

[Fact]
Expand Down Expand Up @@ -653,7 +660,14 @@ void goo()
""";

await VerifyItemWithReferenceWorkerAsync(
markup, [new($"D()\r\n\r\n{string.Format(FeaturesResources._0_1, "Proj1", FeaturesResources.Available)}\r\n{string.Format(FeaturesResources._0_1, "Proj3", FeaturesResources.Not_Available)}\r\n\r\n{FeaturesResources.You_can_use_the_navigation_bar_to_switch_contexts}", currentParameterIndex: 0)], false);
markup, [new($"""
D()

{string.Format(FeaturesResources._0_1, "Proj1", FeaturesResources.Available)}
{string.Format(FeaturesResources._0_1, "Proj3", FeaturesResources.Not_Available)}

{FeaturesResources.You_can_use_the_navigation_bar_to_switch_contexts}
""", currentParameterIndex: 0)], false);
}

[Fact, WorkItem("http://vstfdevdiv:8080/DevDiv2/DevDiv/_workitems/edit/1067933")]
Expand Down
Loading
Loading