Backport copilot text change analysis to 17.14 #78498
Conversation
ghost
added
Area-IDE
untriaged
Followup to dotnet#78356. Needed so we can access IDiagAnalyzerService in OOP. Currently one cannot as it attempts to access the Workspace of a document passed into it. We block WOrkspace access like for safety/clarity concerns (we don't want a stateless OOP api call to have access to the mutable workspace API). This also cleans up some ugly initialization code IDiagAnalyzerService had.
|
/azp run roslyn-integration-CI |
|
Azure Pipelines successfully started running 1 pipeline(s). |
…ct with other code fixes (dotnet#78540)
There was a problem hiding this comment.
I skimmed through both the original PRs and this backport, and everything looks good to me. Is there a reason this backport wasn't done as a routine cherry-pick? Just wanted to confirm in case this was a manual backport, as that can make cross-referencing a bit trickier.
Let me know if there are specific files you'd like me to review more closely, especially if any parts of the backport were non-trivial
|
@maryamariyan I'm not sure what you mean. This was done with cherry picking the four prs related to this feature from main. Could you clarify what you mean? |
| workspace.TryApplyChanges(workspace.CurrentSolution.WithAnalyzerReferences([analyzerReference])); | ||
|
|
||
| var diagnosticService = workspace.GetService<IDiagnosticAnalyzerService>(); | ||
| var diagnosticService = workspace.Services.GetRequiredService<IDiagnosticAnalyzerService>(); |
There was a problem hiding this comment.
seems no longer necessary in all the tests with the CodeFixService no longer taking it as a param?
4 participants
Backport #78146 and #78353 to dev17.14