Merge 'main' into 'extensions' #79106
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This API was lifted and shifted entirely to the ManagedProvider package in azdo. Obsoleting this fully to ensure that nothing ever uses it. Will also take through API review to eventually make the change to remove this entirely.
* [VMR] Codeflow a528f84-a528f84 [[ commit created by automation ]] * Update dependencies from https://github.com/dotnet/dotnet build 270315 No dependency updates to commit * [VMR] Codeflow f5faea9-f5faea9 [[ commit created by automation ]] * Update dependencies from https://github.com/dotnet/dotnet build 270450 No dependency updates to commit * Update dependencies from https://github.com/dotnet/dotnet build 270603 No dependency updates to commit * Update dependencies from https://github.com/dotnet/dotnet build 270662 No dependency updates to commit * [VMR] Codeflow 86826d3-86826d3 [[ commit created by automation ]] * Update dependencies from https://github.com/dotnet/dotnet build 271018 No dependency updates to commit * [VMR] Codeflow 32a2620-32a2620 [[ commit created by automation ]] * Update dependencies from https://github.com/dotnet/dotnet build 271181 No dependency updates to commit * [VMR] Codeflow 25357a9-25357a9 [[ commit created by automation ]] * Update dependencies from https://github.com/dotnet/dotnet build 271343 No dependency updates to commit * Update dependencies from https://github.com/dotnet/dotnet build 271417 No dependency updates to commit * Revert incorrect Roslyn.sln changes --------- Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com> Co-authored-by: Viktor Hofer <viktor.hofer@microsoft.com>
…hods' completion. (dotnet#78923)
* Expose `IsIterator` as a public API * Fix workspace generated method symbol implementation * Implement new property in yet another non-compiler-owned method symbol implementation * SemanticSearch.ReferenceAssemblies * Verify public code path in C# * Add negative tests * Add C# local function tests * Test VB lambda iterators * Revert accessibility change * Disable warnings * Use explicit type * Simplify lambda tests * Test interface property * Add additional VB case
This existed back from when the input to the function was a namespace, but that's not the case anymore.
CPS passes us an INamespaceSymbol that is the global namespace symbol; it doesn't have a containing assembly. It does have a containing Compilation though, which is what we actually need. Fixes https://devdiv.visualstudio.com/DevDiv/_workitems/edit/2506795 Fixes dotnet#78697
I'm not sure why this ever took an INamespaceSymbol in the first place, but we either have code working around it, or having an (old) comment saying the code was wrong.
Allow Razor to not have to copy the complex edit command name, and override formatting settings (in tests for now, but possibly more later) Razor side: dotnet/razor#11949
CPS passes us an INamespaceSymbol that is the global namespace symbol; it doesn't have a containing assembly. It does have a containing Compilation though, which is what we actually need. While I'm here, let's expose a better API for this to avoid this silly dance in the first place. Fixes https://devdiv.visualstudio.com/DevDiv/_workitems/edit/2506795 Fixes dotnet#78697
* Fix SubText ctor parameter verification. This ctor currently throws given a zero length span at the end (and only the end) of the subtext. This evidently became far more prevalent with this (fairly) recent change to optimize newline information in our sourcetext classes. (dotnet#74728) It doesn't make to allow zero length spans at all locations but at the end of the subtext, so the fix is just to allow construction in that case too. Big props to Manish Vasani for providing a very actionable repro for this. Fixes dotnet#78985. Note there is a potentially related issue outlined in dotnet#76225 that looks attributable to the PR above too. It possible that this addresses that issue too, but I'm not completely convinced.
…structor" refactoring
Fixes: dotnet#79077 Also tweaked ordering of assignments in generated regular constructor to be more expected in partial types scenarios
AlekseyTs
added
Area-Compilers
Feature - Extension Everything
dotnet-policy-service
bot
added
VSCode
Needs API Review
Contributor
|
This PR modifies public API files. Please follow the instructions at https://github.com/dotnet/roslyn/blob/main/docs/contributing/API%20Review%20Process.md for ensuring all public APIs are reviewed before merging. |
Contributor
Author
jcouv
approved these changes
Jun 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
14 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.