Precursor to share code with RoslynAnalyzers. #79117
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix more Update versions Fix more In progress Flip Fix Fix remove wrapper Fix Fix in progress Fix DeclarationKind layering fix One building In progress Breaking out refactoring helpers into core api vs service VB side In progress Move type workaround Update src/Workspaces/SharedUtilitiesAndExtensions/Compiler/CSharp/CSharpCompilerExtensions.projitems Fix SubText ctor parameter verification. (dotnet#78989) * Fix SubText ctor parameter verification. This ctor currently throws given a zero length span at the end (and only the end) of the subtext. This evidently became far more prevalent with this (fairly) recent change to optimize newline information in our sourcetext classes. (dotnet#74728) It doesn't make to allow zero length spans at all locations but at the end of the subtext, so the fix is just to allow construction in that case too. Big props to Manish Vasani for providing a very actionable repro for this. Fixes dotnet#78985. Note there is a potentially related issue outlined in dotnet#76225 that looks attributable to the PR above too. It possible that this addresses that issue too, but I'm not completely convinced. Extensions: bind unconditionally of LangVer (dotnet#78947) Extensions: use specific tracking issues for different areas (second pass) (dotnet#78971) Fix nullable analysis involving extensions and collection expressions (dotnet#78926) Update src/Workspaces/SharedUtilitiesAndExtensions/Compiler/CSharp/CSharpCompilerExtensions.projitems in progrss Update src/Workspaces/SharedUtilitiesAndExtensions/Compiler/Core/CompilerExtensions.projitems Update src/Workspaces/SharedUtilitiesAndExtensions/Compiler/VisualBasic/VisualBasicCompilerExtensions.projitems extensions Fix RootNamespace Fixes Fixes IN progress in progress
CyrusNajmabadi
commented
Jun 24, 2025
...SharedUtilitiesAndExtensions/Compiler/Extensions/Microsoft.CodeAnalysis.Extensions.projitems
Outdated
Show resolved
Hide resolved
…s/Microsoft.CodeAnalysis.Extensions.projitems
Member
Author
|
@JoeRobich ptal |
CyrusNajmabadi
commented
Jun 24, 2025
| public static readonly SyntaxToken ExplicitKeyword = Token(SyntaxKind.ExplicitKeyword); | ||
| #if !ROSLYN_4_12_OR_LOWER | ||
| public static readonly SyntaxToken ExtensionKeyword = Token(SyntaxKind.ExtensionKeyword); | ||
| #endif |
Member
Author
There was a problem hiding this comment.
will be used in RoslynAnalyzers, which will only be able to reference up to Ros 4.12 (we're currently at ros 4.14).
JoeRobich
approved these changes
Jun 24, 2025
CyrusNajmabadi
commented
Jun 24, 2025
| // The .NET Foundation licenses this file to you under the MIT license. | ||
| // See the LICENSE file in the project root for more information. | ||
|
|
||
| #pragma warning disable CS1574 // XML comment has cref attribute that could not be resolved |
Member
Author
There was a problem hiding this comment.
some comments that don't result when this is pulled into libs that don't reference all of the shared side of roslyn workspace.
CyrusNajmabadi
commented
Jun 24, 2025
| => typeSymbol.TryGetPrimaryConstructor(out primaryConstructor); | ||
|
|
||
| #if !CODE_STYLE | ||
| #if CSHARP_WORKSPACE |
Member
Author
There was a problem hiding this comment.
RoslynAnalyzers is also "!CODE_STYLE". so that breaks badly when sharing these files. i didn't feel comfortable defining that constnat for RoslynAnalyzers. So instead, i just flipped these to be either WORKSPACE or !WORKSPACE so that the right semantics are there for the workspace layer vs anyone else.
CyrusNajmabadi
commented
Jun 24, 2025
| <InternalsVisibleTo Include="Microsoft.CodeAnalysis.VisualBasic.CodeStyle.UnitTests" /> | ||
| </ItemGroup> | ||
| <ItemGroup> | ||
| <Compile Include="..\..\..\Workspaces\Core\Portable\Formatting\VisualBasic\VisualBasicSyntaxFormattingOptions.cs" Link="Formatting\VisualBasic\VisualBasicSyntaxFormattingOptions.cs" /> |
Member
Author
There was a problem hiding this comment.
referencing this now in the shrred lib. not as this weird one-off in a real project.
CyrusNajmabadi
commented
Jun 24, 2025
| DiagnosticSeverity.Warning => ReportDiagnostic.Warn, | ||
| DiagnosticSeverity.Error => ReportDiagnostic.Error, | ||
| _ => throw ExceptionUtilities.UnexpectedValue(diagnosticSeverity), | ||
| }; |
Member
Author
There was a problem hiding this comment.
moved to better location.
CyrusNajmabadi
commented
Jun 24, 2025
| } | ||
|
|
||
| return defaultSeverity.ToReportDiagnostic(); | ||
| } |
Member
Author
There was a problem hiding this comment.
moved to better location.
CyrusNajmabadi
commented
Jun 24, 2025
| <Import Include="Microsoft.CodeAnalysis.VisualBasic" /> | ||
| <Import Include="Microsoft.CodeAnalysis.VisualBasic.Extensions" /> | ||
| <Import Include="Roslyn.Utilities" /> | ||
| <Import Include="Roslyn.Utilities.Contract" /> |
This was referenced Jun 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pulled out of src/RoslynAnalyzers/Microsoft.CodeAnalysis.AnalyzerUtilities/Microsoft.CodeAnalysis.AnalyzerUtilities.csproj