Skip to content

Cleanup some unused resources in MS.CA and MS.CA.CSharp #80097

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Aug 31, 2025
Merged

Cleanup some unused resources in MS.CA and MS.CA.CSharp #80097

merged 2 commits into from
Aug 31, 2025

Conversation

@Youssef1313
Copy link
Member

@Youssef1313 Youssef1313 commented Aug 30, 2025

No description provided.

@Youssef1313 Youssef1313 requested a review from a team as a code owner August 30, 2025 19:52
@dotnet-policy-service dotnet-policy-service bot added the Community The pull request was submitted by a contributor who is not a Microsoft employee. label Aug 30, 2025
@CyrusNajmabadi CyrusNajmabadi merged commit a2075fd into dotnet:main Aug 31, 2025
24 checks passed
@CyrusNajmabadi
Copy link
Member

CyrusNajmabadi commented Aug 31, 2025

Thanks!

@CyrusNajmabadi
Copy link
Member

CyrusNajmabadi commented Aug 31, 2025

Ack. Sorry. I didn't realize this was in CA. This will need a second review.

@dotnet-policy-service dotnet-policy-service bot added this to the Next milestone Aug 31, 2025
@Youssef1313 Youssef1313 deleted the unused-resources branch August 31, 2025 04:31
AlekseyTs
AlekseyTs reviewed Sep 1, 2025
View reviewed changes
src/Compilers/CSharp/Portable/CSharpResources.resx
<data name="ERR_V6SwitchGoverningTypeValueExpected" xml:space="preserve">
<value>A switch expression or case label must be a bool, char, string, integral, enum, or corresponding nullable type in C# 6 and earlier.</value>
</data>
<data name="ERR_IntegralTypeValueExpected" xml:space="preserve">
Copy link
Contributor

@AlekseyTs AlekseyTs Sep 1, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ERR_IntegralTypeValueExpected

Are there matching members in an error enum? I guess the members should be removed, but the values should be kept reserved (unless the members were not shipped yet).

Copy link
Member Author

@Youssef1313 Youssef1313 Sep 1, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@AlekseyTs

roslyn/src/Compilers/CSharp/Portable/Errors/ErrorCode.cs

Lines 126 to 128 in a2075fd

// ERR_V6SwitchGoverningTypeValueExpected shares the same error code (CS0151) with ERR_IntegralTypeValueExpected in Dev10 compiler.
// However ERR_IntegralTypeValueExpected is currently unused and hence being removed. If we need to generate this error in future
// we can use error code CS0166. CS0166 was originally reserved for ERR_SwitchFallInto in Dev10, but was never used.

@AlekseyTs AlekseyTs mentioned this pull request Sep 1, 2025
Merged
@dotnet-bot dotnet-bot mentioned this pull request Sep 3, 2025
Closed
@akhera99 akhera99 modified the milestones: Next, 18.0 P1, 18.0 P2 Sep 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@AlekseyTs AlekseyTs AlekseyTs left review comments

@CyrusNajmabadi CyrusNajmabadi CyrusNajmabadi approved these changes

Assignees

No one assigned

Labels

Area-Compilers Community The pull request was submitted by a contributor who is not a Microsoft employee.

Projects

None yet

Milestone

18.0 P2

Development

Successfully merging this pull request may close these issues.

4 participants

@Youssef1313 @CyrusNajmabadi @AlekseyTs @akhera99