Skip to content

Cleanup some unused resources in MS.CA and MS.CA.CSharp #80097

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 31, 2025
Merged

Cleanup some unused resources in MS.CA and MS.CA.CSharp #80097

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
92250f8
Cleanup Microsoft.CodeAnalysis resources
Youssef1313 Aug 30, 2025
08c3e8b
Cleanup Microsoft.CodeAnalysis.CSharp resources
Youssef1313 Aug 30, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
38 changes: 1 addition & 37 deletions src/Compilers/CSharp/Portable/CSharpResources.resx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -783,9 +783,6 @@
<data name="ERR_V6SwitchGoverningTypeValueExpected" xml:space="preserve">
<value>A switch expression or case label must be a bool, char, string, integral, enum, or corresponding nullable type in C# 6 and earlier.</value>
</data>
<data name="ERR_IntegralTypeValueExpected" xml:space="preserve">
Copy link
Contributor

@AlekseyTs AlekseyTs Sep 1, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ERR_IntegralTypeValueExpected

Are there matching members in an error enum? I guess the members should be removed, but the values should be kept reserved (unless the members were not shipped yet).

Copy link
Member Author

@Youssef1313 Youssef1313 Sep 1, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@AlekseyTs

roslyn/src/Compilers/CSharp/Portable/Errors/ErrorCode.cs

Lines 126 to 128 in a2075fd

// ERR_V6SwitchGoverningTypeValueExpected shares the same error code (CS0151) with ERR_IntegralTypeValueExpected in Dev10 compiler.
// However ERR_IntegralTypeValueExpected is currently unused and hence being removed. If we need to generate this error in future
// we can use error code CS0166. CS0166 was originally reserved for ERR_SwitchFallInto in Dev10, but was never used.

<value>A value of an integral type expected</value>
</data>
<data name="ERR_DuplicateCaseLabel" xml:space="preserve">
<value>The switch statement contains multiple cases with the label value '{0}'</value>
</data>
Expand Down Expand Up @@ -1329,12 +1326,6 @@
<data name="ERR_AttrTypeArgCannotBeTypeVar" xml:space="preserve">
<value>'{0}': an attribute type argument cannot use type parameters</value>
</data>
<data name="WRN_AttrDependentTypeNotAllowed" xml:space="preserve">
<value>Type '{0}' cannot be used in this context because it cannot be represented in metadata.</value>
</data>
<data name="WRN_AttrDependentTypeNotAllowed_Title" xml:space="preserve">
<value>Type cannot be used in this context because it cannot be represented in metadata.</value>
</data>
<data name="ERR_AttrDependentTypeNotAllowed" xml:space="preserve">
<value>Type '{0}' cannot be used in this context because it cannot be represented in metadata.</value>
</data>
Expand Down Expand Up @@ -2677,9 +2668,6 @@ A catch() block after a catch (System.Exception e) block can catch non-CLS excep
<data name="ERR_NoMainInClass" xml:space="preserve">
<value>'{0}' does not have a suitable static 'Main' method</value>
</data>
<data name="ERR_MainClassIsImport" xml:space="preserve">
<value>Cannot use '{0}' for Main method because it is imported</value>
</data>
<data name="ERR_OutputNeedsName" xml:space="preserve">
<value>Outputs without source must have the /out option specified</value>
</data>
Expand Down Expand Up @@ -3193,27 +3181,12 @@ A catch() block after a catch (System.Exception e) block can catch non-CLS excep
<data name="WRN_CallOnNonAgileField_Description" xml:space="preserve">
<value>This warning occurs when you try to call a method, property, or indexer on a member of a class that derives from MarshalByRefObject, and the member is a value type. Objects that inherit from MarshalByRefObject are typically intended to be marshaled by reference across an application domain. If any code ever attempts to directly access the value-type member of such an object across an application domain, a runtime exception will occur. To resolve the warning, first copy the member into a local variable and call the method on that variable.</value>
</data>
<data name="WRN_BadWarningNumber" xml:space="preserve">
<value>'{0}' is not a valid warning number</value>
</data>
<data name="WRN_BadWarningNumber_Title" xml:space="preserve">
<value>Not a valid warning number</value>
</data>
<data name="WRN_BadWarningNumber_Description" xml:space="preserve">
<value>A number that was passed to the #pragma warning preprocessor directive was not a valid warning number. Verify that the number represents a warning, not an error.</value>
</data>
<data name="WRN_InvalidNumber" xml:space="preserve">
<value>Invalid number</value>
</data>
<data name="WRN_InvalidNumber_Title" xml:space="preserve">
<value>Invalid number</value>
</data>
<data name="WRN_FileNameTooLong" xml:space="preserve">
<value>Invalid filename specified for preprocessor directive. Filename is too long or not a valid filename.</value>
</data>
<data name="WRN_FileNameTooLong_Title" xml:space="preserve">
<value>Invalid filename specified for preprocessor directive</value>
</data>
<data name="WRN_IllegalPPChecksum" xml:space="preserve">
<value>Invalid #pragma checksum syntax; should be #pragma checksum "filename" "{XXXXXXXX-XXXX-XXXX-XXXX-XXXXXXXXXXXX}" "XXXX..."</value>
</data>
Expand Down Expand Up @@ -3481,9 +3454,6 @@ A catch() block after a catch (System.Exception e) block can catch non-CLS excep
<data name="ERR_VarArgsInExpressionTree" xml:space="preserve">
<value>An expression tree lambda may not contain a method with variable arguments</value>
</data>
<data name="ERR_MemGroupInExpressionTree" xml:space="preserve">
<value>An expression tree lambda may not contain a method group</value>
</data>
<data name="ERR_InitializerAddHasParamModifiers" xml:space="preserve">
<value>The best overloaded method match '{0}' for the collection initializer element cannot be used. Collection initializer 'Add' methods cannot have ref or out parameters.</value>
</data>
Expand Down Expand Up @@ -4945,9 +4915,6 @@ To remove the warning, you can use /reference instead (set the Embed Interop Typ
<data name="ERR_UnclosedExpressionHole" xml:space="preserve">
<value>Missing close delimiter '}' for interpolated expression started with '{'.</value>
</data>
<data name="ERR_SingleLineCommentInExpressionHole" xml:space="preserve">
<value>A single-line comment may not be used in an interpolated string.</value>
</data>
<data name="ERR_InsufficientStack" xml:space="preserve">
<value>An expression is too long or complex to compile</value>
</data>
Expand Down Expand Up @@ -7666,9 +7633,6 @@ To remove the warning, you can use /reference instead (set the Embed Interop Typ
<data name="ERR_InterceptorPathNotInCompilationWithCandidate" xml:space="preserve">
<value>Cannot intercept: compilation does not contain a file with path '{0}'. Did you mean to use path '{1}'?</value>
</data>
<data name="ERR_InterceptorPathNotInCompilationWithUnmappedCandidate" xml:space="preserve">
<value>Cannot intercept: Path '{0}' is unmapped. Expected mapped path '{1}'.</value>
</data>
<data name="ERR_InterceptorLineOutOfRange" xml:space="preserve">
<value>The given file has '{0}' lines, which is fewer than the provided line number '{1}'.</value>
</data>
Expand Down Expand Up @@ -8232,4 +8196,4 @@ To remove the warning, you can use /reference instead (set the Embed Interop Typ
<value>'MethodImplAttribute.Async' cannot be manually applied to methods. Mark the method 'async'.</value>
<remarks>'MethodImplAttribute.Async' and 'async' are not localizable.</remarks>
</data>
</root>
</root>
60 changes: 0 additions & 60 deletions src/Compilers/CSharp/Portable/xlf/CSharpResources.cs.xlf
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading