-
Notifications
You must be signed in to change notification settings - Fork 4.2k
Fix "Generate abstract method" adding disallowed async modifier #80629
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
CyrusNajmabadi
merged 3 commits into
main
from
copilot/fix-abstract-method-async-modifier
Oct 10, 2025
Merged
Fix "Generate abstract method" adding disallowed async modifier #80629
CyrusNajmabadi
merged 3 commits into
main
from
copilot/fix-abstract-method-async-modifier
Oct 10, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Only add async modifier when method is not abstract and returns Task-like type Co-authored-by: CyrusNajmabadi <4564579+CyrusNajmabadi@users.noreply.github.com>
| } | ||
| """, new(parseOptions: CSharpParseOptions.Default.WithLanguageVersion(LanguageVersion.CSharp14))); | ||
|
|
||
| [Fact] |
Member
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Contributor
Author
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added in commit cfe1b13.
Copilot
AI
changed the title
[WIP] Fix async modifier error in generated abstract method
Fix "Generate abstract method" adding disallowed async modifier
Oct 10, 2025
Copilot finished work on behalf of
CyrusNajmabadi
October 10, 2025 09:46
Co-authored-by: CyrusNajmabadi <4564579+CyrusNajmabadi@users.noreply.github.com>
Copilot finished work on behalf of
CyrusNajmabadi
October 10, 2025 09:51
CyrusNajmabadi
approved these changes
Oct 10, 2025
CyrusNajmabadi
approved these changes
Oct 10, 2025
Member
|
@davidwengier ptal. |
davidwengier
approved these changes
Oct 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixed the issue where "Generate abstract method" was incorrectly adding the
asyncmodifier to abstract methods that return Task-like types. Abstract methods cannot have theasyncmodifier because they don't have a body (CS1994 error).Changes Made:
asyncmodifier when the method is NOT abstract AND returns a Task-like typeTestGenerateAbstractMethodReturningTaskwith WorkItem attribute to verify abstract methods returning Task don't get the async modifierThe fix ensures that
WithAsync()is only set to true when!isAbstract && knownTypes.IsTaskLike(returnType), preventing the CS1994 error.Original prompt
Fixes #80628
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.