Skip to content

Fix "Generate abstract method" adding disallowed async modifier #80629

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Oct 10, 2025
Merged

Fix "Generate abstract method" adding disallowed async modifier #80629

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
98f735b
Initial plan
Copilot Oct 10, 2025
cfe1b13
Fix async modifier on abstract methods
Copilot Oct 10, 2025
2645d2f
Add WorkItem attribute to track GitHub issue #80628
Copilot Oct 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
29 changes: 29 additions & 0 deletions src/Analyzers/CSharp/Tests/GenerateMethod/GenerateMethodTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10613,4 +10613,33 @@ private int Goo()
}
}
""", new(parseOptions: CSharpParseOptions.Default.WithLanguageVersion(LanguageVersion.CSharp14)));

[Fact, WorkItem("https://github.com/dotnet/roslyn/issues/80628")]
public Task TestGenerateAbstractMethodReturningTask()
=> TestInRegularAndScriptAsync(
"""
using System.Threading.Tasks;

abstract class C
{
async Task M()
{
await [|M2|]();
}
}
""",
"""
using System.Threading.Tasks;

abstract class C
{
async Task M()
{
await M2();
}

protected abstract Task M2();
}
""",
index: 1);
}
2 changes: 1 addition & 1 deletion ...s/GenerateParameterizedMember/AbstractGenerateParameterizedMemberService.SignatureInfo.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -105,7 +105,7 @@ public async ValueTask<IMethodSymbol> GenerateMethodAsync(
attributes: default,
accessibility: DetermineAccessibility(isAbstract),
modifiers: DeclarationModifiers.None
.WithIsStatic(State.IsStatic).WithIsAbstract(isAbstract).WithIsUnsafe(isUnsafe).WithAsync(knownTypes.IsTaskLike(returnType)),
.WithIsStatic(State.IsStatic).WithIsAbstract(isAbstract).WithIsUnsafe(isUnsafe).WithAsync(!isAbstract && knownTypes.IsTaskLike(returnType)),
returnType: returnType,
refKind: DetermineRefKind(cancellationToken),
explicitInterfaceImplementations: default,
Expand Down
Loading