-
Notifications
You must be signed in to change notification settings - Fork 4.2k
Add regression test for ParseAttributeArgumentList with invalid input (fixes #8699) #80705
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
CyrusNajmabadi
merged 10 commits into
main
from
copilot/fix-nullreferenceexception-parseattributeargumentl
Oct 23, 2025
Merged
Add regression test for ParseAttributeArgumentList with invalid input (fixes #8699) #80705
CyrusNajmabadi
merged 10 commits into
main
from
copilot/fix-nullreferenceexception-parseattributeargumentl
Oct 23, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ithout NullReferenceException Co-authored-by: CyrusNajmabadi <4564579+CyrusNajmabadi@users.noreply.github.com>
Co-authored-by: CyrusNajmabadi <4564579+CyrusNajmabadi@users.noreply.github.com>
Co-authored-by: CyrusNajmabadi <4564579+CyrusNajmabadi@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix NullReferenceException in SyntaxFactory.ParseAttributeArgumentList
Add regression test for ParseAttributeArgumentList with invalid input (fixes #8699)
Oct 14, 2025
Copilot finished work on behalf of
CyrusNajmabadi
October 14, 2025 15:00
CyrusNajmabadi
approved these changes
Oct 14, 2025
AlekseyTs
reviewed
Oct 14, 2025
333fred
reviewed
Oct 14, 2025
src/Compilers/CSharp/Test/Syntax/Parsing/DeclarationParsingTests.cs
Outdated
Show resolved
Hide resolved
src/Compilers/CSharp/Test/Syntax/Parsing/DeclarationParsingTests.cs
Outdated
Show resolved
Hide resolved
333fred
reviewed
Oct 14, 2025
src/Compilers/CSharp/Test/Syntax/Parsing/DeclarationParsingTests.cs
Outdated
Show resolved
Hide resolved
src/Compilers/CSharp/Test/Syntax/Parsing/DeclarationParsingTests.cs
Outdated
Show resolved
Hide resolved
333fred
approved these changes
Oct 15, 2025
Member
|
@dotnet/roslyn-compiler for a second pair of eyes. |
333fred
added a commit
to 333fred/roslyn
that referenced
this pull request
Oct 24, 2025
* upstream/main: (332 commits) Cache lambdas in analyzer driver (dotnet#80759) Add information for NuGet package version 4.14 (dotnet#80870) Add missing search keywords to VB Advanced options page Fix IDE0031 false positive when preprocessor directives are used in if statements (dotnet#80878) Use core compiler on netfx hosts with toolset package (dotnet#80631) Make string concat assert more precise (dotnet#80619) Extensions: address some diagnostic quality issues (dotnet#80827) Add note on traversal order for bound nodes (dotnet#80872) Ensure that locals at the top level of a constructor have the same safe-context as parameters (dotnet#80807) Fix handling of SymbolDisplayCompilerInternalOptions.UseArityForGenericTypes option for non-native symbol implementations (dotnet#80826) Update src/Analyzers/CSharp/Tests/UseCollectionInitializer/UseCollectionInitializerTests.cs Add IsValidContainingStatement check to prevent collection initializers in using declarations Add back old DocumentSpan constructor (dotnet#80864) Add tests verifying pointer types in type parameters require unsafe context (dotnet#80776) Add regression test for Interlocked.Exchange with nullable types (dotnet#80796) Add regression test for ParseAttributeArgumentList with invalid input (fixes dotnet#8699) (dotnet#80705) Add regression test for compiler crash with syntax error in indexer declaration (dotnet#80772) Add runtime NullReferenceException validation to foreach null iteration tests (dotnet#80839) Update MicrosoftBuildTasksCoreVersionForMetrics to 17.11.48 (dotnet#80812) Mark CS4009 error as a "build only" error. (dotnet#80698) ...
This was referenced Oct 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds a regression test to verify that
SyntaxFactory.ParseAttributeArgumentListproperly handles invalid input without throwing aNullReferenceException.Issue
Issue #8699 reported that calling
SyntaxFactory.ParseAttributeArgumentList("somethingWithoutBrackets")would throw aNullReferenceExceptionwhen given text without parentheses.Resolution
Testing confirms that this issue is already fixed in the current codebase. The method now properly handles invalid input by:
AttributeArgumentListSyntaxobjectOpenParenTokenandCloseParenTokenChanges
Added
TestParseAttributeArgumentListWithInvalidStringtest that verifies:Example
This test serves as documentation that the issue has been resolved and prevents future regression.
Original prompt
Fixes #23877
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.