Extensions: Compare accessibility of implementation method with accessibility of declared extension method #81378
+79
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…bility of declared extension method. Due to an oversight it was compared to accessibility of extension block container, which is always `public`. Fixes dotnet#81180
AlekseyTs
added
Area-Compilers
Feature - Extension Everything
jcouv
reviewed
Nov 21, 2025
|
|
||
| compB = CreateCompilation(sourceB, references: [compA.EmitToImageReference()], assemblyName: "B", options: TestOptions.DebugExe); | ||
| CompileAndVerify(compB, expectedOutput: "TrueTrueFalse").VerifyDiagnostics(); | ||
| _ = ErrorCode.ERR_BindToBogus; |
Contributor
Author
There was a problem hiding this comment.
Probably was meant to be deleted
Yes, thanks!
jcouv
approved these changes
Nov 21, 2025
Member
jcouv
left a comment
jcouv
left a comment
There was a problem hiding this comment.
LGTM Thanks (commit 1) modulo small test cleanup
AlekseyTs
commented
Nov 21, 2025
|
|
||
| compB = CreateCompilation(sourceB, references: [compA.EmitToImageReference()], assemblyName: "B", options: TestOptions.DebugExe); | ||
| CompileAndVerify(compB, expectedOutput: "TrueTrueFalse").VerifyDiagnostics(); | ||
| _ = ErrorCode.ERR_BindToBogus; |
Contributor
Author
There was a problem hiding this comment.
Suggested change
| _ = ErrorCode.ERR_BindToBogus; |
Contributor
Author
|
@jjonescz, @dotnet/roslyn-compiler For a second review |
jjonescz
approved these changes
Nov 21, 2025
This was referenced Nov 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Due to an oversight it was compared to accessibility of extension block container, which is always
public.Fixes #81180
Relates to test plan #76130