Skip to content

Commit

Permalink
Libraries native renames (#31668)
Browse files Browse the repository at this point in the history
Match coreclr & cross compilation naming conventions

Rename BIT64                -> TARGET_64BIT   in src/libraries/Native
Rename BIT32                -> TARGET_32BIT   in src/libraries/Native
Rename FEATURE_PAL          -> TARGET_UNIX    in src/libraries/Native
Rename PLATFORM_UNIX        -> TARGET_UNIX    in src/libraries/Native
Rename PLATFORM_WINDOWS     -> TARGET_WINDOWS in src/libraries/Native
Rename PLATFORM_OSX         -> TARGET_OSX     in src/libraries/Native
Rename _ARM_                -> TARGET_ARM     in src/libraries/Native
Rename _ARM64_              -> TARGET_ARM64   in src/libraries/Native
Rename _AMD64_              -> TARGET_AMD64   in src/libraries/Native
Rename _X86_                -> TARGET_X86     in src/libraries/Native
Rename ARM                  -> TARGET_ARM     in src/libraries/Native
Rename ARM64                -> TARGET_ARM64   in src/libraries/Native
Rename AMD64                -> TARGET_AMD64   in src/libraries/Native
Rename X86_                 -> TARGET_X86     in src/libraries/Native
  • Loading branch information
sdmaclea authored Feb 3, 2020
1 parent cfbc420 commit 60f6129
Show file tree
Hide file tree
Showing 4 changed files with 20 additions and 20 deletions.
20 changes: 10 additions & 10 deletions src/libraries/Native/Unix/CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -56,18 +56,18 @@ else()
endif(CMAKE_SYSTEM_NAME STREQUAL Emscripten)

if (CMAKE_SYSTEM_PROCESSOR STREQUAL x86_64 OR CMAKE_SYSTEM_PROCESSOR STREQUAL amd64)
add_definitions(-DBIT64=1)
add_definitions(-D_AMD64_)
add_definitions(-DTARGET_64BIT=1)
add_definitions(-DTARGET_AMD64)
elseif (CMAKE_SYSTEM_PROCESSOR STREQUAL x86 OR CMAKE_SYSTEM_PROCESSOR STREQUAL i686)
add_definitions(-DBIT32=1)
add_definitions(-D_X86_)
add_definitions(-DTARGET_32BIT=1)
add_definitions(-DTARGET_X86)
add_definitions(-D_FILE_OFFSET_BITS=64)
elseif (CMAKE_SYSTEM_PROCESSOR STREQUAL aarch64)
add_definitions(-DBIT64=1)
add_definitions(-D_ARM64_)
add_definitions(-DTARGET_64BIT=1)
add_definitions(-DTARGET_ARM64)
elseif (CMAKE_SYSTEM_PROCESSOR STREQUAL armv7l)
add_definitions(-DBIT32=1)
add_definitions(-D_ARM_)
add_definitions(-DTARGET_32BIT=1)
add_definitions(-DTARGET_ARM)
add_definitions(-D_FILE_OFFSET_BITS=64)
if(ARM_SOFTFP)
add_compile_options(-mfloat-abi=softfp)
Expand All @@ -85,8 +85,8 @@ elseif (CMAKE_SYSTEM_PROCESSOR STREQUAL armv7l)

add_compile_options(-march=armv7-a)
elseif (CMAKE_SYSTEM_PROCESSOR STREQUAL arm)
add_definitions(-DBIT32=1)
add_definitions(-D_ARM_)
add_definitions(-DTARGET_32BIT=1)
add_definitions(-DTARGET_ARM)
add_definitions(-D_FILE_OFFSET_BITS=64)
endif ()

Expand Down
16 changes: 8 additions & 8 deletions src/libraries/Native/Unix/System.Native/pal_runtimeinformation.c
Original file line number Diff line number Diff line change
Expand Up @@ -45,13 +45,13 @@ int32_t SystemNative_GetUnixVersion(char* version, int* capacity)
3 - ARM64 */
int32_t SystemNative_GetOSArchitecture()
{
#if defined(_ARM_)
#if defined(TARGET_ARM)
return ARCH_ARM;
#elif defined(_ARM64_)
#elif defined(TARGET_ARM64)
return ARCH_ARM64;
#elif defined(_AMD64_)
#elif defined(TARGET_AMD64)
return ARCH_X64;
#elif defined(_X86_)
#elif defined(TARGET_X86)
return ARCH_X86;
#else
#error Unidentified Architecture
Expand All @@ -65,13 +65,13 @@ int32_t SystemNative_GetOSArchitecture()
3 - ARM64 */
int32_t SystemNative_GetProcessArchitecture()
{
#if defined(_ARM_)
#if defined(TARGET_ARM)
return ARCH_ARM;
#elif defined(_ARM64_)
#elif defined(TARGET_ARM64)
return ARCH_ARM64;
#elif defined(_AMD64_)
#elif defined(TARGET_AMD64)
return ARCH_X64;
#elif defined(_X86_)
#elif defined(TARGET_X86)
return ARCH_X86;
#else
#error Unidentified Architecture
Expand Down
2 changes: 1 addition & 1 deletion src/libraries/Native/Windows/CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -113,7 +113,7 @@ else()
endif()

if ($ENV{__BuildArch} STREQUAL "x86_64" OR $ENV{__BuildArch} STREQUAL "amd64")
add_definitions(-DBIT64=1)
add_definitions(-DTARGET_64BIT=1)
endif ()

if (UPPERCASE_CMAKE_BUILD_TYPE STREQUAL "DEBUG")
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,7 @@ local inline long compare258(z_const unsigned char *z_const src0,
"cmp $256 + 16, %[ax]\n\t"
"jb 1b\n\t"

#ifdef X86
#ifdef TARGET_X86
"movzwl -16(%[src0], %[ax]), %[dx]\n\t"
#else
"movzwq -16(%[src0], %[ax]), %[dx]\n\t"
Expand Down

0 comments on commit 60f6129

Please sign in to comment.