Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Libraries native renames #31668

Merged
merged 1 commit into from
Feb 3, 2020
Merged

Libraries native renames #31668

merged 1 commit into from
Feb 3, 2020

Conversation

sdmaclea
Copy link
Contributor

@sdmaclea sdmaclea commented Feb 3, 2020

Match coreclr & cross compilation naming conventions

Rename BIT64                -> TARGET_64BIT   in src/libraries/Native
Rename BIT32                -> TARGET_32BIT   in src/libraries/Native
Rename FEATURE_PAL          -> TARGET_UNIX    in src/libraries/Native
Rename PLATFORM_UNIX        -> TARGET_UNIX    in src/libraries/Native
Rename PLATFORM_WINDOWS     -> TARGET_WINDOWS in src/libraries/Native
Rename PLATFORM_OSX         -> TARGET_OSX     in src/libraries/Native
Rename _ARM_                -> TARGET_ARM     in src/libraries/Native
Rename _ARM64_              -> TARGET_ARM64   in src/libraries/Native
Rename _AMD64_              -> TARGET_AMD64   in src/libraries/Native
Rename _X86_                -> TARGET_X86     in src/libraries/Native
Rename ARM                  -> TARGET_ARM     in src/libraries/Native
Rename ARM64                -> TARGET_ARM64   in src/libraries/Native
Rename AMD64                -> TARGET_AMD64   in src/libraries/Native
Rename X86                  -> TARGET_X86     in src/libraries/Native

Match coreclr & cross compilation naming conventions

Rename BIT64                -> TARGET_64BIT   in src/libraries/Native
Rename BIT32                -> TARGET_32BIT   in src/libraries/Native
Rename FEATURE_PAL          -> TARGET_UNIX    in src/libraries/Native
Rename PLATFORM_UNIX        -> TARGET_UNIX    in src/libraries/Native
Rename PLATFORM_WINDOWS     -> TARGET_WINDOWS in src/libraries/Native
Rename PLATFORM_OSX         -> TARGET_OSX     in src/libraries/Native
Rename _ARM_                -> TARGET_ARM     in src/libraries/Native
Rename _ARM64_              -> TARGET_ARM64   in src/libraries/Native
Rename _AMD64_              -> TARGET_AMD64   in src/libraries/Native
Rename _X86_                -> TARGET_X86     in src/libraries/Native
Rename ARM                  -> TARGET_ARM     in src/libraries/Native
Rename ARM64                -> TARGET_ARM64   in src/libraries/Native
Rename AMD64                -> TARGET_AMD64   in src/libraries/Native
Rename X86_                 -> TARGET_X86     in src/libraries/Native
@sdmaclea sdmaclea requested a review from jkotas February 3, 2020 18:07
@sdmaclea sdmaclea self-assigned this Feb 3, 2020
@sdmaclea sdmaclea merged commit 60f6129 into dotnet:master Feb 3, 2020
@sdmaclea sdmaclea deleted the LibNativeRename branch February 3, 2020 20:42
@ghost ghost locked as resolved and limited conversation to collaborators Dec 10, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants