Skip to content

Commit

Permalink
Fix conflicting test assembly name in classloader tests (#93012)
Browse files Browse the repository at this point in the history
dd52 was building test.dll and dev10_897464 was building Test.dll which caused assembly resolving conflicts:

> warning MSB3243: No way to resolve conflict between "Test, Version=1.0.0.0, Culture=neutral, PublicKeyToken=null" and "test, Version=0.0.0.0, Culture=neutral, PublicKeyToken=null". Choosing "Test, Version=1.0.0.0, Culture=neutral, PublicKeyToken=null" arbitrarily.

Fixed by making the test assembly names unique for each test.
  • Loading branch information
akoeplinger committed Oct 5, 2023
1 parent 52aca8c commit 6e8259c
Show file tree
Hide file tree
Showing 6 changed files with 6 additions and 6 deletions.
2 changes: 1 addition & 1 deletion src/tests/Loader/classloader/regressions/dd52/dd52.csproj
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,6 @@
<Compile Include="runtest.cs" />
</ItemGroup>
<ItemGroup>
<ProjectReference Include="test.ilproj" />
<ProjectReference Include="test_dd52.ilproj" />
</ItemGroup>
</Project>
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
// The .NET Foundation licenses this file to you under the MIT license.

.assembly extern System.Console { }
.assembly test {}
.assembly test_dd52 {}
.assembly extern mscorlib {}


Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,6 @@
<OutputType>Library</OutputType>
</PropertyGroup>
<ItemGroup>
<Compile Include="test.il" />
<Compile Include="test_dd52.il" />
</ItemGroup>
</Project>
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
{
}

.assembly Test
.assembly Test_dev10_897464
{
.hash algorithm 0x00008004
.ver 1:0:0:0
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,6 @@
<OutputType>Library</OutputType>
</PropertyGroup>
<ItemGroup>
<Compile Include="Test.il" />
<Compile Include="Test_dev10_897464.il" />
</ItemGroup>
</Project>
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,6 @@
<Compile Include="$(MSBuildProjectName).cs" />
</ItemGroup>
<ItemGroup>
<ProjectReference Include="Test.ilproj" />
<ProjectReference Include="Test_dev10_897464.ilproj" />
</ItemGroup>
</Project>

0 comments on commit 6e8259c

Please sign in to comment.