Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix conflicting test assembly name in classloader tests #93012

Merged
merged 1 commit into from
Oct 5, 2023

Conversation

akoeplinger
Copy link
Member

dd52 was building test.dll and dev10_897464 was building Test.dll which caused assembly resolving conflicts:

warning MSB3243: No way to resolve conflict between "Test, Version=1.0.0.0, Culture=neutral, PublicKeyToken=null" and "test, Version=0.0.0.0, Culture=neutral, PublicKeyToken=null". Choosing "Test, Version=1.0.0.0, Culture=neutral, PublicKeyToken=null" arbitrarily.

Fixed by making the test assembly names unique for each test.

dd52 was building test.dll and dev10_897464 was building Test.dll which caused assembly resolving conflicts:

> warning MSB3243: No way to resolve conflict between "Test, Version=1.0.0.0, Culture=neutral, PublicKeyToken=null" and "test, Version=0.0.0.0, Culture=neutral, PublicKeyToken=null". Choosing "Test, Version=1.0.0.0, Culture=neutral, PublicKeyToken=null" arbitrarily.

Fixed by making the test assembly names unique for each test.
@ghost
Copy link

ghost commented Oct 4, 2023

Tagging subscribers to this area: @hoyosjs
See info in area-owners.md if you want to be subscribed.

Issue Details

dd52 was building test.dll and dev10_897464 was building Test.dll which caused assembly resolving conflicts:

warning MSB3243: No way to resolve conflict between "Test, Version=1.0.0.0, Culture=neutral, PublicKeyToken=null" and "test, Version=0.0.0.0, Culture=neutral, PublicKeyToken=null". Choosing "Test, Version=1.0.0.0, Culture=neutral, PublicKeyToken=null" arbitrarily.

Fixed by making the test assembly names unique for each test.

Author: akoeplinger
Assignees: akoeplinger
Labels:

area-Infrastructure-coreclr

Milestone: -

Copy link
Member

@trylek trylek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry about the overlooking. Thanks for fixing!

@akoeplinger akoeplinger merged commit 6e8259c into dotnet:main Oct 5, 2023
100 checks passed
@akoeplinger akoeplinger deleted the fix-conflicts branch October 5, 2023 08:09
@ghost ghost locked as resolved and limited conversation to collaborators Nov 4, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants