Skip to content

Commit

Permalink
Update APICompat.Task to latest version (#87046)
Browse files Browse the repository at this point in the history
* Update APICompat.Task to latest version

... and suppress the new errors that are flagged because of breaking changes introduced in .NET 8. See dotnet/sdk#32930 for more details on the added validation in APICompat.

* Suppress new errors that were intentionally made

* Update Version.Details.xml

* Update CompatibilitySuppressions.xml

* Update CompatibilitySuppressions.xml
  • Loading branch information
ViktorHofer authored Jun 2, 2023
1 parent 2855dd2 commit 71660b6
Show file tree
Hide file tree
Showing 9 changed files with 474 additions and 28 deletions.
4 changes: 2 additions & 2 deletions eng/Version.Details.xml
Original file line number Diff line number Diff line change
Expand Up @@ -364,9 +364,9 @@
<Uri>https://github.com/dotnet/roslyn-analyzers</Uri>
<Sha>2b6ab8d727ce73a78bcbf026ac75ea8a7c804daf</Sha>
</Dependency>
<Dependency Name="Microsoft.DotNet.ApiCompat.Task" Version="8.0.100-preview.2.23107.1">
<Dependency Name="Microsoft.DotNet.ApiCompat.Task" Version="8.0.100-preview.6.23301.17">
<Uri>https://github.com/dotnet/sdk</Uri>
<Sha>2fd62c3936f5336b836f6b12df170aa0e90da767</Sha>
<Sha>c4acda90a4dd0e164631e1e5d3b51003d0928d62</Sha>
<SourceBuild RepoName="sdk" ManagedOnly="true" />
</Dependency>
<Dependency Name="optimization.windows_nt-arm64.MIBC.Runtime" Version="1.0.0-prerelease.23272.4">
Expand Down
2 changes: 1 addition & 1 deletion eng/Versions.props
Original file line number Diff line number Diff line change
Expand Up @@ -81,7 +81,7 @@
<PropertyGroup>
<StaticCsVersion>0.2.0</StaticCsVersion>
<!-- SDK dependencies -->
<MicrosoftDotNetApiCompatTaskVersion>8.0.100-preview.2.23107.1</MicrosoftDotNetApiCompatTaskVersion>
<MicrosoftDotNetApiCompatTaskVersion>8.0.100-preview.6.23301.17</MicrosoftDotNetApiCompatTaskVersion>
<!-- Arcade dependencies -->
<MicrosoftDotNetBuildTasksFeedVersion>8.0.0-beta.23281.3</MicrosoftDotNetBuildTasksFeedVersion>
<MicrosoftDotNetCodeAnalysisVersion>8.0.0-beta.23281.3</MicrosoftDotNetCodeAnalysisVersion>
Expand Down
Original file line number Diff line number Diff line change
@@ -0,0 +1,33 @@
<?xml version="1.0" encoding="utf-8"?>
<!-- https://learn.microsoft.com/en-us/dotnet/fundamentals/package-validation/diagnostic-ids -->
<Suppressions xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xmlns:xsd="http://www.w3.org/2001/XMLSchema">
<!-- RequiresDynamicCodeAttribute was removed during .NET 8 with https://github.com/dotnet/runtime/commit/f424c0f7ce8b1453d7124a3def8cf44a4ff42ead. -->
<Suppression>
<DiagnosticId>CP0014</DiagnosticId>
<Target>M:Microsoft.Extensions.DependencyInjection.ServiceCollectionContainerBuilderExtensions.BuildServiceProvider(Microsoft.Extensions.DependencyInjection.IServiceCollection,Microsoft.Extensions.DependencyInjection.ServiceProviderOptions):[T:System.Diagnostics.CodeAnalysis.RequiresDynamicCodeAttribute]</Target>
<Left>lib/net7.0/Microsoft.Extensions.DependencyInjection.dll</Left>
<Right>lib/net7.0/Microsoft.Extensions.DependencyInjection.dll</Right>
<IsBaselineSuppression>true</IsBaselineSuppression>
</Suppression>
<Suppression>
<DiagnosticId>CP0014</DiagnosticId>
<Target>M:Microsoft.Extensions.DependencyInjection.ServiceCollectionContainerBuilderExtensions.BuildServiceProvider(Microsoft.Extensions.DependencyInjection.IServiceCollection,System.Boolean):[T:System.Diagnostics.CodeAnalysis.RequiresDynamicCodeAttribute]</Target>
<Left>lib/net7.0/Microsoft.Extensions.DependencyInjection.dll</Left>
<Right>lib/net7.0/Microsoft.Extensions.DependencyInjection.dll</Right>
<IsBaselineSuppression>true</IsBaselineSuppression>
</Suppression>
<Suppression>
<DiagnosticId>CP0014</DiagnosticId>
<Target>M:Microsoft.Extensions.DependencyInjection.ServiceCollectionContainerBuilderExtensions.BuildServiceProvider(Microsoft.Extensions.DependencyInjection.IServiceCollection):[T:System.Diagnostics.CodeAnalysis.RequiresDynamicCodeAttribute]</Target>
<Left>lib/net7.0/Microsoft.Extensions.DependencyInjection.dll</Left>
<Right>lib/net7.0/Microsoft.Extensions.DependencyInjection.dll</Right>
<IsBaselineSuppression>true</IsBaselineSuppression>
</Suppression>
<Suppression>
<DiagnosticId>CP0014</DiagnosticId>
<Target>T:Microsoft.Extensions.DependencyInjection.DefaultServiceProviderFactory:[T:System.Diagnostics.CodeAnalysis.RequiresDynamicCodeAttribute]</Target>
<Left>lib/net7.0/Microsoft.Extensions.DependencyInjection.dll</Left>
<Right>lib/net7.0/Microsoft.Extensions.DependencyInjection.dll</Right>
<IsBaselineSuppression>true</IsBaselineSuppression>
</Suppression>
</Suppressions>
Original file line number Diff line number Diff line change
@@ -0,0 +1,82 @@
<?xml version="1.0" encoding="utf-8"?>
<!-- https://learn.microsoft.com/en-us/dotnet/fundamentals/package-validation/diagnostic-ids -->
<Suppressions xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xmlns:xsd="http://www.w3.org/2001/XMLSchema">
<!-- RequiresDynamicCode attributes removed during .NET 8: https://github.com/dotnet/runtime/commit/f424c0f7ce8b1453d7124a3def8cf44a4ff42ead. -->
<Suppression>
<DiagnosticId>CP0014</DiagnosticId>
<Target>M:Microsoft.Extensions.Hosting.Host.CreateApplicationBuilder:[T:System.Diagnostics.CodeAnalysis.RequiresDynamicCodeAttribute]</Target>
<Left>lib/net7.0/Microsoft.Extensions.Hosting.dll</Left>
<Right>lib/net7.0/Microsoft.Extensions.Hosting.dll</Right>
<IsBaselineSuppression>true</IsBaselineSuppression>
</Suppression>
<Suppression>
<DiagnosticId>CP0014</DiagnosticId>
<Target>M:Microsoft.Extensions.Hosting.Host.CreateApplicationBuilder(System.String[]):[T:System.Diagnostics.CodeAnalysis.RequiresDynamicCodeAttribute]</Target>
<Left>lib/net7.0/Microsoft.Extensions.Hosting.dll</Left>
<Right>lib/net7.0/Microsoft.Extensions.Hosting.dll</Right>
<IsBaselineSuppression>true</IsBaselineSuppression>
</Suppression>
<Suppression>
<DiagnosticId>CP0014</DiagnosticId>
<Target>M:Microsoft.Extensions.Hosting.Host.CreateDefaultBuilder:[T:System.Diagnostics.CodeAnalysis.RequiresDynamicCodeAttribute]</Target>
<Left>lib/net7.0/Microsoft.Extensions.Hosting.dll</Left>
<Right>lib/net7.0/Microsoft.Extensions.Hosting.dll</Right>
<IsBaselineSuppression>true</IsBaselineSuppression>
</Suppression>
<Suppression>
<DiagnosticId>CP0014</DiagnosticId>
<Target>M:Microsoft.Extensions.Hosting.Host.CreateDefaultBuilder(System.String[]):[T:System.Diagnostics.CodeAnalysis.RequiresDynamicCodeAttribute]</Target>
<Left>lib/net7.0/Microsoft.Extensions.Hosting.dll</Left>
<Right>lib/net7.0/Microsoft.Extensions.Hosting.dll</Right>
<IsBaselineSuppression>true</IsBaselineSuppression>
</Suppression>
<Suppression>
<DiagnosticId>CP0014</DiagnosticId>
<Target>M:Microsoft.Extensions.Hosting.HostApplicationBuilder.#ctor:[T:System.Diagnostics.CodeAnalysis.RequiresDynamicCodeAttribute]</Target>
<Left>lib/net7.0/Microsoft.Extensions.Hosting.dll</Left>
<Right>lib/net7.0/Microsoft.Extensions.Hosting.dll</Right>
<IsBaselineSuppression>true</IsBaselineSuppression>
</Suppression>
<Suppression>
<DiagnosticId>CP0014</DiagnosticId>
<Target>M:Microsoft.Extensions.Hosting.HostApplicationBuilder.#ctor(Microsoft.Extensions.Hosting.HostApplicationBuilderSettings):[T:System.Diagnostics.CodeAnalysis.RequiresDynamicCodeAttribute]</Target>
<Left>lib/net7.0/Microsoft.Extensions.Hosting.dll</Left>
<Right>lib/net7.0/Microsoft.Extensions.Hosting.dll</Right>
<IsBaselineSuppression>true</IsBaselineSuppression>
</Suppression>
<Suppression>
<DiagnosticId>CP0014</DiagnosticId>
<Target>M:Microsoft.Extensions.Hosting.HostApplicationBuilder.#ctor(System.String[]):[T:System.Diagnostics.CodeAnalysis.RequiresDynamicCodeAttribute]</Target>
<Left>lib/net7.0/Microsoft.Extensions.Hosting.dll</Left>
<Right>lib/net7.0/Microsoft.Extensions.Hosting.dll</Right>
<IsBaselineSuppression>true</IsBaselineSuppression>
</Suppression>
<Suppression>
<DiagnosticId>CP0014</DiagnosticId>
<Target>M:Microsoft.Extensions.Hosting.HostBuilder.#ctor:[T:System.Diagnostics.CodeAnalysis.RequiresDynamicCodeAttribute]</Target>
<Left>lib/net7.0/Microsoft.Extensions.Hosting.dll</Left>
<Right>lib/net7.0/Microsoft.Extensions.Hosting.dll</Right>
<IsBaselineSuppression>true</IsBaselineSuppression>
</Suppression>
<Suppression>
<DiagnosticId>CP0014</DiagnosticId>
<Target>M:Microsoft.Extensions.Hosting.HostingHostBuilderExtensions.ConfigureDefaults(Microsoft.Extensions.Hosting.IHostBuilder,System.String[]):[T:System.Diagnostics.CodeAnalysis.RequiresDynamicCodeAttribute]</Target>
<Left>lib/net7.0/Microsoft.Extensions.Hosting.dll</Left>
<Right>lib/net7.0/Microsoft.Extensions.Hosting.dll</Right>
<IsBaselineSuppression>true</IsBaselineSuppression>
</Suppression>
<Suppression>
<DiagnosticId>CP0014</DiagnosticId>
<Target>M:Microsoft.Extensions.Hosting.HostingHostBuilderExtensions.UseDefaultServiceProvider(Microsoft.Extensions.Hosting.IHostBuilder,System.Action{Microsoft.Extensions.DependencyInjection.ServiceProviderOptions}):[T:System.Diagnostics.CodeAnalysis.RequiresDynamicCodeAttribute]</Target>
<Left>lib/net7.0/Microsoft.Extensions.Hosting.dll</Left>
<Right>lib/net7.0/Microsoft.Extensions.Hosting.dll</Right>
<IsBaselineSuppression>true</IsBaselineSuppression>
</Suppression>
<Suppression>
<DiagnosticId>CP0014</DiagnosticId>
<Target>M:Microsoft.Extensions.Hosting.HostingHostBuilderExtensions.UseDefaultServiceProvider(Microsoft.Extensions.Hosting.IHostBuilder,System.Action{Microsoft.Extensions.Hosting.HostBuilderContext,Microsoft.Extensions.DependencyInjection.ServiceProviderOptions}):[T:System.Diagnostics.CodeAnalysis.RequiresDynamicCodeAttribute]</Target>
<Left>lib/net7.0/Microsoft.Extensions.Hosting.dll</Left>
<Right>lib/net7.0/Microsoft.Extensions.Hosting.dll</Right>
<IsBaselineSuppression>true</IsBaselineSuppression>
</Suppression>
</Suppressions>
Original file line number Diff line number Diff line change
@@ -0,0 +1,12 @@
<?xml version="1.0" encoding="utf-8"?>
<!-- https://learn.microsoft.com/en-us/dotnet/fundamentals/package-validation/diagnostic-ids -->
<Suppressions xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xmlns:xsd="http://www.w3.org/2001/XMLSchema">
<!-- RequiresDynamicCodeAttribute was removed during .NET 8 with https://github.com/dotnet/runtime/commit/f424c0f7ce8b1453d7124a3def8cf44a4ff42ead. -->
<Suppression>
<DiagnosticId>CP0014</DiagnosticId>
<Target>M:Microsoft.Extensions.Logging.LoggerFactory.Create(System.Action{Microsoft.Extensions.Logging.ILoggingBuilder}):[T:System.Diagnostics.CodeAnalysis.RequiresDynamicCodeAttribute]</Target>
<Left>lib/net7.0/Microsoft.Extensions.Logging.dll</Left>
<Right>lib/net7.0/Microsoft.Extensions.Logging.dll</Right>
<IsBaselineSuppression>true</IsBaselineSuppression>
</Suppression>
</Suppressions>
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
<?xml version="1.0" encoding="utf-8"?>
<!-- https://learn.microsoft.com/en-us/dotnet/fundamentals/package-validation/diagnostic-ids -->
<Suppressions xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xmlns:xsd="http://www.w3.org/2001/XMLSchema">
<Suppression>
<DiagnosticId>CP0002</DiagnosticId>
Expand Down Expand Up @@ -42,6 +43,91 @@
<Left>lib/netstandard2.0/System.Configuration.ConfigurationManager.dll</Left>
<Right>lib/net462/System.Configuration.ConfigurationManager.dll</Right>
</Suppression>
<!-- Switched from using the public ObsoleteAttribute to the internal one during .NET 8: https://github.com/dotnet/runtime/commit/9d6e592e39e6410760988fcf0370d03c6505959e. -->
<Suppression>
<DiagnosticId>CP0014</DiagnosticId>
<Target>F:System.Configuration.SettingsSerializeAs.Binary:[T:System.ObsoleteAttribute]</Target>
<Left>lib/netstandard2.0/System.Configuration.ConfigurationManager.dll</Left>
<Right>lib/netstandard2.0/System.Configuration.ConfigurationManager.dll</Right>
<IsBaselineSuppression>true</IsBaselineSuppression>
</Suppression>
<Suppression>
<DiagnosticId>CP0014</DiagnosticId>
<Target>M:System.Configuration.ConfigurationException.#ctor:[T:System.ObsoleteAttribute]</Target>
<Left>lib/netstandard2.0/System.Configuration.ConfigurationManager.dll</Left>
<Right>lib/netstandard2.0/System.Configuration.ConfigurationManager.dll</Right>
<IsBaselineSuppression>true</IsBaselineSuppression>
</Suppression>
<Suppression>
<DiagnosticId>CP0014</DiagnosticId>
<Target>M:System.Configuration.ConfigurationException.#ctor(System.String,System.Exception,System.String,System.Int32):[T:System.ObsoleteAttribute]</Target>
<Left>lib/netstandard2.0/System.Configuration.ConfigurationManager.dll</Left>
<Right>lib/netstandard2.0/System.Configuration.ConfigurationManager.dll</Right>
<IsBaselineSuppression>true</IsBaselineSuppression>
</Suppression>
<Suppression>
<DiagnosticId>CP0014</DiagnosticId>
<Target>M:System.Configuration.ConfigurationException.#ctor(System.String,System.Exception,System.Xml.XmlNode):[T:System.ObsoleteAttribute]</Target>
<Left>lib/netstandard2.0/System.Configuration.ConfigurationManager.dll</Left>
<Right>lib/netstandard2.0/System.Configuration.ConfigurationManager.dll</Right>
<IsBaselineSuppression>true</IsBaselineSuppression>
</Suppression>
<Suppression>
<DiagnosticId>CP0014</DiagnosticId>
<Target>M:System.Configuration.ConfigurationException.#ctor(System.String,System.Exception):[T:System.ObsoleteAttribute]</Target>
<Left>lib/netstandard2.0/System.Configuration.ConfigurationManager.dll</Left>
<Right>lib/netstandard2.0/System.Configuration.ConfigurationManager.dll</Right>
<IsBaselineSuppression>true</IsBaselineSuppression>
</Suppression>
<Suppression>
<DiagnosticId>CP0014</DiagnosticId>
<Target>M:System.Configuration.ConfigurationException.#ctor(System.String,System.String,System.Int32):[T:System.ObsoleteAttribute]</Target>
<Left>lib/netstandard2.0/System.Configuration.ConfigurationManager.dll</Left>
<Right>lib/netstandard2.0/System.Configuration.ConfigurationManager.dll</Right>
<IsBaselineSuppression>true</IsBaselineSuppression>
</Suppression>
<Suppression>
<DiagnosticId>CP0014</DiagnosticId>
<Target>M:System.Configuration.ConfigurationException.#ctor(System.String,System.Xml.XmlNode):[T:System.ObsoleteAttribute]</Target>
<Left>lib/netstandard2.0/System.Configuration.ConfigurationManager.dll</Left>
<Right>lib/netstandard2.0/System.Configuration.ConfigurationManager.dll</Right>
<IsBaselineSuppression>true</IsBaselineSuppression>
</Suppression>
<Suppression>
<DiagnosticId>CP0014</DiagnosticId>
<Target>M:System.Configuration.ConfigurationException.#ctor(System.String):[T:System.ObsoleteAttribute]</Target>
<Left>lib/netstandard2.0/System.Configuration.ConfigurationManager.dll</Left>
<Right>lib/netstandard2.0/System.Configuration.ConfigurationManager.dll</Right>
<IsBaselineSuppression>true</IsBaselineSuppression>
</Suppression>
<Suppression>
<DiagnosticId>CP0014</DiagnosticId>
<Target>M:System.Configuration.ConfigurationException.GetXmlNodeFilename(System.Xml.XmlNode):[T:System.ObsoleteAttribute]</Target>
<Left>lib/netstandard2.0/System.Configuration.ConfigurationManager.dll</Left>
<Right>lib/netstandard2.0/System.Configuration.ConfigurationManager.dll</Right>
<IsBaselineSuppression>true</IsBaselineSuppression>
</Suppression>
<Suppression>
<DiagnosticId>CP0014</DiagnosticId>
<Target>M:System.Configuration.ConfigurationException.GetXmlNodeLineNumber(System.Xml.XmlNode):[T:System.ObsoleteAttribute]</Target>
<Left>lib/netstandard2.0/System.Configuration.ConfigurationManager.dll</Left>
<Right>lib/netstandard2.0/System.Configuration.ConfigurationManager.dll</Right>
<IsBaselineSuppression>true</IsBaselineSuppression>
</Suppression>
<Suppression>
<DiagnosticId>CP0014</DiagnosticId>
<Target>M:System.Configuration.ConfigurationSettings.GetConfig(System.String):[T:System.ObsoleteAttribute]</Target>
<Left>lib/netstandard2.0/System.Configuration.ConfigurationManager.dll</Left>
<Right>lib/netstandard2.0/System.Configuration.ConfigurationManager.dll</Right>
<IsBaselineSuppression>true</IsBaselineSuppression>
</Suppression>
<Suppression>
<DiagnosticId>CP0014</DiagnosticId>
<Target>P:System.Configuration.ConfigurationSettings.AppSettings:[T:System.ObsoleteAttribute]</Target>
<Left>lib/netstandard2.0/System.Configuration.ConfigurationManager.dll</Left>
<Right>lib/netstandard2.0/System.Configuration.ConfigurationManager.dll</Right>
<IsBaselineSuppression>true</IsBaselineSuppression>
</Suppression>
<Suppression>
<DiagnosticId>CP0015</DiagnosticId>
<Target>M:System.Configuration.ConfigurationException.#ctor:[T:System.ObsoleteAttribute]</Target>
Expand Down Expand Up @@ -108,4 +194,4 @@
<Left>lib/netstandard2.0/System.Configuration.ConfigurationManager.dll</Left>
<Right>lib/net462/System.Configuration.ConfigurationManager.dll</Right>
</Suppression>
</Suppressions>
</Suppressions>
Original file line number Diff line number Diff line change
@@ -0,0 +1,33 @@
<?xml version="1.0" encoding="utf-8"?>
<!-- https://learn.microsoft.com/en-us/dotnet/fundamentals/package-validation/diagnostic-ids -->
<Suppressions xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xmlns:xsd="http://www.w3.org/2001/XMLSchema">
<!-- DiagnosticSource made NativeAOT compatible during .NET 8: https://github.com/dotnet/runtime/commit/70b33f8f69128eeb1463691e24646987b54a0e3d. -->
<Suppression>
<DiagnosticId>CP0014</DiagnosticId>
<Target>M:System.Diagnostics.DiagnosticListener.Write(System.String,System.Object):[T:System.Diagnostics.CodeAnalysis.RequiresDynamicCodeAttribute]</Target>
<Left>lib/net7.0/System.Diagnostics.DiagnosticSource.dll</Left>
<Right>lib/net7.0/System.Diagnostics.DiagnosticSource.dll</Right>
<IsBaselineSuppression>true</IsBaselineSuppression>
</Suppression>
<Suppression>
<DiagnosticId>CP0014</DiagnosticId>
<Target>M:System.Diagnostics.DiagnosticSource.StartActivity(System.Diagnostics.Activity,System.Object):[T:System.Diagnostics.CodeAnalysis.RequiresDynamicCodeAttribute]</Target>
<Left>lib/net7.0/System.Diagnostics.DiagnosticSource.dll</Left>
<Right>lib/net7.0/System.Diagnostics.DiagnosticSource.dll</Right>
<IsBaselineSuppression>true</IsBaselineSuppression>
</Suppression>
<Suppression>
<DiagnosticId>CP0014</DiagnosticId>
<Target>M:System.Diagnostics.DiagnosticSource.StopActivity(System.Diagnostics.Activity,System.Object):[T:System.Diagnostics.CodeAnalysis.RequiresDynamicCodeAttribute]</Target>
<Left>lib/net7.0/System.Diagnostics.DiagnosticSource.dll</Left>
<Right>lib/net7.0/System.Diagnostics.DiagnosticSource.dll</Right>
<IsBaselineSuppression>true</IsBaselineSuppression>
</Suppression>
<Suppression>
<DiagnosticId>CP0014</DiagnosticId>
<Target>M:System.Diagnostics.DiagnosticSource.Write(System.String,System.Object):[T:System.Diagnostics.CodeAnalysis.RequiresDynamicCodeAttribute]</Target>
<Left>lib/net7.0/System.Diagnostics.DiagnosticSource.dll</Left>
<Right>lib/net7.0/System.Diagnostics.DiagnosticSource.dll</Right>
<IsBaselineSuppression>true</IsBaselineSuppression>
</Suppression>
</Suppressions>
Loading

0 comments on commit 71660b6

Please sign in to comment.