Update APICompat.Task to latest version #87046
Conversation
... and suppress the new errors that are flagged because of breaking changes introduced in .NET 8. See dotnet/sdk#32930 for more details on the added validation in APICompat.
|
Tagging subscribers to this area: @dotnet/area-infrastructure-libraries Issue Details... and suppress the new errors that are flagged because of breaking changes introduced in .NET 8. See dotnet/sdk#32930 for more details on the added validation in APICompat.
|
ViktorHofer
force-pushed
the
ViktorHofer-patch-1
branch
from
da8aeab to
30bebbe
Compare
ViktorHofer
requested review from
steveharter and
eerhardt
and removed request for
eerhardt
| @@ -81,7 +81,7 @@ | |||
| <PropertyGroup> | |||
| <StaticCsVersion>0.2.0</StaticCsVersion> | |||
| <!-- SDK dependencies --> | |||
| <MicrosoftDotNetApiCompatTaskVersion>8.0.100-preview.2.23107.1</MicrosoftDotNetApiCompatTaskVersion> | |||
| <MicrosoftDotNetApiCompatTaskVersion>8.0.100-preview.6.23301.17</MicrosoftDotNetApiCompatTaskVersion> | |||
There was a problem hiding this comment.
Why don't we use the version that comes with the SDK? So then we don't have to manually update it. I see it is 4 previews old right now.
There was a problem hiding this comment.
We used to have a subscription that apparently got stale. We want to consume the very latest features from APICompat. dotnet/runtime is our dogfood repository for APICompat. For this specific case, I just yesterday merged dotnet/sdk#32930 and would need to wait 1-2 months until I could consume the change in dotnet/runtime.
The second reason for using the NuGet package over what's inside the SDK is that the nuget package includes msbuild target files for 1:1 assembly comparison (ref <--> src) which isn't yet available in the SDK.
src/libraries/System.Configuration.ConfigurationManager/src/CompatibilitySuppressions.xml
Outdated
Show resolved
Hide resolved
ghost
locked as resolved and limited conversation to collaborators
... and suppress the new errors that are flagged because of breaking changes introduced in .NET 8. See dotnet/sdk#32930 for more details on the added validation in APICompat.